Prevent crash when logging in #81

2022-10-17T17:38:21Z

davidoskky commented

2022-10-17 17:38:21 +00:00

Types of changes

I have read the CONTRIBUTING document.
My code follows the code style of this project.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.
This is NOT translation related.

While running on some emulators I have seen that it sometimes crashes on login because it tries to make api calls on localhost.
Preventing those calls if not already logged in solves the problem.

I also moved the definition of dateUtils within the login function so that it gets updated after logging in.

## Types of changes - [x] I have read the **CONTRIBUTING** document. - [x] My code follows the code style of this project. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [x] All new and existing tests passed. - [x] This is **NOT** translation related. While running on some emulators I have seen that it sometimes crashes on login because it tries to make api calls on localhost. Preventing those calls if not already logged in solves the problem. I also moved the definition of dateUtils within the login function so that it gets updated after logging in.

davidoskky added 1 commit 2022-10-17 17:38:22 +00:00

Prevent crash when logging in

continuous-integration/drone/pr Build was killed

Details

c25e8889a4

AmineB requested changes 2022-10-17 17:44:44 +00:00

shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt Outdated

						
				@@ -47,3 +46,1 @@

				            updateApiVersion()

				            dateUtils = DateUtils(appSettingsService)

				            reloadBadges()

				        if (appSettingsService.getBaseUrl() != "") {

AmineB commented

2022-10-17 17:44:17 +00:00

getBaseUrl should never return an empty string.

There is a verification done before even logging-in (and saving the settings), so this should never happen.

`getBaseUrl` should never return an empty string. There is a verification done before even logging-in (and saving the settings), so this should never happen.

davidoskky commented

2022-10-17 18:26:33 +00:00

The repository is initialized before logging in, at that point appSettingsService returns an empty string

AmineB commented

2022-10-17 18:56:14 +00:00

Ok, so this is a workaround.

The issue is that the runBlocking block is called even when the user is'nt updated. This should be fixed.

Ok, so this is a workaround. The issue is that the `runBlocking` block is called even when the user is'nt updated. This should be fixed.

davidoskky commented

2022-10-18 11:14:38 +00:00

I could remove this from the init method and make a new public method which is called by the login activity after it checks that the user is correctly set.

AmineB commented

2022-10-18 12:06:55 +00:00

that could be better, yes !

AmineB marked this conversation as resolved

shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt Outdated

						
				@@ -408,6 +409,7 @@ class Repository(private val api: SelfossApi, private val appSettingsService: Ap

				                appSettingsService.updateApiVersion(fetchedVersion.data.getApiMajorVersion())

				            }

				        }

				        dateUtils = DateUtils(appSettingsService)