Louvorg/ReaderForSelfoss-multiplatform
Louvorg/ReaderForSelfoss-multiplatform
3
2
Fork 2
Code Issues 16 Pull Requests Actions Projects 1 Releases 68 Wiki Activity

Delete unused preference setting #145

Closed
davidoskky wants to merge 1 commits from davidoskky/ReaderForSelfoss-multiplatform:update_sources into master
pull from: davidoskky/ReaderForSelfoss-multiplatform:update_sources
merge into: Louvorg:master
Conversation 2 Commits 1 Files Changed 19 +17 -71
davidoskky commented 2023-07-14 09:25:35 +00:00
Contributor
Copy Link

Types of changes

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This is NOT translation related.

The setting to not refresh sources was unused.

## Types of changes - [x] I have read the **CONTRIBUTING** document. - [x] My code follows the code style of this project. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [x] All new and existing tests passed. - [x] This is **NOT** translation related. The setting to not refresh sources was unused.
davidoskky added 1 commit 2023-07-14 09:25:37 +00:00
Delete unused preference setting
Some checks failed
continuous-integration/drone/pr Build is failing
Details
462d3c513c
AmineB commented 2023-07-15 18:24:10 +00:00
Owner
Copy Link

There is 22 uses of isUpdateSourcesEnabled in the code. It is still used.

There is 22 uses of `isUpdateSourcesEnabled` in the code. It is still used.
AmineB closed this pull request 2023-07-15 18:40:46 +00:00
davidoskky commented 2023-07-23 09:22:43 +00:00
Author
Contributor
Copy Link

Oh, I stand corrected. Funny since I was the one who implemented those checks...

Oh, I stand corrected. Funny since I was the one who implemented those checks...
Some checks failed
continuous-integration/drone/pr Build is failing
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Difficulty - Beginner friendly

   
Difficulty = Easy

   
Difficulty = Hard

   
Difficulty = Medium

   
Priority = CRITICAL

   
Priority = High

   
Priority = Low

   
Priority = Normal

   
Priority = Some day

   
Status - Fixed somewhere else

   
Status - No details provided

   
Status = Can't fix

   
Status = Duplicate

   
Status = Help wanted

   
Status = Invalid

   
Status = Need more details

   
Status = Taken

   
Status = Wontfix

   
Type - Selfoss works like this

   
Type = Bug

   
Type = Chore

   
Type = Enhancement

   
Type = Feature

   
Type = Question

   
Type = SELFOSS API ISSUE

   
Type = Tools

   
Type = UX/Design

   
Up For Grabs
No Label
Difficulty - Beginner friendly
Difficulty = Easy
Difficulty = Hard
Difficulty = Medium
Priority = CRITICAL
Priority = High
Priority = Low
Priority = Normal
Priority = Some day
Status - Fixed somewhere else
Status - No details provided
Status = Can't fix
Status = Duplicate
Status = Help wanted
Status = Invalid
Status = Need more details
Status = Taken
Status = Wontfix
Type - Selfoss works like this
Type = Bug
Type = Chore
Type = Enhancement
Type = Feature
Type = Question
Type = SELFOSS API ISSUE
Type = Tools
Type = UX/Design
Up For Grabs
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Louvorg/ReaderForSelfoss-multiplatform#145
No description provided.
Delete Branch "davidoskky/ReaderForSelfoss-multiplatform:update_sources"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?