Fix recycleview article positions #163

davidoskky · 2024-11-19T01:00:03Z

davidoskky commented

2024-11-19 01:00:03 +00:00

The articles were being opened by setting a click listener on the binding.
In card view this was being done through a function and as such it used the overall viewbind of the recyclerview rather than the binding of the item viewholder. I'm not really sure as to why it previously worked and then stopped doing so.
Now the functions are more explicit to avoid future errors.
Pulled up a few members from ItemCardAdapter and ItemListAdapter to ItemAdapter.

Types of changes

[ x ] I have read the CONTRIBUTING document.
[ x ] My code follows the code style of this project.
I have updated the documentation accordingly.
I have added tests to cover my changes.
[ x ] All new and existing tests passed.
[ x ] This is NOT translation related.

This closes issue #162

The articles were being opened by setting a click listener on the binding. In card view this was being done through a function and as such it used the overall viewbind of the recyclerview rather than the binding of the item viewholder. I'm not really sure as to why it previously worked and then stopped doing so. Now the functions are more explicit to avoid future errors. Pulled up a few members from ItemCardAdapter and ItemListAdapter to ItemAdapter. ## Types of changes - [ x ] I have read the **CONTRIBUTING** document. - [ x ] My code follows the code style of this project. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [ x ] All new and existing tests passed. - [ x ] This is **NOT** translation related. This closes issue #162

davidoskky added 1 commit 2024-11-19 01:00:04 +00:00

Fix recycleview article positions 0bf9ca9a49

The articles were being opened by setting a click listener on the binding.
In card view this was being done through a function and as such it used the overall viewbind of the view rather than the binding of the item viewholder.
Now the functions are more explicit to avoid future errors.
Pulled up a few members from ItemCardAdapter and ItemListAdapter to ItemAdapter.

AmineB requested changes 2024-11-19 19:46:44 +00:00

Dismissed

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/HomeActivity.kt Outdated

						
				@ -663,4 +659,0 @@

				    private fun updateItems(adapterItems: ArrayList<SelfossModel.Item>) {

				        items = adapterItems

				    }

AmineB commented

2024-11-19 19:40:43 +00:00

This was needed so the HomeActivity have an updated items array. This should be added back here and in the adapters.

This was needed so the `HomeActivity` have an updated `items` array. This should be added back here and in the adapters.

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/ItemCardAdapter.kt

						
				@ -100,2 +84,2 @@

				            handleClickListeners(holder.bindingAdapterPosition)

				            handleLinkOpening(holder.bindingAdapterPosition)

				            handleClickListeners(binding, position)

				            openLink(binding, position)

AmineB commented

2024-11-19 19:45:02 +00:00

openLink function does not open the link. It should be renamed. I think that handleLinkOpening was pretty clear.

`openLink` function does not open the link. It should be renamed. I think that `handleLinkOpening` was pretty clear.

AmineB marked this conversation as resolved

androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/ItemsAdapter.kt

						
				@ -72,1 +78,4 @@

				    protected fun openLink(holderBinding: ViewBinding, position: Int) {

				        holderBinding.root.setOnClickListener {

				            Log.d(

AmineB commented

2024-11-19 19:45:59 +00:00

This log is not needed anymore

AmineB marked this conversation as resolved

davidoskky added 1 commit 2024-11-20 00:32:28 +00:00

Provide method to update items in the home 3a33cb4510

Removed in the previous commit, the item adapter accepts a method to update the articles list in the home page.
Renamed the method to make its objective more clear.
Removed a debugging log.
Reverted change to function name.

davidoskky commented

2024-11-20 00:35:15 +00:00

Sorry, I pushed a bit too quickly. I’ve reverted the changes and renamed updateItems in the adapter to updateHomeItems to make its purpose clearer.

Sorry, I pushed a bit too quickly. I’ve reverted the changes and renamed `updateItems` in the adapter to `updateHomeItems` to make its purpose clearer.

AmineB approved these changes 2024-11-20 08:31:26 +00:00

AmineB merged commit 62f58fbc00 into master

2024-11-20 08:31:34 +00:00

AmineB referenced this issue from a commit

2024-11-20 08:31:35 +00:00

Merge pull request 'Fix recycleview article positions' (#163) from davidoskky/ReaderForSelfoss-multiplatform:incorrectArticles into master

AmineB commented

2024-11-20 08:31:40 +00:00

Thanks !

AmineB referenced this issue from a commit

2024-11-20 08:32:34 +00:00

Fix recycleview article positions (#163)