Louvorg/ReaderForSelfoss-multiplatform
3
2
Fork 2
Code Issues 7 Pull Requests 2 Actions Releases 84 Wiki Activity

fix: Url validation was not failing login. Added tests. #186

Merged
AmineB merged 2 commits from fix-invalid-url into master 2025-03-09 16:54:19 +00:00
Conversation 0 Commits 2 Files Changed 19 +23 -54
AmineB commented 2025-03-09 13:43:14 +00:00
Owner
Copy Link

Fixes #184

Fixes #184
AmineB added 1 commit 2025-03-09 13:43:14 +00:00
fix: Url validation was not failing login. Added tests.
Some checks failed
Check PR code / Lint (pull_request) Successful in 2m36s
Details
Check PR code / build (pull_request) Has been cancelled
Details
03ea12000c
AmineB added 1 commit 2025-03-09 13:48:49 +00:00
chore: we don't need to check if the url is valid in upsert screen.
Some checks failed
Check PR code / Lint (pull_request) Failing after 1m39s
Details
Check PR code / build (pull_request) Has been skipped
Details
4a093fd969
AmineB force-pushed fix-invalid-url from 4a093fd969 to 590196bf91 2025-03-09 14:14:21 +00:00 Compare
AmineB force-pushed fix-invalid-url from 590196bf91 to 6eaad0c7c5 2025-03-09 15:24:48 +00:00 Compare
AmineB merged commit bb84d1541c into master 2025-03-09 16:54:19 +00:00
AmineB deleted branch fix-invalid-url 2025-03-09 16:54:19 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Difficulty - Beginner friendly
Difficulty = Easy
Difficulty = Hard
Difficulty = Medium
Priority = CRITICAL
Priority = High
Priority = Low
Priority = Normal
Priority = Some day
Status - Fixed somewhere else
Status - No details provided
Status = Can't fix
Status = Duplicate
Status = Help wanted
Status = Invalid
Status = Need more details
Status = Taken
Status = Wontfix
Type - Selfoss works like this
Type = Bug
Type = Chore
Type = Enhancement
Type = Feature
Type = Question
Type = SELFOSS API ISSUE
Type = Tools
Type = UX/Design
Up For Grabs
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
AmineB
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Louvorg/ReaderForSelfoss-multiplatform#186
Delete Branch "fix-invalid-url"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?