Implement logging in the android application #32

davidoskky · 2022-08-20T10:30:26Z

davidoskky commented

2022-08-20 10:30:26 +00:00

Types of changes

I have read the CONTRIBUTING document.
My code follows the code style of this project.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.
This is NOT translation related. (See here)

This is required to have the logging enabled in the android application

## Types of changes - [x] I have read the **CONTRIBUTING** document. - [x] My code follows the code style of this project. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [x] All new and existing tests passed. - [x] This is **NOT** translation related. (See [here](https://github.com/aminecmi/ReaderforSelfoss/pull/170#issuecomment-355715654)) This is required to have the logging enabled in the android application

davidoskky added 1 commit 2022-08-20 10:30:26 +00:00

Implement logging in the android application

continuous-integration/drone/pr Build is passing

Details

72d9ef92d2

AmineB commented

2022-08-20 10:44:50 +00:00

As I deleted the logging service I was using (because of GRPD) these options are not used anymore. Logging is only used when debugging.

davidoskky commented

2022-08-20 10:49:12 +00:00

This logging is local, this shouldn't be affected by GDPR, this is needed when debugging; we can also not insert this, but we'll have to add it in every time we debug.

Regarding GDPR, I think you should write somewhere that this app connects to your server for the mercury api, I'm not sure how it is regulated but I think you should declare it.

This logging is local, this shouldn't be affected by GDPR, this is needed when debugging; we can also not insert this, but we'll have to add it in every time we debug. Regarding GDPR, I think you should write somewhere that this app connects to your server for the mercury api, I'm not sure how it is regulated but I think you should declare it.

AmineB commented

2022-08-20 10:53:48 +00:00

This logging is local, this shouldn't be affected by GDPR, this is needed when debugging;

What does it add to the default logcat ?

we can also not insert this, but we'll have to add it in every time we debug.

We only add the logs where and when needed, so I don´t see the issue.

Regarding GDPR, I think you should write somewhere that this app connects to your server for the mercury api, I'm not sure how it is regulated but I think you should declare it.

This is only an api call that does not collect any data, so I don´t have to.

> This logging is local, this shouldn't be affected by GDPR, this is needed when debugging; What does it add to the default logcat ? > we can also not insert this, but we'll have to add it in every time we debug. We only add the logs where and when needed, so I don´t see the issue. > Regarding GDPR, I think you should write somewhere that this app connects to your server for the mercury api, I'm not sure how it is regulated but I think you should declare it. This is only an api call that does not collect any data, so I don´t have to.

davidoskky commented

2022-08-20 12:43:59 +00:00

What does it add to the default logcat ?

This allows logging using the Napier library which is required to log from commonMain. For example this line doesn't log anything if this piece of code is not included.
1392e2a571/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt (L271)

This is only an api call that does not collect any data, so I don´t have to.

I am not sure about this. Potentially you could be logging the request on your server, thus you could be keeping track of the articles one person is reading. I know nothing about GDPR, but I believe you should state somewhere wether you are actually keeping that data or not.

> What does it add to the default logcat ? This allows logging using the Napier library which is required to log from commonMain. For example this line doesn't log anything if this piece of code is not included. https://gitea.amine-louveau.fr/Louvorg/ReaderForSelfoss-multiplatform/src/commit/1392e2a571550e136419bad00a2f8dce225cb075/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt#L271 > This is only an api call that does not collect any data, so I don´t have to. I am not sure about this. Potentially you could be logging the request on your server, thus you could be keeping track of the articles one person is reading. I know nothing about GDPR, but I believe you should state somewhere wether you are actually keeping that data or not.

AmineB commented

2022-08-20 18:18:38 +00:00

This allows logging using the Napier library which is required to log from commonMain. For example this line doesn't log anything if this piece of code is not included.
1392e2a571/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt (L271)

Ok. I went to see what DebugAntilog did as it wasn't clear.

I'll merge it.

> This allows logging using the Napier library which is required to log from commonMain. For example this line doesn't log anything if this piece of code is not included. 1392e2a571/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt (L271) Ok. I went to see what `DebugAntilog` did as it wasn't clear. I'll merge it.

AmineB merged commit 112194dd4f into master

2022-08-20 18:18:48 +00:00

AmineB referenced this issue from a commit

2022-08-20 18:18:49 +00:00

Merge pull request 'Implement logging in the android application' (#32) from davidoskky/ReaderForSelfoss-multiplatform:logging into master

davidoskky deleted branch logging

2022-08-20 18:23:39 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Louvorg/ReaderForSelfoss-multiplatform#32