Implement logging in the android application #32
No reviewers
Labels
No Label
Difficulty - Beginner friendly
Difficulty = Easy
Difficulty = Hard
Difficulty = Medium
Priority = CRITICAL
Priority = High
Priority = Low
Priority = Normal
Priority = Some day
Status - Fixed somewhere else
Status - No details provided
Status = Can't fix
Status = Duplicate
Status = Help wanted
Status = Invalid
Status = Need more details
Status = Taken
Status = Wontfix
Type - Selfoss works like this
Type = Bug
Type = Chore
Type = Enhancement
Type = Feature
Type = Question
Type = SELFOSS API ISSUE
Type = Tools
Type = UX/Design
Up For Grabs
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Louvorg/ReaderForSelfoss-multiplatform#32
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "davidoskky/ReaderForSelfoss-multiplatform:logging"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Types of changes
This is required to have the logging enabled in the android application
As I deleted the logging service I was using (because of GRPD) these options are not used anymore. Logging is only used when debugging.
This logging is local, this shouldn't be affected by GDPR, this is needed when debugging; we can also not insert this, but we'll have to add it in every time we debug.
Regarding GDPR, I think you should write somewhere that this app connects to your server for the mercury api, I'm not sure how it is regulated but I think you should declare it.
What does it add to the default logcat ?
We only add the logs where and when needed, so I don´t see the issue.
This is only an api call that does not collect any data, so I don´t have to.
This allows logging using the Napier library which is required to log from commonMain. For example this line doesn't log anything if this piece of code is not included.
1392e2a571/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt (L271)
I am not sure about this. Potentially you could be logging the request on your server, thus you could be keeping track of the articles one person is reading. I know nothing about GDPR, but I believe you should state somewhere wether you are actually keeping that data or not.
Ok. I went to see what
DebugAntilog
did as it wasn't clear.I'll merge it.