Louvorg/ReaderForSelfoss-multiplatform
Louvorg/ReaderForSelfoss-multiplatform
3
2
Fork 2
Code Issues 16 Pull Requests Actions Projects 1 Releases 68 Wiki Activity

Correct mechanism of mark and unmark snackbars #74

Merged
AmineB merged 2 commits from davidoskky/ReaderForSelfoss-multiplatform:snackbar-mark into master 2022-10-04 18:43:45 +00:00
Conversation 0 Commits 2 Files Changed 1 +13 -14
davidoskky commented 2022-10-04 14:45:26 +00:00
Contributor
Copy Link

The item to be passed to the repository for marking/unmarking was being deleted from the list before it could be accessed.
Now, an instance of the item is passed to the snackbar in order to avoid these kinds of problems.

Together with #73 this should fix #72.

The item to be passed to the repository for marking/unmarking was being deleted from the list before it could be accessed. Now, an instance of the item is passed to the snackbar in order to avoid these kinds of problems. Together with #73 this should fix #72.
davidoskky added 1 commit 2022-10-04 14:45:26 +00:00
Correct mechanism of mark and unmark snackbars
Some checks are pending
continuous-integration/drone/pr Build is running
Details
a147646743
davidoskky added 1 commit 2022-10-04 14:47:18 +00:00
Avoid double snackbar generation
All checks were successful
continuous-integration/drone/pr Build is passing
Details
1d2e5069b8
AmineB merged commit a2862a2587 into master 2022-10-04 18:43:45 +00:00
davidoskky deleted branch snackbar-mark 2022-10-04 18:56:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Difficulty - Beginner friendly

   
Difficulty = Easy

   
Difficulty = Hard

   
Difficulty = Medium

   
Priority = CRITICAL

   
Priority = High

   
Priority = Low

   
Priority = Normal

   
Priority = Some day

   
Status - Fixed somewhere else

   
Status - No details provided

   
Status = Can't fix

   
Status = Duplicate

   
Status = Help wanted

   
Status = Invalid

   
Status = Need more details

   
Status = Taken

   
Status = Wontfix

   
Type - Selfoss works like this

   
Type = Bug

   
Type = Chore

   
Type = Enhancement

   
Type = Feature

   
Type = Question

   
Type = SELFOSS API ISSUE

   
Type = Tools

   
Type = UX/Design

   
Up For Grabs
No Label
Difficulty - Beginner friendly
Difficulty = Easy
Difficulty = Hard
Difficulty = Medium
Priority = CRITICAL
Priority = High
Priority = Low
Priority = Normal
Priority = Some day
Status - Fixed somewhere else
Status - No details provided
Status = Can't fix
Status = Duplicate
Status = Help wanted
Status = Invalid
Status = Need more details
Status = Taken
Status = Wontfix
Type - Selfoss works like this
Type = Bug
Type = Chore
Type = Enhancement
Type = Feature
Type = Question
Type = SELFOSS API ISSUE
Type = Tools
Type = UX/Design
Up For Grabs
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Louvorg/ReaderForSelfoss-multiplatform#74
No description provided.
Delete Branch "davidoskky/ReaderForSelfoss-multiplatform:snackbar-mark"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?