Louvorg/ReaderForSelfoss-multiplatform
3
2
Fork 2
Code Issues 7 Pull Requests 2 Actions Releases 84 Wiki Activity

Prevent crash when logging in #81

Merged
AmineB merged 3 commits from davidoskky/ReaderForSelfoss-multiplatform:login_crash into master 2022-10-22 19:54:01 +00:00
Conversation 1 Commits 3 Files Changed 3
+6 -4
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit c25e8889a4 - Show all commits
shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt
+6 -4
View File
@@ -43,10 +43,11 @@ class Repository(private val api: SelfossApi, private val appSettingsService: Ap
init {
// TODO: Dispatchers.IO not available in KMM, an alternative solution should be found
connectivityStatus.start()
runBlocking {
updateApiVersion()
dateUtils = DateUtils(appSettingsService)
reloadBadges()
if (appSettingsService.getBaseUrl() != "") {
AmineB marked this conversation as resolved Outdated
AmineB commented 2022-10-17 17:44:17 +00:00
Outdated
Review
Copy Link
Copy Source

getBaseUrl should never return an empty string.

There is a verification done before even logging-in (and saving the settings), so this should never happen.

`getBaseUrl` should never return an empty string. There is a verification done before even logging-in (and saving the settings), so this should never happen.
davidoskky commented 2022-10-17 18:26:33 +00:00
Outdated
Review
Copy Link
Copy Source

The repository is initialized before logging in, at that point appSettingsService returns an empty string

The repository is initialized before logging in, at that point appSettingsService returns an empty string
AmineB commented 2022-10-17 18:56:14 +00:00
Outdated
Review
Copy Link
Copy Source

Ok, so this is a workaround.

The issue is that the runBlocking block is called even when the user is'nt updated. This should be fixed.

Ok, so this is a workaround. The issue is that the `runBlocking` block is called even when the user is'nt updated. This should be fixed.
davidoskky commented 2022-10-18 11:14:38 +00:00
Outdated
Review
Copy Link
Copy Source

I could remove this from the init method and make a new public method which is called by the login activity after it checks that the user is correctly set.

I could remove this from the init method and make a new public method which is called by the login activity after it checks that the user is correctly set.
AmineB commented 2022-10-18 12:06:55 +00:00
Outdated
Review
Copy Link
Copy Source

that could be better, yes !

that could be better, yes !
runBlocking {
updateApiVersion()
reloadBadges()
}
}
}
@@ -408,6 +409,7 @@ class Repository(private val api: SelfossApi, private val appSettingsService: Ap
appSettingsService.updateApiVersion(fetchedVersion.data.getApiMajorVersion())
}
}
dateUtils = DateUtils(appSettingsService)
AmineB marked this conversation as resolved Outdated
AmineB commented 2022-10-17 17:44:34 +00:00
Outdated
Review
Copy Link
Copy Source

why was this added ?

why was this added ?
davidoskky commented 2022-10-17 18:27:16 +00:00
Outdated
Review
Copy Link
Copy Source

If the repository is initialized before the login, this is required to initialize the dateUtils after logging in

If the repository is initialized before the login, this is required to initialize the dateUtils after logging in
}
fun isNetworkAvailable() = isConnectionAvailable.value && !offlineOverride