Louvorg/ReaderForSelfoss-multiplatform
Louvorg/ReaderForSelfoss-multiplatform
3
2
Fork 2
Code Issues 18 Pull Requests Actions Projects 1 Releases 65 Wiki Activity

Show all sources in the sources list #90

Merged
AmineB merged 2 commits from davidoskky/ReaderForSelfoss-multiplatform:sources into master 2022-11-01 20:30:31 +00:00
Conversation 0 Commits 2 Files Changed 2 -7
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 792950be7c - Show all commits

7
androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/SourcesActivity.kt
View File

@ -63,13 +63,6 @@ class SourcesActivity : AppCompatActivity(), DIAware {
)
binding.recyclerView.adapter = mAdapter
mAdapter.notifyDataSetChanged()
if (items.isEmpty()) {
AmineB marked this conversation as resolved
AmineB commented 2022-11-01 19:15:07 +00:00
Review
Copy Link

Why was this deleted ?

Why was this deleted ?
davidoskky commented 2022-11-01 19:29:14 +00:00
Review
Copy Link

This is unrelated to the issue, I just removed it since I stumbled upon it while finding a solution.

Just above:

if (response.isNotEmpty()) {
	items = response

It is thus redundant to print a message if no source is present since we already checked for that and handled it above.

This is unrelated to the issue, I just removed it since I stumbled upon it while finding a solution. Just above: ``` if (response.isNotEmpty()) { items = response ``` It is thus redundant to print a message if no source is present since we already checked for that and handled it above.
Toast.makeText(
this@SourcesActivity,
R.string.nothing_here,
Toast.LENGTH_SHORT
).show()
}
} else {
Toast.makeText(
this@SourcesActivity,