Louvorg/ReaderForSelfoss-multiplatform
Louvorg/ReaderForSelfoss-multiplatform
3
2
Fork 2
Code Issues 18 Pull Requests Actions Projects 1 Releases 65 Wiki Activity

Show all sources in the sources list #90

Merged
AmineB merged 2 commits from davidoskky/ReaderForSelfoss-multiplatform:sources into master 2022-11-01 20:30:31 +00:00
Conversation 0 Commits 2 Files Changed 2 +9 -12
2 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/SourcesActivity.kt
View File

@ -63,13 +63,6 @@ class SourcesActivity : AppCompatActivity(), DIAware {
)
binding.recyclerView.adapter = mAdapter
mAdapter.notifyDataSetChanged()
if (items.isEmpty()) {
AmineB marked this conversation as resolved
AmineB commented 2022-11-01 19:15:07 +00:00
Review
Copy Link

Why was this deleted ?

Why was this deleted ?
davidoskky commented 2022-11-01 19:29:14 +00:00
Review
Copy Link

This is unrelated to the issue, I just removed it since I stumbled upon it while finding a solution.

Just above:

if (response.isNotEmpty()) {
	items = response

It is thus redundant to print a message if no source is present since we already checked for that and handled it above.

This is unrelated to the issue, I just removed it since I stumbled upon it while finding a solution. Just above: ``` if (response.isNotEmpty()) { items = response ``` It is thus redundant to print a message if no source is present since we already checked for that and handled it above.
Toast.makeText(
this@SourcesActivity,
R.string.nothing_here,
Toast.LENGTH_SHORT
).show()
}
} else {
Toast.makeText(
this@SourcesActivity,

14
androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/SourcesListAdapter.kt
View File

@ -61,9 +61,13 @@ class SourcesListAdapter(
binding.sourceTitle.text = itm.title.getHtmlDecoded()
}
override fun getItemId(position: Int) = position.toLong()
AmineB commented 2022-11-01 19:19:57 +00:00
Review
Copy Link

Are these two changes really needed ?

Are these two changes really needed ?
davidoskky commented 2022-11-01 19:30:13 +00:00
Review
Copy Link

Yes, these are the changes that actually solve the problem.
The position keeps getting reset otherwise and that was why we would get a repeating list.

Yes, these are the changes that actually solve the problem. The position keeps getting reset otherwise and that was why we would get a repeating list.
override fun getItemViewType(position: Int) = position
override fun getItemCount(): Int = items.size
inner class ViewHolder(internal val mView: ConstraintLayout) : RecyclerView.ViewHolder(mView) {
inner class ViewHolder(private val mView: ConstraintLayout) : RecyclerView.ViewHolder(mView) {
init {
handleClickListeners()
@ -74,13 +78,13 @@ class SourcesListAdapter(
val deleteBtn: Button = mView.findViewById(R.id.deleteBtn)
deleteBtn.setOnClickListener {
val (id) = items[adapterPosition]
val (id) = items[bindingAdapterPosition]
CoroutineScope(Dispatchers.IO).launch {
val successfullyDeletedSource = repository.deleteSource(id)
if (successfullyDeletedSource) {
items.removeAt(adapterPosition)
notifyItemRemoved(adapterPosition)
notifyItemRangeChanged(adapterPosition, itemCount)
items.removeAt(bindingAdapterPosition)
notifyItemRemoved(bindingAdapterPosition)
notifyItemRangeChanged(bindingAdapterPosition, itemCount)
} else {
Toast.makeText(
app,