Immediately update bottom badges after reading or starring articles #91

davidoskky · 2022-11-01T20:35:00Z

davidoskky commented

2022-11-01 20:35:00 +00:00

Types of changes

I have read the CONTRIBUTING document.
My code follows the code style of this project.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.
This is NOT translation related.

This closes issue #83

While working on this I realized that the repository items are directly passed to the other activities which can edit its content.
This is problematic, as in this case for example the recyclerview adapter was marking the articles as starred before the repository could do it, and as such preventing the correct handling of the process.

## Types of changes - [x] I have read the **CONTRIBUTING** document. - [x] My code follows the code style of this project. - [ ] I have updated the documentation accordingly. - [x] I have added tests to cover my changes. - [x] All new and existing tests passed. - [x] This is **NOT** translation related. This closes issue #83 While working on this I realized that the repository items are directly passed to the other activities which can edit its content. This is problematic, as in this case for example the recyclerview adapter was marking the articles as starred before the repository could do it, and as such preventing the correct handling of the process.

davidoskky added 2 commits 2022-11-01 20:35:01 +00:00

Update bottom bar badges through a state flow c5cdfc0d53

Do not edit the repository items from outside the repository

continuous-integration/drone/pr Build is running

Details

02d734eee8

davidoskky added 1 commit 2022-11-01 20:35:18 +00:00

Merge branch 'master' into badges

continuous-integration/drone/pr Build is failing

Details

ac4c4b9441

AmineL approved these changes 2022-11-01 20:45:44 +00:00

davidoskky commented

2022-11-01 20:47:17 +00:00

Wait merging, I have to update the tests

AmineL changed title from ~~Immediately update bottom badges after reading or starring articles~~ to WIP: Immediately update bottom badges after reading or starring articles

2022-11-01 20:48:07 +00:00

davidoskky added 1 commit 2022-11-01 20:51:56 +00:00

Update badges tests

continuous-integration/drone/pr Build is passing

Details

4b63afe62a

davidoskky changed title from ~~WIP: Immediately update bottom badges after reading or starring articles~~ to Immediately update bottom badges after reading or starring articles

2022-11-01 20:52:34 +00:00

davidoskky requested review from AmineL 2022-11-01 20:52:48 +00:00

AmineL approved these changes 2022-11-02 19:06:44 +00:00

AmineL merged commit a464e93370 into master

2022-11-02 19:06:48 +00:00

AmineL referenced this issue from a commit

2022-11-02 19:06:49 +00:00

Merge pull request 'Immediately update bottom badges after reading or starring articles' (#91) from davidoskky/ReaderForSelfoss-multiplatform:badges into master

davidoskky deleted branch badges

2022-11-03 10:08:31 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Louvorg/ReaderForSelfoss-multiplatform#91