Set date format according to api version.

app/src/main/java/apps/amine/bou/readerforselfoss/HomeActivity.kt

@@ -92,6 +92,7 @@ class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener {
     private var displayUnreadCount = false
     private var displayAllCount = false
     private var fullHeightCards: Boolean = false
+    private var apiVersionMajor: Int = 0
     private var itemsNumber: Int = 200
     private var elementsShown: Int = 0
     private var maybeTagFilter: Tag? = null
@@ -104,11 +105,11 @@ class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener {
     private var itemsCaching: Boolean = false
     private var updateSources: Boolean = true
     private var hiddenTags: List<String> = emptyList()
-    private var apiVersionMajor: Int = 0
 
     private var periodicRefresh = false
     private var refreshMinutes: Long = 360L
     private var refreshWhenChargingOnly = false
+    private var dateTimeFormatter = "yyyy-MM-dd HH:mm:ss"
 
     private lateinit var tabNewBadge: TextBadgeItem
     private lateinit var tabArchiveBadge: TextBadgeItem
@@ -197,6 +198,10 @@ class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener {
 
         getApiMajorVersion()
 
+        if (apiVersionMajor > 2) {
+            dateTimeFormatter = "yyyy-MM-dd'T'HH:mm:ssXXX"
+        }
+
         getElementsAccordingToTab()
     }
 
@@ -332,28 +337,6 @@ class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener {
         }
     }
 
-    private fun getApiMajorVersion() {
-        api.apiVersion.enqueue(object : Callback<ApiVersion> {
-            override fun onFailure(call: Call<ApiVersion>, t: Throwable) {
-                if (apiVersionMajor >= 4) {
-                    Config.dateTimeFormatter = "yyyy-MM-dd'T'HH:mm:ssXXX"
-                }
-            }
-
-            override fun onResponse(call: Call<ApiVersion>, response: Response<ApiVersion>) {
-                if(response.body() != null) {
-                    val version = response.body() as ApiVersion
-                    apiVersionMajor = version.getApiMajorVersion()
-                    sharedPref.edit().putInt("apiVersionMajor", apiVersionMajor).commit()
-
-                    if (apiVersionMajor >= 4) {
-                        Config.dateTimeFormatter = "yyyy-MM-dd'T'HH:mm:ssXXX"
-                    }
-                }
-            }
-        })
-    }
-
     override fun onResume() {
         super.onResume()
 
@@ -436,6 +419,19 @@ class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener {
         }
     }
 
+    private fun getApiMajorVersion() {
+        api.apiVersion.enqueue(object : Callback<ApiVersion> {
+            override fun onFailure(call: Call<ApiVersion>, t: Throwable) {
+            }
+
+            override fun onResponse(call: Call<ApiVersion>, response: Response<ApiVersion>) {
+                val version = response.body() as ApiVersion
+                apiVersionMajor = version.getApiMajorVersion()
+            }
+        })
+
+    }
+
     override fun onStop() {
         super.onStop()
         customTabActivityHelper.unbindCustomTabsService(this)
@@ -466,8 +462,6 @@ class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener {
         if (refreshMinutes <= 15) {
             refreshMinutes = 15
         }
-
-        apiVersionMajor = sharedPref.getInt("apiVersionMajor", 0)
     }
 
     private fun handleThemeBinding() {
@@ -932,7 +926,7 @@ class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener {
 
                     thread {
                         val dbItems = db.itemsDao().items().map { it.toView() }.sortedByDescending {
-                            SimpleDateFormat(Config.dateTimeFormatter).parse(it.datetime)
+                            SimpleDateFormat(dateTimeFormatter).parse(it.datetime)
                         }
                         runOnUiThread {
                             if (dbItems.isNotEmpty()) {
@@ -1036,7 +1030,7 @@ class HomeActivity : AppCompatActivity(), SearchView.OnQueryTextListener {
 
             thread {
                 val dbItems = db.itemsDao().items().map { it.toView() }.sortedByDescending {
-                    SimpleDateFormat(Config.dateTimeFormatter).parse(it.datetime)
+                    SimpleDateFormat(dateTimeFormatter).parse(it.datetime)
                 }
                 runOnUiThread {
                     if (dbItems.isNotEmpty()) {

app/src/main/java/apps/amine/bou/readerforselfoss/api/selfoss/SelfossModels.kt

@@ -49,8 +49,8 @@ data class Spout(
 )
 
 data class ApiVersion(
-        @SerializedName("version") val version: String?,
-        @SerializedName("apiversion") val apiversion: String?
+        @SerializedName("version") val version: String,
+        @SerializedName("apiversion") val apiversion: String
 ) {
     fun getApiMajorVersion() : Int {
         var versionNumber = 0

app/src/main/java/apps/amine/bou/readerforselfoss/utils/Config.kt

@@ -40,8 +40,6 @@ class Config(c: Context) {
 
         const val newItemsChannelId = "new-items-channel-id"
 
-        var dateTimeFormatter = "yyyy-MM-dd HH:mm:ss"
-
         fun logoutAndRedirect(
             c: Context,
             callingActivity: Activity,

app/src/main/java/apps/amine/bou/readerforselfoss/utils/ItemsUtils.kt

@@ -22,7 +22,7 @@ fun String.toTextDrawableString(c: Context): String {
 fun Item.sourceAndDateText(): String {
     val formattedDate: String = try {
         " " + DateUtils.getRelativeTimeSpanString(
-            SimpleDateFormat(Config.dateTimeFormatter).parse(this.datetime).time,
+            SimpleDateFormat("yyyy-MM-dd HH:mm:ss").parse(this.datetime).time,
             Date().time,
             DateUtils.MINUTE_IN_MILLIS,
             DateUtils.FORMAT_ABBREV_RELATIVE