Amine Bouabdallaoui AmineB
0 Followers · 0 Following
Repositories
18
 Projects Packages Public Activity Starred Repositories
AmineB merged pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-30 11:31:55 +00:00
Repository Unit Tests
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2022-09-30 11:31:55 +00:00
6ec3e96909 Merge pull request 'Repository Unit Tests' (#50) from davidoskky/ReaderForSelfoss-multiplatform:repository_tests into master
22da30eaa8 Remove unnecessary call to api
79fd115f5e Only return new cached items
8dc3d319cd Cleanup
27bb056397 Cleanup
Compare 39 commits »
AmineB pushed to main at AmineB/cv-api 2022-09-30 10:21:16 +00:00
0e1d0ca588 Initial commit.
AmineB created repository AmineB/cv-api 2022-09-30 10:20:04 +00:00
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-30 10:00:10 +00:00
Repository Unit Tests

As the function name describes, this must only return the new items.

AmineB suggested changes for Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-30 10:00:10 +00:00
Repository Unit Tests
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-30 09:59:38 +00:00
Repository Unit Tests

Yes. Could you add a comment in the home activity, the refactoring will be done later.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-30 09:48:57 +00:00
Repository Unit Tests

If it's not used elsewere, please remove the todo, and change the function to private.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-30 09:48:57 +00:00
Repository Unit Tests

I think that the DB handles the duplicates.

AmineB suggested changes for Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-30 09:48:57 +00:00
Repository Unit Tests
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-30 09:43:38 +00:00
Repository Unit Tests

This is useless.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-30 09:43:38 +00:00
Repository Unit Tests

Because of the mercury api using this, can you remove this comment, please ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-30 09:43:38 +00:00
Repository Unit Tests

Please remove this comment.

AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2022-09-29 13:34:15 +00:00
381d6acc82 Analyzing should be with the rest.
AmineB pushed to main at AmineB/cv 2022-09-29 13:21:08 +00:00
d7dcbb0ea8 Drone setup.
AmineB pushed to main at AmineB/cv 2022-09-29 13:12:11 +00:00
9245d33515 Drone setup.
AmineB pushed to main at AmineB/cv 2022-09-29 13:09:20 +00:00
695746a507 Drone setup.
0d90e4c166 Fix.
ebed0c208c Things will build.
42b7167eec Final style.
5f1b0016f2 Initialize project using Create React App
Compare 5 commits »
AmineB created repository AmineB/cv 2022-09-29 12:50:19 +00:00
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-28 06:57:14 +00:00
Repository Unit Tests

I guess the repository should raise an exception during initialization then.

Yep. That should be the case.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-28 06:48:18 +00:00
Repository Unit Tests

@davidoskky can you also please rebase your work on master, please ?