Amine Bouabdallaoui AmineB
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 18:29:28 +00:00
Repository Unit Tests

The way I understand your comment is that sometimes, the repository can fail an throw an error.

This should not be handled in a unit test, but handled in the code.

The exception should be…

AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2022-09-27 14:57:16 +00:00
ad279c6683 Translation.
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2022-09-27 14:55:00 +00:00
5f0817ddb7 Formating issue.
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2022-09-27 14:53:21 +00:00
7124cbcacd Fixed issue with drone failing silently.
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2022-09-27 14:50:09 +00:00
2a710a1a08 Translations.
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2022-09-27 14:37:24 +00:00
82ec2445a1 Merge pull request 'chore/theme-cleaning' (#69) from chore/theme-cleaning into master
cabb6d494d Cleaning.
5c12481813 Article viewer theming.
b16f86dda1 All theme issues should be resolved.
2bc28db2cc Removed chrome custom tabs.
Compare 6 commits »
AmineB deleted branch chore/theme-cleaning from Louvorg/ReaderForSelfoss-multiplatform 2022-09-27 14:37:24 +00:00
AmineB merged pull request Louvorg/ReaderForSelfoss-multiplatform#69 2022-09-27 14:37:23 +00:00
chore/theme-cleaning
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 14:32:18 +00:00
Repository Unit Tests

Be cause of the line 40 of the setup function you have an unread/starred item in your DB.

AmineB suggested changes for Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 14:32:18 +00:00
Repository Unit Tests
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 14:32:18 +00:00
Repository Unit Tests

The network is available, so this will be called. And the next one won't.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 14:32:18 +00:00
Repository Unit Tests

In reloadBadges(), there is a missing success = true in the else statement.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 14:21:20 +00:00
Repository Unit Tests

Same here, the two values are different in the initialization, they couldn't be the same after.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 14:21:20 +00:00
Repository Unit Tests

I don't understand what you wanted to test here. The network is available, so the two will be the same.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 14:14:33 +00:00
Repository Unit Tests

This does not seem to do anything. Is it needed ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 14:14:33 +00:00
Repository Unit Tests

Tags and sources caching is handled via the update_sources setting.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 14:14:33 +00:00
Repository Unit Tests

Returning null isn't possible, so it should be an empty list.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 14:14:33 +00:00
Repository Unit Tests

this should be assertEquals(emptyList(), testTags)

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 14:14:33 +00:00
Repository Unit Tests

The same comments about Get tags without connection and items caching disabled should be considered here.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 14:14:33 +00:00
Repository Unit Tests

Be cause of the line 40 of the setup function you have an unread/starred item in your DB.