- France
- https://amine-bouabdallaoui.fr
- Joined on
2022-07-18
There are still multiple failing tests.
Why is this called twice ?
Same for all the other try catch in here.
Same for all the other try catch in here.
Still, db cleaning should be done on setting change.
Ok.
So getMaxItemsForBackground should be changed, then.
Alright, so I should verify that the call to the api is performed only once, regardless of how many times this function is called and that tags and sources are correctly stored in the db.
Yep,…
If one of those nulls is substituted by another value, it will not be the last 200 articles that will be stored, but 200 articles filtered according to some external factor.
Well, this is…
I don't think sources and tags should be cached if items are not cached; what would be the use of such a function?
As mentionnend by you in a previous comment, it is used to limit the…
I find it useless to test if caching is enabled to check if there is something in the DB.
I am confused, as far as I remember update_sources was introduced to limit the amount of api calls to selfoss because that was heavy on the database and created some problems. That is also how…
The setting name IS confusing. But but it handles the tags/sources caching.
The network is available. The api call will be done. update_sources handles the tags/sources caching.
The network is available. The api call will be done. update_sources handles the tags/sources caching.
As above.
I don't know what you wanted to test.
The thing is, passing null, null, null, null in the function will make it fail, because in your calls, you pass data.
I don't know what you wanted to test.
The thing is, passing null, null, null, null in the function will make it fail, because in your calls, you pass data.
Because it's handled separatly, so users can cache the sources/tags without caching anything else.
Since items caching is disabled I would expect the function not to access items in the database.
I answerd this in another comment.
The DB should be empty when the setting is disabled, so…