Amine Bouabdallaoui AmineB
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 14:14:33 +00:00
Repository Unit Tests

This does not seem to do anything. Is it needed ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 14:14:33 +00:00
Repository Unit Tests

This should be coVerify(exactly = 3) { api.getItems(any(), 0, "Tag", 1, "search", null, 200) }

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 14:14:33 +00:00
Repository Unit Tests

This will be called once.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 14:14:33 +00:00
Repository Unit Tests

This does not seem to do anything. Is it needed ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 14:14:33 +00:00
Repository Unit Tests

Update remote should be changed to.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 14:14:33 +00:00
Repository Unit Tests

This should be changed to coVerify(exactly = 3) { api.getItems(any(), 0, "Tag", 1, "search", null, 200) }

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 14:14:33 +00:00
Repository Unit Tests

tryToCacheItemsAndGetNewOnes will only return 1 item as it only returns new items.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 13:35:22 +00:00
Repository Unit Tests

Returning null isn't possible, so it should be an empty list.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 13:18:56 +00:00
Repository Unit Tests

Wouldn't it be better if SelfossApi.spouts() returned a List rather than a Map? It would simplify the logic and conform with other api functions.

This is the return format of the api.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 13:15:21 +00:00
Repository Unit Tests

This is a simple api call to fetch the artcile content. There is no need to put it inside the repository. It is only used here.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#50 2022-09-27 13:15:21 +00:00
Repository Unit Tests

What does this change do ?

AmineB closed issue Louvorg/ReaderForSelfoss-multiplatform#66 2022-09-27 13:10:25 +00:00
Theming V1 (Dark Mode only)
AmineB created pull request Louvorg/ReaderForSelfoss-multiplatform#69 2022-09-27 13:10:02 +00:00
chore/theme-cleaning
AmineB pushed to chore/theme-cleaning at Louvorg/ReaderForSelfoss-multiplatform 2022-09-27 13:09:36 +00:00
cabb6d494d Cleaning.
AmineB pushed to chore/theme-cleaning at Louvorg/ReaderForSelfoss-multiplatform 2022-09-27 10:36:05 +00:00
5c12481813 Article viewer theming.
AmineB pushed to chore/theme-cleaning at Louvorg/ReaderForSelfoss-multiplatform 2022-09-27 10:03:05 +00:00
b16f86dda1 All theme issues should be resolved.
2bc28db2cc Removed chrome custom tabs.
Compare 2 commits »
AmineB created branch chore/theme-cleaning in Louvorg/ReaderForSelfoss-multiplatform 2022-09-27 08:21:46 +00:00
AmineB pushed to chore/theme-cleaning at Louvorg/ReaderForSelfoss-multiplatform 2022-09-27 08:21:46 +00:00
bf1b680b4a Daark theme working.
AmineB closed issue Louvorg/ReaderForSelfoss-multiplatform#63 2022-09-26 18:26:52 +00:00
Too may api calls at startup
AmineB deleted branch enhancement/too-many-calls from Louvorg/ReaderForSelfoss-multiplatform 2022-09-26 18:26:29 +00:00