Compare commits

..

1 Commits

Author SHA1 Message Date
dcea40162c Show a confirmation dialog before deleting sources (#185)
Some checks failed
Check PR code / translations (pull_request) Failing after 1m5s
## Types of changes

- [ x ] I have read the **CONTRIBUTING** document.
- [ x ] My code follows the code style of this project.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [ x ] All new and existing tests passed.
- [ x ] This is **NOT** translation related.

This is implements feature #156

I added a confirmation dialogue which pops up after tapping the delete source button. The popup displays the full name of the source to be deleted and allows the user to decide not to delete the source to prevent erroneous deletions.

I moved most of the logic into the viewholder. Can be easily reverted if you prefer.

All tests pass. I tested correct behavior in emulated versions of android API 25, 34 and 35.

Co-authored-by: Amine <amine.bouabdallaoui@pm.me>
Reviewed-on: #185
Co-authored-by: davidoskky <davidoskky@yahoo.it>
Co-committed-by: davidoskky <davidoskky@yahoo.it>
2025-03-09 16:14:36 +01:00
16 changed files with 0 additions and 16 deletions

View File

@ -131,5 +131,4 @@
<string name="marked_as_unread">"Item unread"</string>
<string name="confirm_delete_title">Confirm Deletion</string>
<string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
<string name="test_only_delete_late">Tototta</string>
</resources>

View File

@ -131,5 +131,4 @@
<string name="marked_as_unread">"Item unread"</string>
<string name="confirm_delete_title">Confirm Deletion</string>
<string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
<string name="test_only_delete_late">Tototta</string>
</resources>

View File

@ -131,5 +131,4 @@
<string name="marked_as_unread">"Artículo no leído"</string>
<string name="confirm_delete_title">Confirm Deletion</string>
<string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
<string name="test_only_delete_late">Tototta</string>
</resources>

View File

@ -131,5 +131,4 @@
<string name="marked_as_unread">"Marqué comme non lu"</string>
<string name="confirm_delete_title">Confirm Deletion</string>
<string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
<string name="test_only_delete_late">Tototta</string>
</resources>

View File

@ -131,5 +131,4 @@
<string name="marked_as_unread">"Elemento non lido"</string>
<string name="confirm_delete_title">Confirm Deletion</string>
<string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
<string name="test_only_delete_late">Tototta</string>
</resources>

View File

@ -131,5 +131,4 @@
<string name="marked_as_unread">"Item unread"</string>
<string name="confirm_delete_title">Confirm Deletion</string>
<string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
<string name="test_only_delete_late">Tototta</string>
</resources>

View File

@ -131,5 +131,4 @@
<string name="marked_as_unread">"Item unread"</string>
<string name="confirm_delete_title">Confirm Deletion</string>
<string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
<string name="test_only_delete_late">Tototta</string>
</resources>

View File

@ -131,5 +131,4 @@
<string name="marked_as_unread">"Item unread"</string>
<string name="confirm_delete_title">Confirm Deletion</string>
<string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
<string name="test_only_delete_late">Tototta</string>
</resources>

View File

@ -131,5 +131,4 @@
<string name="marked_as_unread">"Item unread"</string>
<string name="confirm_delete_title">Confirm Deletion</string>
<string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
<string name="test_only_delete_late">Tototta</string>
</resources>

View File

@ -131,5 +131,4 @@
<string name="marked_as_unread">"Item unread"</string>
<string name="confirm_delete_title">Confirm Deletion</string>
<string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
<string name="test_only_delete_late">Tototta</string>
</resources>

View File

@ -131,5 +131,4 @@
<string name="marked_as_unread">"Item unread"</string>
<string name="confirm_delete_title">Confirm Deletion</string>
<string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
<string name="test_only_delete_late">Tototta</string>
</resources>

View File

@ -131,5 +131,4 @@
<string name="marked_as_unread">"Item unread"</string>
<string name="confirm_delete_title">Confirm Deletion</string>
<string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
<string name="test_only_delete_late">Tototta</string>
</resources>

View File

@ -131,5 +131,4 @@
<string name="marked_as_unread">"Item unread"</string>
<string name="confirm_delete_title">Confirm Deletion</string>
<string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
<string name="test_only_delete_late">Tototta</string>
</resources>

View File

@ -131,5 +131,4 @@
<string name="marked_as_unread">"未读条目"</string>
<string name="confirm_delete_title">Confirm Deletion</string>
<string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
<string name="test_only_delete_late">Tototta</string>
</resources>

View File

@ -131,5 +131,4 @@
<string name="marked_as_unread">"未讀項目"</string>
<string name="confirm_delete_title">Confirm Deletion</string>
<string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
<string name="test_only_delete_late">Tototta</string>
</resources>

View File

@ -133,5 +133,4 @@
<string name="marked_as_unread">"Item unread"</string>
<string name="confirm_delete_title">Confirm Deletion</string>
<string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
<string name="test_only_delete_late">Tototta</string>
</resources>