ReaderForSelfoss-multiplatform

Louvorg/ReaderForSelfoss-multiplatform

Fork 2

Author	SHA1	Message	Date
Amine	13066bdf2d	chore: crowding ci integration. Some checks failed Check PR code / translations (pull_request) Failing after 59s Details	2025-03-09 16:15:55 +01:00
davidoskky	a1c0241a58	Show a confirmation dialog before deleting sources (#185 ) All checks were successful Check master code / build (push) Successful in 15m3s Details ## Types of changes - [ x ] I have read the CONTRIBUTING document. - [ x ] My code follows the code style of this project. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [ x ] All new and existing tests passed. - [ x ] This is NOT translation related. This is implements feature #156 I added a confirmation dialogue which pops up after tapping the delete source button. The popup displays the full name of the source to be deleted and allows the user to decide not to delete the source to prevent erroneous deletions. I moved most of the logic into the viewholder. Can be easily reverted if you prefer. All tests pass. I tested correct behavior in emulated versions of android API 25, 34 and 35. Co-authored-by: Amine <amine.bouabdallaoui@pm.me> Reviewed-on: #185 Co-authored-by: davidoskky <davidoskky@yahoo.it> Co-committed-by: davidoskky <davidoskky@yahoo.it>	2025-03-09 13:49:32 +00:00

Author

SHA1

Message

Date

Amine

13066bdf2d

chore: crowding ci integration.

Check PR code / translations (pull_request) Failing after 59s

Details

2025-03-09 16:15:55 +01:00

davidoskky

a1c0241a58

Show a confirmation dialog before deleting sources (#185 )

Check master code / build (push) Successful in 15m3s

Details

## Types of changes

- [ x ] I have read the **CONTRIBUTING** document.
- [ x ] My code follows the code style of this project.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [ x ] All new and existing tests passed.
- [ x ] This is **NOT** translation related.

This is implements feature #156

I added a confirmation dialogue which pops up after tapping the delete source button. The popup displays the full name of the source to be deleted and allows the user to decide not to delete the source to prevent erroneous deletions.

I moved most of the logic into the viewholder. Can be easily reverted if you prefer.

All tests pass. I tested correct behavior in emulated versions of android API 25, 34 and 35.

Co-authored-by: Amine <amine.bouabdallaoui@pm.me>
Reviewed-on: #185
Co-authored-by: davidoskky <davidoskky@yahoo.it>
Co-committed-by: davidoskky <davidoskky@yahoo.it>

2025-03-09 13:49:32 +00:00

Compare commits

2 Commits

dcea40162c ... 13066bdf2d

Diff Content Not Available

Compare commits

2 Commits dcea40162c ... 13066bdf2d

Diff Content Not Available

2 Commits

dcea40162c ... 13066bdf2d