Louvorg/ReaderForSelfoss-multiplatform
Louvorg/ReaderForSelfoss-multiplatform
3
2
Fork 2
Code Issues 11 Pull Requests Actions Releases 75 Wiki Activity

Correct boolean serialization #73

Merged
AmineB merged 1 commits from davidoskky/ReaderForSelfoss-multiplatform:swiping into master 2022-10-04 18:40:15 +00:00
Conversation 1 Commits 1 Files Changed 1 +5 -1
davidoskky commented 2022-10-04 14:34:37 +00:00
Contributor
Copy Link

For some reason the short form ?: was not working correctly and serialization failed setting all true values to false.
This creates problems when marking items as read or starred.

I have identified other problems within the generation of the undo mark button which I will address in another PR.

This is addressing #72

For some reason the short form ?: was not working correctly and serialization failed setting all true values to false. This creates problems when marking items as read or starred. I have identified other problems within the generation of the undo mark button which I will address in another PR. This is addressing #72
davidoskky added 1 commit 2022-10-04 14:34:38 +00:00
Correct boolean serialization
All checks were successful
continuous-integration/drone/pr Build is passing
Details
32e7fc0038
AmineB approved these changes 2022-10-04 18:40:08 +00:00
AmineB merged commit 054e936657 into master 2022-10-04 18:40:15 +00:00
davidoskky deleted branch swiping 2022-10-04 18:56:37 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
AmineB
Labels
Clear labels
Difficulty - Beginner friendly
Difficulty = Easy
Difficulty = Hard
Difficulty = Medium
Priority = CRITICAL
Priority = High
Priority = Low
Priority = Normal
Priority = Some day
Status - Fixed somewhere else
Status - No details provided
Status = Can't fix
Status = Duplicate
Status = Help wanted
Status = Invalid
Status = Need more details
Status = Taken
Status = Wontfix
Type - Selfoss works like this
Type = Bug
Type = Chore
Type = Enhancement
Type = Feature
Type = Question
Type = SELFOSS API ISSUE
Type = Tools
Type = UX/Design
Up For Grabs
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Louvorg/ReaderForSelfoss-multiplatform#73
No description provided.
Delete Branch "davidoskky/ReaderForSelfoss-multiplatform:swiping"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?