davidoskky/ReaderForSelfoss-multiplatform
1
0
Fork 0
forked from Louvorg/ReaderForSelfoss-multiplatform
Code Issues Pull Requests Projects Releases Wiki Activity
599 Commits 4 Branches 0 Tags
a602f7adf25cf94d7bce408daca204b666e097f2
Commit Graph

599 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
AmineB a602f7adf2 fix: Connectivity toast message was causing issues. 2025-04-08 20:31:29 +02:00
giteadrone cf6ef51edf Changelog for v125030901 2025-03-31 18:44:08 +00:00
AmineB 0b7f832573 Merge pull request 'fix-reload' (#195) from fix-reload into master 
Reviewed-on: Louvorg/ReaderForSelfoss-multiplatform#195
 2025-03-31 18:25:33 +00:00
AmineB 22c966bf16 fix: Infinite scroll needs loading stats. 2025-03-30 21:57:36 +02:00
AmineB bdf2bb8b31 fix: do not reload items on resume. 2025-03-30 21:57:36 +02:00
AmineB ceae91206d Merge pull request 'tests' (#193) from tests into master 
Reviewed-on: Louvorg/ReaderForSelfoss-multiplatform#193
 2025-03-30 19:50:50 +00:00
AmineB 11c0e744dc ci: Instrumentation tests coverage in ci. 2025-03-30 20:23:15 +02:00
AmineB 7374e95b0e ci: Instrumentation tests coverage in ci. 2025-03-27 18:44:44 +01:00
AmineB 8a7743a6fb ci: Instrumentation tests coverage in ci. 2025-03-26 19:05:48 +01:00
AmineB 1b2e9edc8c chore: better handling of coroutine dispatchers. 2025-03-25 12:42:43 +01:00
AmineB 7c65a63315 ci: Instrumentation tests coverage in ci. 2025-03-24 23:09:51 +01:00
AmineB 02d503e03a chore: comment robolectric tests for now. 2025-03-16 15:44:02 +01:00
AmineB 24b9320d6d fix: Fixed source deletion test. 2025-03-16 14:27:30 +01:00
AmineB ceba58e98f Merge pull request 'Fix alignment changes resetting reader article position' (#190) from davidoskky/ReaderForSelfoss-multiplatform:alignment into master 
Reviewed-on: Louvorg/ReaderForSelfoss-multiplatform#190
 2025-03-16 13:14:44 +00:00
davidoskky c3ee07dd85 Refactor star icon handling 
Extracted all favorite handling to two functions. Makes it a little bit more readable.
 2025-03-12 16:07:49 +01:00
davidoskky 93d99192b3 Don't restart activity changing alignment 
When changing alignment in the reader we were restarting the reader activity to reload. Doing this led to reloading the article which was initially opened every time you changed alignment. Now, when changing the alignment we retain all existing fragments but command all of them to update their alignment setting.
 2025-03-12 16:07:49 +01:00
giteadrone 359dec2ca0 Changelog for v125030711 2025-03-12 11:39:57 +00:00
AmineB 62354ec70a Merge pull request 'fix: initial status loading issues.' (#192) from connectivity into master 
Reviewed-on: Louvorg/ReaderForSelfoss-multiplatform#192
 2025-03-12 11:20:14 +00:00
AmineB 18a17251ac chore: check changes for translations and android. 2025-03-11 22:20:07 +01:00
AmineB 5e91724ee2 fix: initial status loading issues. 2025-03-11 22:04:42 +01:00
AmineB 212d259a33 Merge pull request 'chore: new connectivity dep. Closes #84.' (#189) from connectivity into master 
Reviewed-on: Louvorg/ReaderForSelfoss-multiplatform#189
 2025-03-11 13:48:57 +00:00
AmineB 3bf60f1146 chore: new connectivity dep. Closes #84. 2025-03-10 21:11:39 +01:00
giteadrone ef13e300f0 Changelog for v125030681 2025-03-09 17:41:13 +00:00
AmineB f170d1157d chore: do not send reports on simulators. 2025-03-09 18:17:41 +01:00
AmineB af4752f0f0 Merge pull request 'chore: do not send reports on simulators.' (#188) from chore-acra-simulator into master 
Reviewed-on: Louvorg/ReaderForSelfoss-multiplatform#188
 2025-03-09 17:11:28 +00:00
AmineB f0fa1a17b6 chore: do not send reports on simulators. 2025-03-09 18:07:14 +01:00
AmineB bb84d1541c Merge pull request 'fix: Url validation was not failing login. Added tests.' (#186) from fix-invalid-url into master 
Reviewed-on: Louvorg/ReaderForSelfoss-multiplatform#186
 2025-03-09 16:54:18 +00:00
AmineB c9227b2c1c Merge pull request 'chore: crowding ci integration.' (#187) from chore-crowdin-ci into master 
Reviewed-on: Louvorg/ReaderForSelfoss-multiplatform#187
 2025-03-09 16:54:02 +00:00
AmineB 6eaad0c7c5 chore: we don't need to check if the url is valid in upsert screen. 2025-03-09 16:24:38 +01:00
AmineB a1c98aa7d0 fix: Url validation was not failing login. Added tests. 2025-03-09 16:24:38 +01:00
AmineB d5ec118679 chore: crowding ci integration. 2025-03-09 16:19:59 +01:00
davidoskky a1c0241a58 Show a confirmation dialog before deleting sources (#185) 
## Types of changes

- [ x ] I have read the **CONTRIBUTING** document.
- [ x ] My code follows the code style of this project.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [ x ] All new and existing tests passed.
- [ x ] This is **NOT** translation related.

This is implements feature #156

I added a confirmation dialogue which pops up after tapping the delete source button. The popup displays the full name of the source to be deleted and allows the user to decide not to delete the source to prevent erroneous deletions.

I moved most of the logic into the viewholder. Can be easily reverted if you prefer.

All tests pass. I tested correct behavior in emulated versions of android API 25, 34 and 35.

Co-authored-by: Amine <amine.bouabdallaoui@pm.me>
Reviewed-on: Louvorg/ReaderForSelfoss-multiplatform#185
Co-authored-by: davidoskky <davidoskky@yahoo.it>
Co-committed-by: davidoskky <davidoskky@yahoo.it>
 2025-03-09 13:49:32 +00:00
giteadrone f38936f9b4 Changelog for v125020581 2025-02-27 21:08:25 +00:00
AmineB a90ccec707 fix: url can be empty ? 2025-02-27 21:40:06 +01:00
giteadrone 2564b19726 Changelog for v125020471 2025-02-16 14:43:28 +00:00
AmineB 61c7bb20cc chore: no more docker-compose. 2025-02-16 15:17:51 +01:00
AmineB 6a0f5baf0a bump: gradle plugin. 2025-02-16 14:57:34 +01:00
AmineB 39f9505c00 Merge pull request 'fix: check index exists.' (#183) from fix-index into master 
Reviewed-on: Louvorg/ReaderForSelfoss-multiplatform#183
 2025-02-16 13:37:42 +00:00
AmineB 6a6d447456 fix: check index exists. 2025-02-16 13:57:42 +01:00
giteadrone 0bb4fe6aed Changelog for v125020411 2025-02-10 20:16:56 +00:00
AmineB 7df4c3368c Merge pull request 'bump' (#182) from bump into master 
Reviewed-on: Louvorg/ReaderForSelfoss-multiplatform#182
 2025-02-10 19:35:40 +00:00
AmineB c69635b5ae chore: non transiant R classes. 2025-02-09 22:27:53 +01:00
AmineB 3a829df70e Merge pull request 'fix: One more missing context.' (#181) from fix-one-more-context into master 
Reviewed-on: Louvorg/ReaderForSelfoss-multiplatform#181
 2025-02-09 20:44:29 +00:00
AmineB 7a0202689f bump 2025-02-09 21:44:02 +01:00
AmineB b20f6888f5 fix: One more missing context. 2025-02-09 14:42:17 +01:00
AmineB 6b96eb358d Merge pull request 'chore: more context issues.' (#180) from context-again into master 
Reviewed-on: Louvorg/ReaderForSelfoss-multiplatform#180
 2025-01-29 14:50:22 +00:00
AmineB dfc1bf9fa3 chore: more context issues. 2025-01-29 13:43:35 +01:00
giteadrone b173664ff0 Changelog for v125010241 2025-01-24 22:06:19 +00:00
AmineB bc20a421ae Merge pull request 'fix: Link not opening.' (#178) from fix-open-link into master 
Reviewed-on: Louvorg/ReaderForSelfoss-multiplatform#178
 2025-01-24 21:48:14 +00:00
AmineB 794500355a refactor: context fragments issues. 2025-01-24 21:44:20 +01:00