- France
- https://amine-bouabdallaoui.fr
- Joined on
2022-07-18
These two should be reverted to private.
Why was this removed ?
There are still version changes. Can you please revert them ?
Why was gradle and all the dependencies updated in this PR ?
Updating gradle forces to use java 17, so I'm unable to test this.
Can you revert all the version updates ? They should be done…
Why is this needed ? Can't it be replaced by this ?
repository.updateApiInformation() is called in goToMain which is called at line 152. This should not be needed.
@string/disable_ssl should be named @string/use_self_signed_cert
<string name="disable_ssl">Disable SSL</string> => <string name="use_self_signed_cert">Use a self signed certificate</string> in all the files.
Please revert this change.
No idea why I added this file. Can you please delete it ?
@davidoskky I restarted the build, it's now working.
I'll re review it pretty soon
The CI build was already failing before. Your changes were not the cause of this.
Yes, please.
These change break ios client handling. Please keep in mind to not break ios handling with the changed you make.
disableSSL should be disable_ssl
Please add back all the deleted xmlns:tools="http://schemas.android.com/tools".
Translations should be done on the translation tool. This will be overwritten when merged.