Amine Bouabdallaoui

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28

2022-08-20 18:38:15 +00:00

network

Is these functions needed ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28

2022-08-20 18:38:15 +00:00

network

Every block that does something like

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28

2022-08-20 18:38:15 +00:00

network

Please refactor this

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28

2022-08-20 18:38:15 +00:00

network

Please refactor this

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28

2022-08-20 18:38:15 +00:00

network

Please refactor this

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28

2022-08-20 18:38:15 +00:00

network

Please refactor this

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28

2022-08-20 18:38:15 +00:00

network

This should use the same isNetworkAvailable() function as the others.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28

2022-08-20 18:38:15 +00:00

network

And it can be refactored as the ones before.

AmineB suggested changes for Louvorg/ReaderForSelfoss-multiplatform#28

2022-08-20 18:38:15 +00:00

network

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28

2022-08-20 18:36:34 +00:00

network

And it can be refactored as the ones before.

AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform

2022-08-20 18:18:49 +00:00

112194dd4f Merge pull request 'Implement logging in the android application' (#32) from davidoskky/ReaderForSelfoss-multiplatform:logging into master

72d9ef92d2 Implement logging in the android application

Compare 2 commits »

AmineB merged pull request Louvorg/ReaderForSelfoss-multiplatform#32

2022-08-20 18:18:48 +00:00

Implement logging in the android application

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#32

2022-08-20 18:18:39 +00:00

Implement logging in the android application

This allows logging using the Napier library which is required to log from commonMain. For example this line doesn't log anything if this piece of code is not included. 1392e2a571/shared/src/com…

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#32

2022-08-20 10:53:48 +00:00

Implement logging in the android application

This logging is local, this shouldn't be affected by GDPR, this is needed when debugging;

What does it add to the default logcat ?

we can also not insert this, but we'll have to add it…

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#32

2022-08-20 10:44:50 +00:00

Implement logging in the android application

As I deleted the logging service I was using (because of GRPD) these options are not used anymore. Logging is only used when debugging.

AmineB commented on issue Louvorg/ReaderForSelfoss-multiplatform#25

2022-08-20 10:41:09 +00:00

Update remote option crashes the app

This was introduced when migrating.

I tested it with selfoss 2.19, not sure for other versions.

AmineB closed issue Louvorg/ReaderForSelfoss-multiplatform#25

2022-08-19 20:41:05 +00:00

Update remote option crashes the app

AmineB commented on issue Louvorg/ReaderForSelfoss-multiplatform#25

2022-08-19 20:40:42 +00:00

Update remote option crashes the app

Fixed in 51583b4996743c81fed116a420b105c316b0f20b

AmineB pushed to chore/sonarqube-fixes at Louvorg/ReaderForSelfoss-multiplatform

2022-08-19 20:39:55 +00:00

51583b4996 Fixes #25;

AmineB pushed to chore/sonarqube-fixes at Louvorg/ReaderForSelfoss-multiplatform

2022-08-19 20:30:30 +00:00

adf782c3bf Cache from settings.