Commit Graph

593 Commits

Author SHA1 Message Date
AmineB 11c0e744dc ci: Instrumentation tests coverage in ci.
PR / PR (pull_request) Successful in 1m1s
PR / translations (pull_request) Successful in 1m0s
PR / build (pull_request) Successful in 21m57s
PR test / integrationTests (pull_request) Successful in 50m51s
2025-03-30 20:23:15 +02:00
AmineB 7374e95b0e ci: Instrumentation tests coverage in ci.
Check PR code / translations (pull_request) Successful in 1m5s
Check PR code / Lint (pull_request) Successful in 1m8s
Check PR code / build (pull_request) Successful in 18m22s
Check PR code / RunIntegrationTests (pull_request) Has been cancelled
2025-03-27 18:44:44 +01:00
AmineB 8a7743a6fb ci: Instrumentation tests coverage in ci.
Check PR code / BuildAndTestAndCoverage (pull_request) Successful in 41m45s
2025-03-26 19:05:48 +01:00
AmineB 1b2e9edc8c chore: better handling of coroutine dispatchers.
Check PR code / BuildAndTestAndCoverage (pull_request) Successful in 30m26s
2025-03-25 12:42:43 +01:00
AmineB 7c65a63315 ci: Instrumentation tests coverage in ci.
Check PR code / BuildAndTestAndCoverage (pull_request) Successful in 34m46s
2025-03-24 23:09:51 +01:00
AmineB 02d503e03a chore: comment robolectric tests for now. 2025-03-16 15:44:02 +01:00
AmineB 24b9320d6d fix: Fixed source deletion test. 2025-03-16 14:27:30 +01:00
AmineB ceba58e98f Merge pull request 'Fix alignment changes resetting reader article position' (#190) from davidoskky/ReaderForSelfoss-multiplatform:alignment into master
Check master code / build (push) Successful in 8m27s
Reviewed-on: #190
2025-03-16 13:14:44 +00:00
davidoskky c3ee07dd85 Refactor star icon handling
Check PR code / translations (pull_request) Successful in 1m4s
Check PR code / Lint (pull_request) Successful in 1m25s
Check PR code / build (pull_request) Successful in 11m52s
Extracted all favorite handling to two functions. Makes it a little bit more readable.
2025-03-12 16:07:49 +01:00
davidoskky 93d99192b3 Don't restart activity changing alignment
When changing alignment in the reader we were restarting the reader activity to reload. Doing this led to reloading the article which was initially opened every time you changed alignment. Now, when changing the alignment we retain all existing fragments but command all of them to update their alignment setting.
2025-03-12 16:07:49 +01:00
giteadrone 359dec2ca0 Changelog for v125030711 2025-03-12 11:39:57 +00:00
AmineB 62354ec70a Merge pull request 'fix: initial status loading issues.' (#192) from connectivity into master
Check master code / build (push) Successful in 18m28s
Create tag / build (push) Successful in 18m21s
Create tag / createTagAndChangelog (push) Successful in 53s
Create tag / release (push) Successful in 4m19s
Reviewed-on: #192
v125030711
2025-03-12 11:20:14 +00:00
AmineB 18a17251ac chore: check changes for translations and android.
Check PR code / translations (pull_request) Successful in 2m30s
Check PR code / Lint (pull_request) Successful in 2m36s
Check PR code / build (pull_request) Successful in 16m14s
2025-03-11 22:20:07 +01:00
AmineB 5e91724ee2 fix: initial status loading issues.
Check PR code / Lint (pull_request) Successful in 3m56s
Check PR code / translations (pull_request) Successful in 1m32s
Check PR code / build (pull_request) Has been cancelled
2025-03-11 22:04:42 +01:00
AmineB 212d259a33 Merge pull request 'chore: new connectivity dep. Closes #84.' (#189) from connectivity into master
Check master code / build (push) Successful in 14m19s
Reviewed-on: #189
2025-03-11 13:48:57 +00:00
AmineB 3bf60f1146 chore: new connectivity dep. Closes #84.
Check PR code / Lint (pull_request) Successful in 1m2s
Check PR code / translations (pull_request) Successful in 1m24s
Check PR code / build (pull_request) Successful in 14m10s
2025-03-10 21:11:39 +01:00
giteadrone ef13e300f0 Changelog for v125030681 2025-03-09 17:41:13 +00:00
AmineB f170d1157d chore: do not send reports on simulators.
Check master code / build (push) Successful in 13m14s
Create tag / build (push) Successful in 7m34s
Create tag / createTagAndChangelog (push) Successful in 43s
Create tag / release (push) Successful in 5m15s
v125030681
2025-03-09 18:17:41 +01:00
AmineB af4752f0f0 Merge pull request 'chore: do not send reports on simulators.' (#188) from chore-acra-simulator into master
Check master code / build (push) Has been cancelled
Reviewed-on: #188
2025-03-09 17:11:28 +00:00
AmineB f0fa1a17b6 chore: do not send reports on simulators.
Check PR code / build (pull_request) Has been cancelled
Check PR code / Lint (pull_request) Has been cancelled
Check PR code / translations (pull_request) Has been cancelled
2025-03-09 18:07:14 +01:00
AmineB bb84d1541c Merge pull request 'fix: Url validation was not failing login. Added tests.' (#186) from fix-invalid-url into master
Check master code / build (push) Successful in 8m39s
Create tag / createTagAndChangelog (push) Has been cancelled
Create tag / release (push) Has been cancelled
Create tag / build (push) Has been cancelled
Reviewed-on: #186
2025-03-09 16:54:18 +00:00
AmineB c9227b2c1c Merge pull request 'chore: crowding ci integration.' (#187) from chore-crowdin-ci into master
Check master code / build (push) Has been cancelled
Reviewed-on: #187
2025-03-09 16:54:02 +00:00
AmineB 6eaad0c7c5 chore: we don't need to check if the url is valid in upsert screen.
Check PR code / Lint (pull_request) Successful in 4m19s
Check PR code / translations (pull_request) Successful in 2m2s
Check PR code / build (pull_request) Successful in 15m54s
2025-03-09 16:24:38 +01:00
AmineB a1c98aa7d0 fix: Url validation was not failing login. Added tests. 2025-03-09 16:24:38 +01:00
AmineB d5ec118679 chore: crowding ci integration.
Check PR code / Lint (pull_request) Successful in 3m20s
Check PR code / translations (pull_request) Successful in 3m44s
Check PR code / build (pull_request) Successful in 16m24s
2025-03-09 16:19:59 +01:00
davidoskky a1c0241a58 Show a confirmation dialog before deleting sources (#185)
Check master code / build (push) Successful in 15m3s
## Types of changes

- [ x ] I have read the **CONTRIBUTING** document.
- [ x ] My code follows the code style of this project.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [ x ] All new and existing tests passed.
- [ x ] This is **NOT** translation related.

This is implements feature #156

I added a confirmation dialogue which pops up after tapping the delete source button. The popup displays the full name of the source to be deleted and allows the user to decide not to delete the source to prevent erroneous deletions.

I moved most of the logic into the viewholder. Can be easily reverted if you prefer.

All tests pass. I tested correct behavior in emulated versions of android API 25, 34 and 35.

Co-authored-by: Amine <amine.bouabdallaoui@pm.me>
Reviewed-on: #185
Co-authored-by: davidoskky <davidoskky@yahoo.it>
Co-committed-by: davidoskky <davidoskky@yahoo.it>
2025-03-09 13:49:32 +00:00
giteadrone f38936f9b4 Changelog for v125020581 2025-02-27 21:08:25 +00:00
AmineB a90ccec707 fix: url can be empty ?
Check master code / build (push) Successful in 14m37s
Create tag / build (push) Successful in 7m25s
Create tag / createTagAndChangelog (push) Successful in 44s
Create tag / release (push) Successful in 5m12s
v125020581
2025-02-27 21:40:06 +01:00
giteadrone 2564b19726 Changelog for v125020471 2025-02-16 14:43:28 +00:00
AmineB 61c7bb20cc chore: no more docker-compose.
Create tag / build (push) Successful in 21m1s
Create tag / createTagAndChangelog (push) Successful in 1m21s
Create tag / release (push) Successful in 9m3s
Check master code / build (push) Successful in 34m35s
v125020471
2025-02-16 15:17:51 +01:00
AmineB 6a0f5baf0a bump: gradle plugin.
Check master code / build (push) Has been cancelled
2025-02-16 14:57:34 +01:00
AmineB 39f9505c00 Merge pull request 'fix: check index exists.' (#183) from fix-index into master
Check master code / build (push) Successful in 8m3s
Reviewed-on: #183
2025-02-16 13:37:42 +00:00
AmineB 6a6d447456 fix: check index exists.
Check PR code / Lint (pull_request) Successful in 3m57s
Check PR code / build (pull_request) Successful in 13m44s
2025-02-16 13:57:42 +01:00
giteadrone 0bb4fe6aed Changelog for v125020411 2025-02-10 20:16:56 +00:00
AmineB 7df4c3368c Merge pull request 'bump' (#182) from bump into master
Check master code / build (push) Successful in 11m6s
Create tag / build (push) Successful in 7m35s
Create tag / createTagAndChangelog (push) Successful in 44s
Create tag / release (push) Successful in 4m35s
Reviewed-on: #182
v125020411
2025-02-10 19:35:40 +00:00
AmineB c69635b5ae chore: non transiant R classes.
Check PR code / Lint (pull_request) Successful in 3m36s
Check PR code / build (pull_request) Successful in 16m13s
2025-02-09 22:27:53 +01:00
AmineB 3a829df70e Merge pull request 'fix: One more missing context.' (#181) from fix-one-more-context into master
Check master code / build (push) Successful in 13m26s
Reviewed-on: #181
2025-02-09 20:44:29 +00:00
AmineB 7a0202689f bump
Check PR code / Lint (pull_request) Successful in 4m42s
Check PR code / build (pull_request) Successful in 16m9s
2025-02-09 21:44:02 +01:00
AmineB b20f6888f5 fix: One more missing context.
Check PR code / Lint (pull_request) Successful in 1m1s
Check PR code / build (pull_request) Successful in 15m1s
2025-02-09 14:42:17 +01:00
AmineB 6b96eb358d Merge pull request 'chore: more context issues.' (#180) from context-again into master
Check master code / build (push) Successful in 7m35s
Create tag / build (push) Successful in 6m45s
Create tag / createTagAndChangelog (push) Successful in 42s
Create tag / release (push) Successful in 5m7s
Reviewed-on: #180
v125010291
2025-01-29 14:50:22 +00:00
AmineB dfc1bf9fa3 chore: more context issues.
Check PR code / Lint (pull_request) Successful in 2m33s
Check PR code / build (pull_request) Successful in 11m27s
2025-01-29 13:43:35 +01:00
giteadrone b173664ff0 Changelog for v125010241
Check master code / build (push) Successful in 9m50s
2025-01-24 22:06:19 +00:00
AmineB bc20a421ae Merge pull request 'fix: Link not opening.' (#178) from fix-open-link into master
Check master code / build (push) Successful in 7m47s
Create tag / build (push) Successful in 7m14s
Create tag / createTagAndChangelog (push) Successful in 44s
Create tag / release (push) Successful in 5m13s
Reviewed-on: #178
v125010241
2025-01-24 21:48:14 +00:00
AmineB 794500355a refactor: context fragments issues.
Check PR code / Lint (pull_request) Successful in 3m9s
Check PR code / build (pull_request) Successful in 12m15s
2025-01-24 21:44:20 +01:00
AmineB 44f9dd53d3 logs: Context issues. 2025-01-24 21:10:01 +01:00
AmineB 717d6b664c fix: Handle empty url issue, again. 2025-01-24 21:04:15 +01:00
AmineB e23289a3dc fix: Link not opening.
Check PR code / Lint (pull_request) Failing after 7m7s
Check PR code / build (pull_request) Has been skipped
2025-01-24 20:56:04 +01:00
giteadrone 2f5ebe2420 Changelog for v125010201
Check master code / build (push) Successful in 13m45s
2025-01-20 07:41:09 +00:00
AmineB 1893904135 fix: Handle empty url issue.
Check master code / build (push) Successful in 10m53s
Create tag / build (push) Successful in 7m40s
Create tag / createTagAndChangelog (push) Successful in 38s
Create tag / release (push) Successful in 5m3s
v125010201
2025-01-19 14:49:37 +01:00
AmineB a4cb28ba81 Merge pull request 'Removed the floating bar.' (#177) from floating-bar into master
Check master code / build (push) Successful in 11m40s
Reviewed-on: #177
2025-01-19 13:35:18 +00:00