fix: 'Enable Core Library Desugaring to support older Android versions' (#138 ) from davidoskky/ReaderForSelfoss-multiplatform:desugaring into master

Reviewed-on: https://gitea.amine-louveau.fr/Louvorg/ReaderForSelfoss-multiplatform/pulls/138
Enable Core Library Desugaring to support older Android versions
2023-04-12 18:26:37 +00:00 · 2023-04-12 16:29:47 +02:00 · 2023-03-26 18:21:43 +00:00 · 2023-03-26 11:12:01 +00:00 · 2023-03-25 20:28:30 +01:00 · 2023-03-17 10:10:38 +01:00
23 changed files with 321 additions and 196 deletions
--- a/.drone.yml
+++ b/.drone.yml
@@ -137,6 +137,27 @@ steps:
        from_secret: giteaAPI
      base_url: https://gitea.amine-louveau.fr
      files: signed.apk
+
+  - name: notify
+    image: drillster/drone-email
+    failure: ignore
+    settings:
+      host:
+        from_secret: smtpHOST
+      port:
+        from_secret: smtpPORT
+      username:
+        from_secret: smtpUSERNAME
+      password:
+        from_secret: smtpPASSWORD
+      from:
+        from_secret: smtpFROM
+      subject: Mapping file
+      recipients:
+        from_secret: smtpTO
+      recipients_only: true
+      skip_verify: true
+      attachment: androidApp/build/outputs/mapping/githubConfigRelease/mapping.txt
 trigger:
  event:
    - tag
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,36 @@
+**v123030851**
+
+- chore: replace textDrawable library (#136)
+- refactor: Remove slow login check. Closes #135.
+- ci: send the mapping file after a release.
+- Changelog for v123030751 [CI SKIP]
+
+--------------------------------------------------------------------
+
+**v123030751**
+
+- debug: added a lot to pinpoint the url issue.
+- feat: Use /sources/stats in the home (#133)
+- Changelog for v123030681 [CI SKIP]
+
+--------------------------------------------------------------------
+
+**v123030681**
+
+- fix: Unread and starred can be null.
+- Fixed version number issue.
+- Changelog for v123030621 [CI SKIP]
+
+--------------------------------------------------------------------
+
+**v123030621**
+
+- fix: url required issue.
+- fix: Canvas reused issue.
+- Changelog for v123020572 [CI SKIP]
+
+--------------------------------------------------------------------
+
 **v123020572**

 - fix: requirecontext issues ?
--- a/androidApp/build.gradle.kts
+++ b/androidApp/build.gradle.kts
@@ -28,7 +28,7 @@ fun gitVersion(): String {
    val maybeTagOfCurrentCommit = execWithOutput("git -C ../ describe --contains HEAD", true)
    process = if (maybeTagOfCurrentCommit.isEmpty()) {
        println("No tag on current commit. Will take the latest one.")
-        execWithOutput("git -C ../ for-each-ref refs/tags --sort=-authordate --format='%(refname:short)' --count=1")
+        execWithOutput("git -C ../ for-each-ref refs/tags --sort=-refname --format='%(refname:short)' --count=1")
    } else {
        println("Tag found on current commit")
        execWithOutput("git -C ../ describe --contains HEAD")
@@ -56,6 +56,7 @@ fun versionNameFromGit(): String {

 android {
    compileOptions {
+        isCoreLibraryDesugaringEnabled = true
        // Flag to enable support for the new language APIs
        sourceCompatibility = JavaVersion.VERSION_11
        targetCompatibility = JavaVersion.VERSION_11
@@ -112,6 +113,8 @@ android {
 }

 dependencies {
+    coreLibraryDesugaring("com.android.tools:desugar_jdk_libs:2.0.3")
+
    implementation(project(":shared"))
    implementation("com.google.android.material:material:1.5.0")
    implementation("androidx.appcompat:appcompat:1.4.1")
@@ -142,11 +145,10 @@ dependencies {

    // Material-ish things
    implementation("com.ashokvarma.android:bottom-navigation-bar:2.2.0")
-    implementation("com.amulyakhare:com.amulyakhare.textdrawable:1.0.1")

    // glide
-    kapt("com.github.bumptech.glide:compiler:4.14.2")
-    implementation("com.github.bumptech.glide:okhttp3-integration:4.14.2")
+    kapt("com.github.bumptech.glide:compiler:4.15.0")
+    implementation("com.github.bumptech.glide:okhttp3-integration:4.15.0")

    // Themes
    implementation("com.github.rubensousa:floatingtoolbar:1.5.1")
@@ -174,7 +176,7 @@ dependencies {
    implementation("androidx.lifecycle:lifecycle-extensions:2.2.0")

    // Network information
-     implementation("com.github.ln-12:multiplatform-connectivity-status:1.3.0")
+    implementation("com.github.ln-12:multiplatform-connectivity-status:1.3.0")

    // SQLDELIGHT
    implementation("com.squareup.sqldelight:android-driver:1.5.4")
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/LoginActivity.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/LoginActivity.kt
@@ -57,29 +57,7 @@ class LoginActivity : AppCompatActivity(), DIAware {

        if (appSettingsService.getBaseUrl().isNotEmpty()) {
            showProgress(true)
-            // This should be reverted when "old" users connected with a non-selfoss rss
-            // are handled. Revert to "simple" way.
-            CoroutineScope(Dispatchers.Main).launch {
-                try {
-                    val (errorFetching, displaySelfossOnly) = repository.shouldBeSelfossInstance()
-                    if (!errorFetching && !displaySelfossOnly) {
-                        goToMain()
-                    } else {
-                        showProgress(false)
-                        if (displaySelfossOnly) {
-                            Toast.makeText(
-                                applicationContext,
-                                R.string.application_selfoss_only,
-                                Toast.LENGTH_LONG
-                            ).show()
-                        }
-                        repository.logout()
-                    }
-                } catch (e: Throwable) {
-                    repository.logout()
-                    showProgress(false)
-                }
-            }
+            goToMain()
        }

        handleActions()
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/SourcesActivity.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/SourcesActivity.kt
@@ -49,13 +49,13 @@ class SourcesActivity : AppCompatActivity(), DIAware {
        super.onResume()
        val mLayoutManager = LinearLayoutManager(this)

-        var items: ArrayList<SelfossModel.Source>
+        var items: ArrayList<SelfossModel.SourceDetail>

        binding.recyclerView.setHasFixedSize(true)
        binding.recyclerView.layoutManager = mLayoutManager

        CoroutineScope(Dispatchers.Main).launch {
-            val response = repository.getSources()
+            val response = repository.getSourcesDetails()
            if (response.isNotEmpty()) {
                items = response
                val mAdapter = SourcesListAdapter(
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/UpsertSourceActivity.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/UpsertSourceActivity.kt
@@ -24,7 +24,7 @@ import org.kodein.di.instance

 class UpsertSourceActivity : AppCompatActivity(), DIAware {

-    private var existingSource: SelfossModel.Source? = null
+    private var existingSource: SelfossModel.SourceDetail? = null
    private var mSpoutsValue: String? = null

    private lateinit var binding: ActivityUpsertSourceBinding
@@ -68,7 +68,7 @@ class UpsertSourceActivity : AppCompatActivity(), DIAware {

    private fun initFields(items: Map<String, SelfossModel.Spout>) {
        binding.nameInput.setText(existingSource!!.title)
-        binding.tags.setText(existingSource!!.tags.joinToString(", "))
+        binding.tags.setText(existingSource!!.tags?.joinToString(", "))
        binding.sourceUri.setText(existingSource!!.params?.url)
        binding.spoutsSpinner.setSelection(items.keys.indexOf(existingSource!!.spout))
        binding.progress.visibility = View.GONE
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/ItemCardAdapter.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/ItemCardAdapter.kt
@@ -9,10 +9,9 @@ import android.widget.ImageView.ScaleType
 import androidx.recyclerview.widget.RecyclerView
 import bou.amine.apps.readerforselfossv2.android.R
 import bou.amine.apps.readerforselfossv2.android.databinding.CardItemBinding
-import bou.amine.apps.readerforselfossv2.android.model.toTextDrawableString
 import bou.amine.apps.readerforselfossv2.android.utils.LinkOnTouchListener
 import bou.amine.apps.readerforselfossv2.android.utils.glide.bitmapCenterCrop
-import bou.amine.apps.readerforselfossv2.android.utils.glide.circularBitmapDrawable
+import bou.amine.apps.readerforselfossv2.android.utils.glide.circularDrawable
 import bou.amine.apps.readerforselfossv2.android.utils.openInBrowserAsNewTask
 import bou.amine.apps.readerforselfossv2.android.utils.openItemUrl
 import bou.amine.apps.readerforselfossv2.android.utils.shareLink
@@ -22,8 +21,6 @@ import bou.amine.apps.readerforselfossv2.service.AppSettingsService
 import bou.amine.apps.readerforselfossv2.utils.getHtmlDecoded
 import bou.amine.apps.readerforselfossv2.utils.getIcon
 import bou.amine.apps.readerforselfossv2.utils.getThumbnail
-import com.amulyakhare.textdrawable.TextDrawable
-import com.amulyakhare.textdrawable.util.ColorGenerator
 import com.bumptech.glide.Glide
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Dispatchers
@@ -38,7 +35,6 @@ class ItemCardAdapter(
    override val updateItems: (ArrayList<SelfossModel.Item>) -> Unit
 ) : ItemsAdapter<ItemCardAdapter.ViewHolder>() {
    private val c: Context = app.baseContext
-    private val generator: ColorGenerator = ColorGenerator.MATERIAL
    private val imageMaxHeight: Int =
        c.resources.getDimension(R.dimen.card_image_max_height).toInt()

@@ -83,16 +79,9 @@ class ItemCardAdapter(
            }

            if (itm.getIcon(repository.baseUrl).isEmpty()) {
-                val color = generator.getColor(itm.title.getHtmlDecoded())
-
-                val drawable =
-                    TextDrawable
-                        .builder()
-                        .round()
-                        .build(itm.title.getHtmlDecoded().toTextDrawableString(), color)
-                binding.sourceImage.setImageDrawable(drawable)
+                binding.sourceImage.setBackgroundAndText(itm.sourcetitle.getHtmlDecoded())
            } else {
-                c.circularBitmapDrawable(itm.getIcon(repository.baseUrl), binding.sourceImage)
+                c.circularDrawable(itm.getIcon(repository.baseUrl), binding.sourceImage)
            }
        }
    }
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/ItemListAdapter.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/ItemListAdapter.kt
@@ -7,10 +7,8 @@ import android.view.ViewGroup
 import androidx.recyclerview.widget.RecyclerView
 import bou.amine.apps.readerforselfossv2.android.R
 import bou.amine.apps.readerforselfossv2.android.databinding.ListItemBinding
-import bou.amine.apps.readerforselfossv2.android.model.toTextDrawableString
 import bou.amine.apps.readerforselfossv2.android.utils.LinkOnTouchListener
-import bou.amine.apps.readerforselfossv2.android.utils.glide.bitmapCenterCrop
-import bou.amine.apps.readerforselfossv2.android.utils.glide.circularBitmapDrawable
+import bou.amine.apps.readerforselfossv2.android.utils.glide.circularDrawable
 import bou.amine.apps.readerforselfossv2.android.utils.openItemUrl
 import bou.amine.apps.readerforselfossv2.model.SelfossModel
 import bou.amine.apps.readerforselfossv2.repository.Repository
@@ -18,8 +16,6 @@ import bou.amine.apps.readerforselfossv2.service.AppSettingsService
 import bou.amine.apps.readerforselfossv2.utils.getHtmlDecoded
 import bou.amine.apps.readerforselfossv2.utils.getIcon
 import bou.amine.apps.readerforselfossv2.utils.getThumbnail
-import com.amulyakhare.textdrawable.TextDrawable
-import com.amulyakhare.textdrawable.util.ColorGenerator
 import org.kodein.di.DI
 import org.kodein.di.android.closestDI
 import org.kodein.di.instance
@@ -29,7 +25,6 @@ class ItemListAdapter(
    override var items: ArrayList<SelfossModel.Item>,
    override val updateItems: (ArrayList<SelfossModel.Item>) -> Unit
 ) : ItemsAdapter<ItemListAdapter.ViewHolder>() {
-    private val generator: ColorGenerator = ColorGenerator.MATERIAL
    private val c: Context = app.baseContext

    override val di: DI by closestDI(app)
@@ -56,20 +51,12 @@ class ItemListAdapter(
            if (itm.getThumbnail(repository.baseUrl).isEmpty()) {

                if (itm.getIcon(repository.baseUrl).isEmpty()) {
-                    val color = generator.getColor(itm.title.getHtmlDecoded())
-
-                    val drawable =
-                            TextDrawable
-                                    .builder()
-                                    .round()
-                                    .build(itm.title.getHtmlDecoded().toTextDrawableString(), color)
-
-                    binding.itemImage.setImageDrawable(drawable)
+                    binding.itemImage.setBackgroundAndText(itm.sourcetitle.getHtmlDecoded())
                } else {
-                    c.circularBitmapDrawable(itm.getIcon(repository.baseUrl), binding.itemImage)
+                    c.circularDrawable(itm.getIcon(repository.baseUrl), binding.itemImage)
                }
            } else {
-                c.bitmapCenterCrop(itm.getThumbnail(repository.baseUrl), binding.itemImage)
+                c.circularDrawable(itm.getThumbnail(repository.baseUrl), binding.itemImage)
            }
        }
    }
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/SourcesListAdapter.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/adapters/SourcesListAdapter.kt
@@ -10,17 +10,14 @@ import android.widget.Button
 import android.widget.Toast
 import androidx.constraintlayout.widget.ConstraintLayout
 import androidx.recyclerview.widget.RecyclerView
-import bou.amine.apps.readerforselfossv2.android.UpsertSourceActivity
 import bou.amine.apps.readerforselfossv2.android.R
+import bou.amine.apps.readerforselfossv2.android.UpsertSourceActivity
 import bou.amine.apps.readerforselfossv2.android.databinding.SourceListItemBinding
-import bou.amine.apps.readerforselfossv2.android.model.toTextDrawableString
-import bou.amine.apps.readerforselfossv2.android.utils.glide.circularBitmapDrawable
+import bou.amine.apps.readerforselfossv2.android.utils.glide.circularDrawable
 import bou.amine.apps.readerforselfossv2.model.SelfossModel
 import bou.amine.apps.readerforselfossv2.repository.Repository
 import bou.amine.apps.readerforselfossv2.utils.getHtmlDecoded
 import bou.amine.apps.readerforselfossv2.utils.getIcon
-import com.amulyakhare.textdrawable.TextDrawable
-import com.amulyakhare.textdrawable.util.ColorGenerator
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
@@ -31,10 +28,9 @@ import org.kodein.di.instance

 class SourcesListAdapter(
    private val app: Activity,
-    private val items: ArrayList<SelfossModel.Source>
+    private val items: ArrayList<SelfossModel.SourceDetail>
 ) : RecyclerView.Adapter<SourcesListAdapter.ViewHolder>(), DIAware {
    private val c: Context = app.baseContext
-    private val generator: ColorGenerator = ColorGenerator.MATERIAL
    private lateinit var binding: SourceListItemBinding

    override val di: DI by closestDI(app)
@@ -49,19 +45,12 @@ class SourcesListAdapter(
        val itm = items[position]

        if (itm.getIcon(repository.baseUrl).isEmpty()) {
-            val color = generator.getColor(itm.title.getHtmlDecoded())
-
-            val drawable =
-                TextDrawable
-                    .builder()
-                    .round()
-                    .build(itm.title.getHtmlDecoded().toTextDrawableString(), color)
-            binding.itemImage.setImageDrawable(drawable)
+            binding.itemImage.setBackgroundAndText(itm.title.getHtmlDecoded())
        } else {
-            c.circularBitmapDrawable(itm.getIcon(repository.baseUrl), binding.itemImage)
+            c.circularDrawable(itm.getIcon(repository.baseUrl), binding.itemImage)
        }

-        if (itm.error.isNotBlank()) {
+        if (!itm.error.isNullOrBlank()) {
            binding.errorText.visibility = View.VISIBLE
            binding.errorText.text = itm.error
        } else {
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/fragments/ArticleFragment.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/fragments/ArticleFragment.kt
@@ -406,7 +406,7 @@ class ArticleFragment : Fragment(), DIAware {
                val itemUrl = URL(url)
                baseUrl = itemUrl.protocol + "://" + itemUrl.host
            } catch (e: MalformedURLException) {
-                e.sendSilentlyWithAcraWithName("htmlToWebview > item url")
+                e.sendSilentlyWithAcraWithName("htmlToWebview > $url")
            }

            val fontName = when (font) {
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/fragments/FilterSheetFragment.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/fragments/FilterSheetFragment.kt
@@ -20,10 +20,8 @@ import bou.amine.apps.readerforselfossv2.repository.Repository
 import bou.amine.apps.readerforselfossv2.utils.getHtmlDecoded
 import bou.amine.apps.readerforselfossv2.utils.getIcon
 import com.bumptech.glide.Glide
-import com.bumptech.glide.load.DataSource
-import com.bumptech.glide.load.engine.GlideException
-import com.bumptech.glide.request.RequestListener
-import com.bumptech.glide.request.target.Target
+import com.bumptech.glide.request.target.ViewTarget
+import com.bumptech.glide.request.transition.Transition
 import com.google.android.material.bottomsheet.BottomSheetDialogFragment
 import com.google.android.material.chip.Chip
 import kotlinx.coroutines.CoroutineScope
@@ -84,37 +82,25 @@ class FilterSheetFragment : BottomSheetDialogFragment(), DIAware {
    ) {
        val sourceGroup = binding.sourcesGroup

-        repository.getSources().forEach { source ->
+        repository.getSourcesDetailsOrStats().forEach { source ->
            val c = Chip(context)
            c.ellipsize = TextUtils.TruncateAt.END

            Glide.with(context)
                .load(source.getIcon(repository.baseUrl))
-                .listener(object : RequestListener<Drawable?> {
-                    override fun onLoadFailed(
-                        e: GlideException?,
-                        model: Any?,
-                        target: Target<Drawable?>?,
-                        isFirstResource: Boolean
-                    ): Boolean {
-                        return false
-                    }
-
+                .into(object : ViewTarget<Chip?, Drawable?>(c) {
                    override fun onResourceReady(
-                        resource: Drawable?,
-                        model: Any?,
-                        target: Target<Drawable?>?,
-                        dataSource: DataSource?,
-                        isFirstResource: Boolean
-                    ): Boolean {
+                        resource: Drawable,
+                        transition: Transition<in Drawable?>?
+                    ) {
                        try {
                            c.chipIcon = resource
                        } catch (e: Exception) {
                            e.sendSilentlyWithAcraWithName("sources > onResourceReady")
                        }
-                        return false
                    }
-                }).preload()
+
+                })

            c.text = source.title.getHtmlDecoded()

@@ -141,9 +127,9 @@ class FilterSheetFragment : BottomSheetDialogFragment(), DIAware {
                selectedChip = c
            }

-            c.isEnabled = source.error.isBlank()
+            c.isEnabled = source.error.isNullOrBlank()

-            if (source.error.isNotBlank() && Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
+            if (!source.error.isNullOrBlank() && Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
                c.tooltipText = source.error
            }

--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/utils/CircleImageView.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/utils/CircleImageView.kt
@@ -0,0 +1,62 @@
+package bou.amine.apps.readerforselfossv2.android.utils
+
+import android.content.Context
+import android.graphics.drawable.GradientDrawable
+import android.util.AttributeSet
+import android.view.LayoutInflater
+import android.view.View
+import android.widget.RelativeLayout
+import android.widget.TextView
+import bou.amine.apps.readerforselfossv2.android.R
+import bou.amine.apps.readerforselfossv2.android.model.toTextDrawableString
+import com.google.android.material.imageview.ShapeableImageView
+import kotlin.math.abs
+
+class CircleImageView @JvmOverloads constructor(
+    context: Context,
+    attrs: AttributeSet? = null,
+    defStyleAttr: Int = 0
+) : RelativeLayout(context, attrs, defStyleAttr) {
+    val view: View
+    val imageView: ShapeableImageView
+    val textView: TextView
+
+    private val colorScheme = listOf(
+    -0x1a8c8d,
+    -0xf9d6e,
+    -0x459738,
+    -0x6a8a33,
+    -0x867935,
+    -0x9b4a0a,
+    -0xb03c09,
+    -0xb22f1f,
+    -0xb24954,
+    -0x7e387c,
+    -0x512a7f,
+    -0x759b,
+    -0x2b1ea9,
+    -0x2ab1,
+    -0x48b3,
+    -0x5e7781,
+    -0x6f5b52
+    )
+
+    init {
+        view = LayoutInflater.from(context).inflate(R.layout.circle_image_view, this, true)
+        imageView = view.findViewById(R.id.circleImage)
+        textView = view.findViewById(R.id.circleText)
+    }
+
+    fun setBackgroundAndText(text: String) {
+        val circleDrawable = GradientDrawable()
+        val color = colorFromIdentifier(text)
+        circleDrawable.setColor(color)
+        imageView.setImageDrawable(circleDrawable)
+
+        textView.text = text.toTextDrawableString()
+    }
+
+    private fun colorFromIdentifier(key: String): Int {
+        return colorScheme[abs(key.hashCode()) % colorScheme.size]
+    }
+}
--- a/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/utils/glide/GlideUtils.kt
+++ b/androidApp/src/main/java/bou/amine/apps/readerforselfossv2/android/utils/glide/GlideUtils.kt
@@ -3,10 +3,9 @@ package bou.amine.apps.readerforselfossv2.android.utils.glide
 import android.content.Context
 import android.graphics.Bitmap
 import android.widget.ImageView
-import androidx.core.graphics.drawable.RoundedBitmapDrawableFactory
+import bou.amine.apps.readerforselfossv2.android.utils.CircleImageView
 import com.bumptech.glide.Glide
 import com.bumptech.glide.request.RequestOptions
-import com.bumptech.glide.request.target.BitmapImageViewTarget
 import java.io.ByteArrayInputStream
 import java.io.ByteArrayOutputStream
 import java.io.InputStream
@@ -18,21 +17,13 @@ fun Context.bitmapCenterCrop(url: String, iv: ImageView) =
        .apply(RequestOptions.centerCropTransform())
        .into(iv)

-fun Context.circularBitmapDrawable(url: String, iv: ImageView) =
+fun Context.circularDrawable(url: String, view: CircleImageView) {
+    view.textView.text =""
+
    Glide.with(this)
-        .asBitmap()
        .load(url)
-        .apply(RequestOptions.centerCropTransform())
-        .into(object : BitmapImageViewTarget(iv) {
-            override fun setResource(resource: Bitmap?) {
-                val circularBitmapDrawable = RoundedBitmapDrawableFactory.create(
-                    resources,
-                    resource
-                )
-                circularBitmapDrawable.isCircular = true
-                iv.setImageDrawable(circularBitmapDrawable)
-            }
-        })
+        .into(view.imageView)
+}

 fun getBitmapInputStream(bitmap:Bitmap,compressFormat: Bitmap.CompressFormat): InputStream {
    val byteArrayOutputStream = ByteArrayOutputStream()
--- a/androidApp/src/main/res/layout/card_item.xml
+++ b/androidApp/src/main/res/layout/card_item.xml
@@ -39,7 +39,7 @@
            app:layout_constraintStart_toStartOf="parent"
            app:layout_constraintTop_toBottomOf="@+id/itemImage">

-            <ImageView
+            <bou.amine.apps.readerforselfossv2.android.utils.CircleImageView
                android:id="@+id/sourceImage"
                android:layout_width="40dp"
                android:layout_height="40dp"
--- a/androidApp/src/main/res/layout/circle_image_view.xml
+++ b/androidApp/src/main/res/layout/circle_image_view.xml
@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="utf-8"?>
+<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto"
+    android:layout_width="wrap_content"
+    android:layout_height="wrap_content">
+
+    <com.google.android.material.imageview.ShapeableImageView
+        android:id="@+id/circleImage"
+        android:layout_width="match_parent"
+        android:layout_height="match_parent"
+        android:scaleType="centerCrop"
+        app:shapeAppearanceOverlay="@style/circleImageView"
+        app:srcCompat="@drawable/background_splash" />
+
+    <TextView
+        android:id="@+id/circleText"
+        android:layout_width="match_parent"
+        android:layout_height="match_parent"
+        android:ellipsize="none"
+        android:gravity="center"
+        android:singleLine="true"
+        android:textColor="@color/white"
+        android:textIsSelectable="false"
+        android:textSize="20sp"
+        android:typeface="normal" />
+</RelativeLayout>
--- a/androidApp/src/main/res/layout/list_item.xml
+++ b/androidApp/src/main/res/layout/list_item.xml
@@ -5,7 +5,7 @@
    android:layout_width="match_parent"
    android:layout_height="wrap_content">

-    <ImageView
+    <bou.amine.apps.readerforselfossv2.android.utils.CircleImageView
        android:id="@+id/itemImage"
        android:layout_width="46dp"
        android:layout_height="46dp"
--- a/androidApp/src/main/res/layout/source_list_item.xml
+++ b/androidApp/src/main/res/layout/source_list_item.xml
@@ -25,7 +25,7 @@
        app:layout_constraintTop_toTopOf="parent"
        app:layout_constraintVertical_bias="0.0" />

-    <ImageView
+    <bou.amine.apps.readerforselfossv2.android.utils.CircleImageView
        android:id="@+id/itemImage"
        android:layout_width="36dp"
        android:layout_height="36dp"
--- a/androidApp/src/main/res/values/styles.xml
+++ b/androidApp/src/main/res/values/styles.xml
@@ -32,4 +32,10 @@
        <item name="android:colorBackgroundCacheHint">@null</item>
        <item name="android:windowIsTranslucent">true</item>
    </style>
+
+    <style name="circleImageView" parent="">
+        <item name="cornerFamily">rounded</item>
+        <item name="cornerSize">50%</item>
+    </style>
+
 </resources>
--- a/androidApp/src/test/kotlin/RepositoryTest.kt
+++ b/androidApp/src/test/kotlin/RepositoryTest.kt
@@ -300,9 +300,10 @@ class RepositoryTest {
        every { appSettingsService.isItemCachingEnabled() } returns true

        initializeRepository(MutableStateFlow(false))
-        repository.setSourceFilter(SelfossModel.Source(
+        repository.setSourceFilter(SelfossModel.SourceDetail(
            1,
            "Test",
+            null,
            listOf("tags"),
            SPOUT,
            "",
@@ -609,30 +610,32 @@ class RepositoryTest {
    fun get_sources() {
        val (sources, sourcesDB) = prepareSources()
        initializeRepository()
-        var testSources: List<SelfossModel.Source>?
+        var testSources: List<SelfossModel.Source>
        runBlocking {
-            testSources = repository.getSources()
+            testSources = repository.getSourcesDetails()
        }

-        assertSame(sources, testSources)
+        assertEquals(sources, testSources)
        assertNotEquals(sourcesDB.map { it.toView() }, testSources)
-        coVerify(exactly = 1) { api.sources() }
+        coVerify(exactly = 1) { api.sourcesDetailed() }
    }

-    private fun prepareSources(): Pair<ArrayList<SelfossModel.Source>, List<SOURCE>> {
+    private fun prepareSources(): Pair<ArrayList<SelfossModel.SourceDetail>, List<SOURCE>> {
        val sources = arrayListOf(
-            SelfossModel.Source(
+            SelfossModel.SourceDetail(
                1,
                "First source",
+                null,
                listOf("Test", "second"),
                SPOUT,
                "",
                IMAGE_URL_2,
                SelfossModel.SourceParams("url")
            ),
-            SelfossModel.Source(
+            SelfossModel.SourceDetail(
                2,
                "Second source",
+                null,
                listOf("second"),
                SPOUT,
                "",
@@ -661,7 +664,7 @@ class RepositoryTest {
            )
        )

-        coEvery { api.sources() } returns StatusAndData(success = true, data = sources)
+        coEvery { api.sourcesDetailed() } returns StatusAndData(success = true, data = sources)
        every { db.sourcesQueries.sources().executeAsList() } returns sourcesDB
        return Pair(sources, sourcesDB)
    }
@@ -675,13 +678,13 @@ class RepositoryTest {
        initializeRepository()
        var testSources: List<SelfossModel.Source>?
        runBlocking {
-            testSources = repository.getSources()
+            testSources = repository.getSourcesDetails()
            // Sources will be fetched from the database on the second call, thus testSources != sources
-            testSources = repository.getSources()
+            testSources = repository.getSourcesDetails()
        }

-        coVerify(exactly = 1) { api.sources() }
-        assertNotSame(sources, testSources)
+        coVerify(exactly = 1) { api.sourcesDetailed() }
+        assertNotEquals(sources, testSources)
        assertEquals(sourcesDB.map { it.toView() }, testSources)
        verify(atLeast = 1) { db.sourcesQueries.sources().executeAsList() }
    }
@@ -693,13 +696,13 @@ class RepositoryTest {
        every { appSettingsService.isUpdateSourcesEnabled() } returns true
        every { appSettingsService.isItemCachingEnabled() } returns false
        initializeRepository()
-        var testSources: List<SelfossModel.Source>?
+        var testSources: List<SelfossModel.Source>
        runBlocking {
-            testSources = repository.getSources()
+            testSources = repository.getSourcesDetails()
        }

-        assertSame(sources, testSources)
-        coVerify(exactly = 1) { api.sources() }
+        assertEquals(sources, testSources)
+        coVerify(exactly = 1) { api.sourcesDetailed() }
        verify(exactly = 0) { db.sourcesQueries }
    }

@@ -710,13 +713,13 @@ class RepositoryTest {
        every { appSettingsService.isUpdateSourcesEnabled() } returns false
        every { appSettingsService.isItemCachingEnabled() } returns false
        initializeRepository()
-        var testSources: List<SelfossModel.Source>?
+        var testSources: List<SelfossModel.Source>
        runBlocking {
-            testSources = repository.getSources()
+            testSources = repository.getSourcesDetails()
        }

-        assertSame(sources, testSources)
-        coVerify(exactly = 1) { api.sources() }
+        assertEquals(sources, testSources)
+        coVerify(exactly = 1) { api.sourcesDetailed() }
        verify(atLeast = 1) { db.sourcesQueries }
    }

@@ -724,13 +727,13 @@ class RepositoryTest {
    fun get_sources_without_connection() {
        val (_, sourcesDB) = prepareSources()
        initializeRepository(MutableStateFlow(false))
-        var testSources: List<SelfossModel.Source>?
+        var testSources: List<SelfossModel.Source>
        runBlocking {
-            testSources = repository.getSources()
+            testSources = repository.getSourcesDetails()
        }

        assertEquals(sourcesDB.map { it.toView() }, testSources)
-        coVerify(exactly = 0) { api.sources() }
+        coVerify(exactly = 0) { api.sourcesDetailed() }
        verify(atLeast = 1) { db.sourcesQueries.sources().executeAsList() }
    }

@@ -741,13 +744,13 @@ class RepositoryTest {
        every { appSettingsService.isItemCachingEnabled() } returns false
        every { appSettingsService.isUpdateSourcesEnabled() } returns true
        initializeRepository(MutableStateFlow(false))
-        var testSources: List<SelfossModel.Source>?
+        var testSources: List<SelfossModel.Source>
        runBlocking {
-            testSources = repository.getSources()
+            testSources = repository.getSourcesDetails()
        }

        assertEquals(emptyList<SelfossModel.Source>(), testSources)
-        coVerify(exactly = 0) { api.sources() }
+        coVerify(exactly = 0) { api.sourcesDetailed() }
        verify(exactly = 0) { db.sourcesQueries.sources().executeAsList() }
    }

@@ -758,13 +761,13 @@ class RepositoryTest {
        every { appSettingsService.isItemCachingEnabled() } returns true
        every { appSettingsService.isUpdateSourcesEnabled() } returns false
        initializeRepository(MutableStateFlow(false))
-        var testSources: List<SelfossModel.Source>?
+        var testSources: List<SelfossModel.Source>
        runBlocking {
-            testSources = repository.getSources()
+            testSources = repository.getSourcesDetails()
        }

        assertEquals(sourcesDB.map { it.toView() }, testSources)
-        coVerify(exactly = 0) { api.sources() }
+        coVerify(exactly = 0) { api.sourcesDetailed() }
        verify(atLeast = 1) { db.sourcesQueries.sources().executeAsList() }
    }

@@ -775,13 +778,13 @@ class RepositoryTest {
        every { appSettingsService.isItemCachingEnabled() } returns false
        every { appSettingsService.isUpdateSourcesEnabled() } returns false
        initializeRepository(MutableStateFlow(false))
-        var testSources: List<SelfossModel.Source>?
+        var testSources: List<SelfossModel.Source>
        runBlocking {
-            testSources = repository.getSources()
+            testSources = repository.getSourcesDetails()
        }

        assertEquals(sourcesDB.map { it.toView() }, testSources)
-        coVerify(exactly = 0) { api.sources() }
+        coVerify(exactly = 0) { api.sourcesDetailed() }
        verify(atLeast = 1) { db.sourcesQueries.sources().executeAsList() }
    }

@@ -1102,9 +1105,10 @@ class RepositoryTest {
    private fun prepareSearch() {
        repository.setTagFilter(SelfossModel.Tag("Tag", "read", 0))
        repository.setSourceFilter(
-            SelfossModel.Source(
+            SelfossModel.SourceDetail(
                1,
                "First source",
+                5,
                listOf("Test", "second"),
                SPOUT,
                "",
--- a/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/model/SelfossModel.kt
+++ b/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/model/SelfossModel.kt
@@ -24,8 +24,8 @@ class SelfossModel {
    @Serializable
    class Stats(
        val total: Int,
-        val unread: Int,
-        val starred: Int
+        val unread: Int?,
+        val starred: Int?
    )

    @Serializable
@@ -63,20 +63,39 @@ class SelfossModel {
        fun isPublicModeEnabled() = publicMode ?: false
    }

+    interface Source {
+        val id: Int
+        var title: String
+        var unread: Int?
+        var error: String?
+        var icon: String?
+    }
+
    @Serializable
-    data class Source(
-        val id: Int,
-        val title: String,
+    data class SourceStats(
+        override val id: Int,
+        override var title: String,
+        override var unread: Int?,
+        override var error: String? = null,
+        override var icon: String? = null
+        ) : Source
+
+    @Serializable
+    data class SourceDetail(
+        override val id: Int,
+        override var title: String,
+        override var unread: Int? = null,
        @Serializable(with = TagsListSerializer::class)
-        val tags: List<String>,
-        val spout: String,
-        val error: String,
-        val icon: String?,
-        val params: SourceParams?
-    )
+        var tags: List<String>?,
+        var spout: String?,
+        override var error: String?,
+        override var icon: String?,
+        var params: SourceParams?
+    ) : Source
+
    @Serializable
    data class SourceParams(
-        val url: String?
+        val url: String? = null
    )
    @Serializable
    data class Item(
--- a/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt
+++ b/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/repository/RepositoryImpl.kt
@@ -44,11 +44,11 @@ class Repository(
    private val _badgeStarred = MutableStateFlow(0)
    val badgeStarred = _badgeStarred.asStateFlow()

-    private var fetchedSources = false
    private var fetchedTags = false
+    private var fetchedSources = false

    private var _readerItems = ArrayList<SelfossModel.Item>()
-    private var _selectedSource: SelfossModel.Source? = null
+    private var _selectedSource: SelfossModel.SourceDetail? = null

    suspend fun getNewerItems(): ArrayList<SelfossModel.Item> {
        var fetchedItems: StatusAndData<List<SelfossModel.Item>> = StatusAndData.error()
@@ -132,9 +132,9 @@ class Repository(
        if (isNetworkAvailable()) {
            val response = api.stats()
            if (response.success && response.data != null) {
-                _badgeUnread.value = response.data.unread
+                _badgeUnread.value = response.data.unread ?: 0
                _badgeAll.value = response.data.total
-                _badgeStarred.value = response.data.starred
+                _badgeStarred.value = response.data.starred ?: 0
                success = true
            }
        } else if (appSettingsService.isItemCachingEnabled()) {
@@ -180,23 +180,46 @@ class Repository(
        }
    }

-    suspend fun getSources(): ArrayList<SelfossModel.Source> {
+    suspend fun getSourcesDetailsOrStats(): ArrayList<SelfossModel.Source> {
+        var sources = ArrayList<SelfossModel.Source>()
        val isDatabaseEnabled =
            appSettingsService.isItemCachingEnabled() || !appSettingsService.isUpdateSourcesEnabled()
-        return if (isNetworkAvailable() && !fetchedSources) {
-            val apiSources = api.sources()
-            if (apiSources.success && apiSources.data != null && isDatabaseEnabled) {
-                resetDBSourcesWithData(apiSources.data)
-                if (!appSettingsService.isUpdateSourcesEnabled()) {
+        val shouldFetch = if (!appSettingsService.isUpdateSourcesEnabled()) !fetchedSources else true
+        if (shouldFetch && isNetworkAvailable()) {
+            if (appSettingsService.getPublicAccess()) {
+                val apiSources = api.sourcesStats()
+                if (apiSources.success && apiSources.data != null) {
                    fetchedSources = true
+                    sources = apiSources.data as ArrayList<SelfossModel.Source>
+                }
+            } else {
+                sources = getSourcesDetails() as ArrayList<SelfossModel.Source>
+            }
+        } else if (isDatabaseEnabled) {
+            sources = getDBSources().map { it.toView() } as ArrayList<SelfossModel.Source>
+        }
+
+        return sources
+    }
+
+    suspend fun getSourcesDetails(): ArrayList<SelfossModel.SourceDetail> {
+        var sources = ArrayList<SelfossModel.SourceDetail>()
+        val isDatabaseEnabled =
+            appSettingsService.isItemCachingEnabled() || !appSettingsService.isUpdateSourcesEnabled()
+        val shouldFetch = if (!appSettingsService.isUpdateSourcesEnabled()) !fetchedSources else true
+        if (shouldFetch && isNetworkAvailable()) {
+            val apiSources = api.sourcesDetailed()
+            if (apiSources.success && apiSources.data != null) {
+                fetchedSources = true
+                sources = apiSources.data
+                if (isDatabaseEnabled) {
+                    resetDBSourcesWithData(sources)
                }
            }
-            apiSources.data ?: ArrayList()
        } else if (isDatabaseEnabled) {
-            ArrayList(getDBSources().map { it.toView() })
-        } else {
-            ArrayList()
+            sources = getDBSources().map { it.toView() } as ArrayList<SelfossModel.SourceDetail>
        }
+        return sources
    }

    suspend fun markAsRead(item: SelfossModel.Item): Boolean {
@@ -482,7 +505,7 @@ class Repository(
        }
    }

-    private fun resetDBSourcesWithData(sources: List<SelfossModel.Source>) {
+    private fun resetDBSourcesWithData(sources: List<SelfossModel.SourceDetail>) {
        db.sourcesQueries.deleteAllSources()

        db.sourcesQueries.transaction {
@@ -592,7 +615,7 @@ class Repository(
        ReaderForSelfossDB.Schema.migrate(driverFactory.createDriver(), 0, 1)
    }

-    fun setSelectedSource(source: SelfossModel.Source) {
+    fun setSelectedSource(source: SelfossModel.SourceDetail) {
        _selectedSource = source
    }

@@ -600,7 +623,7 @@ class Repository(
        _selectedSource = null
    }

-    fun getSelectedSource(): SelfossModel.Source? {
+    fun getSelectedSource(): SelfossModel.SourceDetail? {
        return _selectedSource
    }
 }
--- a/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/rest/SelfossApi.kt
+++ b/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/rest/SelfossApi.kt
@@ -183,7 +183,15 @@ class SelfossApi(private val appSettingsService: AppSettingsService) {
            }
        })

-    suspend fun sources(): StatusAndData<ArrayList<SelfossModel.Source>> =
+    suspend fun sourcesStats(): StatusAndData<ArrayList<SelfossModel.SourceStats>> =
+        bodyOrFailure(client.tryToGet(url("/sources/stats")) {
+            if (!shouldHavePostLogin()) {
+                parameter("username", appSettingsService.getUserName())
+                parameter("password", appSettingsService.getPassword())
+            }
+        })
+
+    suspend fun sourcesDetailed(): StatusAndData<ArrayList<SelfossModel.SourceDetail>> =
        bodyOrFailure(client.tryToGet(url("/sources/list")) {
            if (!shouldHavePostLogin()) {
                parameter("username", appSettingsService.getUserName())
--- a/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/utils/EntityUtils.kt
+++ b/shared/src/commonMain/kotlin/bou/amine/apps/readerforselfossv2/utils/EntityUtils.kt
@@ -12,24 +12,25 @@ fun TAG.toView(): SelfossModel.Tag =
        this.unread.toInt()
    )

-fun SOURCE.toView(): SelfossModel.Source =
-    SelfossModel.Source(
+fun SOURCE.toView(): SelfossModel.SourceDetail =
+    SelfossModel.SourceDetail(
        this.id.toInt(),
        this.title,
-        this.tags.split(","),
+        null,
+        this.tags?.split(","),
        this.spout,
        this.error,
        this.icon,
-        SelfossModel.SourceParams(this.url)
+        if (this.url != null) SelfossModel.SourceParams(this.url) else null
    )

-fun SelfossModel.Source.toEntity(): SOURCE =
+fun SelfossModel.SourceDetail.toEntity(): SOURCE =
    SOURCE(
        this.id.toString(),
        this.title.getHtmlDecoded(),
-        this.tags.joinToString(","),
-        this.spout,
-        this.error,
+        this.tags?.joinToString(",").orEmpty(),
+        this.spout.orEmpty(),
+        this.error.orEmpty(),
        this.icon.orEmpty(),
        this.params?.url
    )
Author	SHA1	Message	Date
Amine Louveau	5cfec50cba	fix: 'Enable Core Library Desugaring to support older Android versions' (#138 ) from davidoskky/ReaderForSelfoss-multiplatform:desugaring into master All checks were successful continuous-integration/drone/push Build is passing Details continuous-integration/drone Build is passing Details Reviewed-on: https://gitea.amine-louveau.fr/Louvorg/ReaderForSelfoss-multiplatform/pulls/138	2023-04-12 18:26:37 +00:00
davidoskky	76ad71e1dc	Enable Core Library Desugaring to support older Android versions Some checks failed continuous-integration/drone/pr Build is failing Details	2023-04-12 16:29:47 +02:00
davidoskky	0277fb507c	Changelog for v123030851 [CI SKIP]	2023-03-26 18:21:43 +00:00
davidoskky	8d7d3174aa	chore: replace textDrawable library (#136 ) All checks were successful continuous-integration/drone/push Build is passing Details continuous-integration/drone Build is passing Details ## Types of changes - [x] I have read the CONTRIBUTING document. - [x] My code follows the code style of this project. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [x] All new and existing tests passed. - [x] This is NOT translation related. This closes issue #120 Removed the dependency `com.amulyakhare.textdrawable` and slightly simplified the logic required to set circular images. Co-authored-by: davidoskky <davidoskky@yahoo.it> Reviewed-on: https://gitea.amine-louveau.fr/Louvorg/ReaderForSelfoss-multiplatform/pulls/136 Co-authored-by: davidoskky <davidoskky@hidden.hidden> Co-committed-by: davidoskky <davidoskky@hidden.hidden>	2023-03-26 11:12:01 +00:00
aminecmi	00eb3333fe	refactor: Remove slow login check. Closes #135 . All checks were successful continuous-integration/drone/push Build is passing Details	2023-03-25 20:28:30 +01:00
aminecmi	629ca01d99	ci: send the mapping file after a release. All checks were successful continuous-integration/drone/push Build is passing Details	2023-03-17 10:10:38 +01:00
aminecmi	c2d8681ce8	Changelog for v123030751 [CI SKIP]	2023-03-16 19:41:34 +00:00
aminecmi	08f79cb148	debug: added a lot to pinpoint the url issue. All checks were successful continuous-integration/drone/push Build is passing Details continuous-integration/drone Build is passing Details	2023-03-16 20:26:36 +01:00
davidoskky	e21906e70d	feat: Use /sources/stats in the home (#133 ) All checks were successful continuous-integration/drone/push Build is passing Details ## Types of changes - [x] I have read the CONTRIBUTING document. - [x] My code follows the code style of this project. - [ ] I have updated the documentation accordingly. - [x] I have added tests to cover my changes. - [x] All new and existing tests passed. - [x] This is NOT translation related. This is implements feature #131 and it will allow implementing #132 With this, public mode functions perfectly and also has source filtering. Co-authored-by: davidoskky <davidoskky@yahoo.it> Reviewed-on: https://gitea.amine-louveau.fr/Louvorg/ReaderForSelfoss-multiplatform/pulls/133 Co-authored-by: davidoskky <davidoskky@hidden.hidden> Co-committed-by: davidoskky <davidoskky@hidden.hidden>	2023-03-13 16:26:54 +00:00
aminecmi	9d2cc32bc9	Changelog for v123030681 [CI SKIP]	2023-03-09 20:27:08 +00:00
aminecmi	d9d057c8dc	fix: Unread and starred can be null. All checks were successful continuous-integration/drone/push Build is passing Details continuous-integration/drone Build is passing Details	2023-03-09 20:46:09 +01:00
aminecmi	1f3fa0c4a6	Fixed version number issue. Some checks failed continuous-integration/drone/push Build is failing Details	2023-03-05 21:02:03 +01:00
aminecmi	dea3def385	Changelog for v123030621 [CI SKIP]	2023-03-03 20:07:52 +00:00
aminecmi	f72ef2f5d4	fix: url required issue. All checks were successful continuous-integration/drone/push Build is passing Details continuous-integration/drone Build is passing Details	2023-03-03 20:39:33 +01:00
aminecmi	f28cb759df	fix: Canvas reused issue.	2023-03-03 20:39:20 +01:00