davidoskky
  • Joined on 2022-08-16
davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#81 2022-10-18 11:14:38 +00:00
Prevent crash when logging in

I could remove this from the init method and make a new public method which is called by the login activity after it checks that the user is correctly set.

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#81 2022-10-17 18:27:16 +00:00
Prevent crash when logging in

If the repository is initialized before the login, this is required to initialize the dateUtils after logging in

davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#81 2022-10-17 18:26:33 +00:00
Prevent crash when logging in

The repository is initialized before logging in, at that point appSettingsService returns an empty string

davidoskky created pull request Louvorg/ReaderForSelfoss-multiplatform#81 2022-10-17 17:38:22 +00:00
Prevent crash when logging in
davidoskky created branch login_crash in davidoskky/ReaderForSelfoss-multiplatform 2022-10-17 17:36:00 +00:00
davidoskky pushed to login_crash at davidoskky/ReaderForSelfoss-multiplatform 2022-10-17 17:36:00 +00:00
c25e8889a4 Prevent crash when logging in
davidoskky commented on issue Louvorg/ReaderForSelfoss-multiplatform#13 2022-10-17 12:42:35 +00:00
Close images swiping up or down

I'll be working on this.

davidoskky commented on issue Louvorg/ReaderForSelfoss-multiplatform#12 2022-10-17 11:41:25 +00:00
Dark images with transparent background

I guess the best way to handle this is to add a checkerboard background. That is how images with transparency are normally rendered, the checkerboard solves the problem both with dark images and…

davidoskky opened issue Louvorg/ReaderForSelfoss-multiplatform#80 2022-10-17 07:27:18 +00:00
No unread count for sources
davidoskky opened issue Louvorg/ReaderForSelfoss-multiplatform#79 2022-10-15 18:55:46 +00:00
Edit sources doesn't show all the sources
davidoskky commented on issue Louvorg/ReaderForSelfoss-multiplatform#78 2022-10-15 18:53:56 +00:00
ViewPager infinite loading

I think the best way to do this would be to make the items in the repository a flow and subscribe the home and the viewpager to such flow, so that the information is common among the two and we…

davidoskky commented on issue Louvorg/ReaderForSelfoss-multiplatform#15 2022-10-14 07:34:56 +00:00
Articles not removed after source removal

This is not happening in version 2 since items are updated each time you go to the home.

davidoskky pushed to master at davidoskky/ReaderForSelfoss-multiplatform 2022-10-14 07:23:17 +00:00
8b0bbe71c9 Merge pull request 'Allow offline filtering' (#75) from davidoskky/ReaderForSelfoss-multiplatform:offline_filters into master
8bfe14c019 Actually filter database items
208babbce3 Correct tests
02098a7aa9 Rearrange filtering steps
d0a982f385 Add tests for offline filtering
Compare 7 commits »
davidoskky deleted branch offline_filters from davidoskky/ReaderForSelfoss-multiplatform 2022-10-14 07:19:57 +00:00
davidoskky commented on pull request Louvorg/ReaderForSelfoss-multiplatform#75 2022-10-14 07:17:47 +00:00
Allow offline filtering

Right... I didn't write the tests correctly and assumed that worked...

davidoskky pushed to offline_filters at davidoskky/ReaderForSelfoss-multiplatform 2022-10-13 22:10:41 +00:00
8bfe14c019 Actually filter database items
208babbce3 Correct tests
Compare 2 commits »
davidoskky pushed to offline_filters at davidoskky/ReaderForSelfoss-multiplatform 2022-10-10 22:52:16 +00:00
02098a7aa9 Rearrange filtering steps
davidoskky commented on issue Louvorg/ReaderForSelfoss-multiplatform#77 2022-10-10 22:34:00 +00:00
Add support for item author

Also other spouts have an author field. I'm unsure how useful that is however, often in blogs the author is always the same...

davidoskky commented on issue Louvorg/ReaderForSelfoss-multiplatform#76 2022-10-10 22:31:58 +00:00
Provide indication when sources update failed

Yes, I had this idea by reading that field and the message therein contained. However, the message is rather verbose and can have different responses according to the specific error encountered. …

davidoskky commented on issue Louvorg/ReaderForSelfoss-multiplatform#77 2022-10-10 11:16:26 +00:00
Add support for item author

Would it be ok to add it below the source title in the article reader?