- France
- https://amine-bouabdallaoui.fr
- Joined on
2022-07-18
Ok, great ! I'll let you know when I finish my refactoring.
That makes sens, but I still thinks the app needs to refresh onReload.
We could try to find a way to differenciate between "going back from another activity of the app" and "relaunching the…
Every time I go back to the articles list the fetching starts, which is annoying because of the loading spinner appearing at the top each time.
Why don't you swipe between the articles ? …
When init is run the connectivity check always fails.
So this is a bug that should be fixed instead of having this workaround.
This allows retrieving the badges every time connectivity…
updateRemote doesn't necessarily have to be there, I have done it because I think it makes it easier to read through the activity code.
I find it more difficult to read. Moving some code…
it can be used to prevent making an api call every time you close an article and come back to the article list
this is intended to fetch the new articles as soon as possible.
Why were these moved here ?
I don't think that this should be here. Each activity/fragment should know what they want to display, and how.
I did a quick review, but as I'll clean some code, don't spend much time on this for now.
This way better !
The view/activity/fragment should be the one that knows when to display the refresh loading or not.
The view should call the repository and get the data from there.
Why did you remove this ?
I already started refactoring this, so I'll handle this.
resetDBSourcesWithData should only be done if network the api call was done, and if update_sources setting is set to false.
resetDBTagsWithData should only be done if network the api call was done, and if update_sources setting is set to false.
updateApiVersion() and reloadBadges() both check the network availability. This change isn't needed.
I already started refactoring this, so I'll handle this.
Thanks !