Amine Bouabdallaoui AmineB
0 Followers · 0 Following
Repositories
18
 Projects Packages Public Activity Starred Repositories
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2022-08-22 20:07:56 +00:00
afcc55e907 Urls.
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2022-08-22 20:04:59 +00:00
0c570efc47 Urls.
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2022-08-22 19:58:17 +00:00
a23a4cea0e Translation.
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2022-08-22 19:53:35 +00:00
78cb5d047f Translations.
AmineB merged pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-22 19:01:16 +00:00
network
AmineB pushed to master at Louvorg/ReaderForSelfoss-multiplatform 2022-08-22 19:01:16 +00:00
a9caaefb4d Merge pull request 'network' (#28) from davidoskky/ReaderForSelfoss-multiplatform:network into master
4c78b22614 Use the connectivity-status library from the repository rather than the local copy
1d5ab3205e Localize strings
df4903cae5 Include the connectivity status library as a aar file
2a78be69b5 Send toast messages at the application level and not on a per activity basis
Compare 29 commits »
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-22 18:49:53 +00:00
network

Great ! I'll test this and merge it.

AmineB suggested changes for Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-22 11:52:58 +00:00
network

The only remaining issue is the build problem because of the aar file.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-22 11:50:00 +00:00
network

Direct local .aar file dependencies are not supported when building an AAR. The resulting AAR would be broken because the classes and Android resources from any local .aar file dependencies…

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-21 20:07:26 +00:00
network

@davidoskky can you please rebase your branch, please ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-21 20:06:00 +00:00
network

I didn´t see that it was in the android side.

Yes, please use localized stringd.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-21 18:18:35 +00:00
network

Instead of adding the library code like this, could you maybe create a jar of the library and add it to the project ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-21 18:18:35 +00:00
network

Instead of doing this in every activity, can't it be done in the MyApp class ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-21 18:18:35 +00:00
network

It would be better to emit an enum. We'll handle the translation on the android/ios side.

AmineB suggested changes for Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-21 18:18:35 +00:00
network
AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-20 19:21:21 +00:00
network

@davidoskky it would be great to have the toast message displayed back on status change. Why was it removed ?

I have removed it because I figured it would be better to use a viewModel…

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-20 19:20:21 +00:00
network

Can you add a comment on top of the first function to mention this, please ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-20 18:44:02 +00:00
network

@davidoskky it would be great to have the toast message displayed back on status change. Why was it removed ?

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-20 18:38:15 +00:00
network

repository.offlineOverride should only refreshed on app reload or swipe to refresh.

AmineB commented on pull request Louvorg/ReaderForSelfoss-multiplatform#28 2022-08-20 18:38:15 +00:00
network

Is these functions needed ?