a1c0241a58
Show a confirmation dialog before deleting sources ( #185 )
...
Check master code / build (push) Successful in 15m3s
## Types of changes
- [ x ] I have read the **CONTRIBUTING** document.
- [ x ] My code follows the code style of this project.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [ x ] All new and existing tests passed.
- [ x ] This is **NOT** translation related.
This is implements feature #156
I added a confirmation dialogue which pops up after tapping the delete source button. The popup displays the full name of the source to be deleted and allows the user to decide not to delete the source to prevent erroneous deletions.
I moved most of the logic into the viewholder. Can be easily reverted if you prefer.
All tests pass. I tested correct behavior in emulated versions of android API 25, 34 and 35.
Co-authored-by: Amine <amine.bouabdallaoui@pm.me >
Reviewed-on: #185
Co-authored-by: davidoskky <davidoskky@yahoo.it >
Co-committed-by: davidoskky <davidoskky@yahoo.it >
2025-03-09 13:49:32 +00:00
davidoskky
3a33cb4510
Provide method to update items in the home
...
Removed in the previous commit, the item adapter accepts a method to update the articles list in the home page.
Renamed the method to make its objective more clear.
Removed a debugging log.
Reverted change to function name.
2024-11-20 01:28:47 +01:00
davidoskky
0bf9ca9a49
Fix recycleview article positions
...
The articles were being opened by setting a click listener on the binding.
In card view this was being done through a function and as such it used the overall viewbind of the view rather than the binding of the item viewholder.
Now the functions are more explicit to avoid future errors.
Pulled up a few members from ItemCardAdapter and ItemListAdapter to ItemAdapter.
2024-11-19 01:50:58 +01:00
davidoskky
056825aa0c
Revert xmlns changes
continuous-integration/drone/pr Build is passing
2023-09-17 12:01:32 +02:00
davidoskky
16b19fc5ce
Revert version upgrades
2023-09-17 11:59:08 +02:00
davidoskky
4ad4a23ed8
Revert to private functions
continuous-integration/drone/pr Build is failing
2023-09-12 00:38:37 +02:00
davidoskky
d8c215eacc
Reintroduce removed parameter
2023-09-12 00:36:56 +02:00
davidoskky
2b446ab22b
Revert dependency version changes
2023-09-12 00:36:04 +02:00
davidoskky
a029d8a7dc
Move api client creation function within api class
continuous-integration/drone/pr Build is passing
2023-09-10 21:33:28 +02:00
davidoskky
4482234e1a
Remove unused strings file
continuous-integration/drone/pr Build is passing
2023-09-10 21:15:04 +02:00
davidoskky
b5de30f561
Add translations
2023-09-10 21:14:43 +02:00
davidoskky
70ad5f322c
Handle most HTTP client creation in common code
2023-09-10 21:14:43 +02:00
davidoskky
d167092c83
Add a login switch to disable SSL verification
2023-09-10 20:24:22 +02:00
davidoskky
c4f4bafe85
Add a switch in the login screen to disable SSL
2023-07-13 14:55:48 +02:00
davidoskky
ed06b22a77
Tentative self signed ssl support
2023-07-13 14:55:48 +02:00
davidoskky
76ad71e1dc
Enable Core Library Desugaring to support older Android versions
continuous-integration/drone/pr Build is failing
2023-04-12 16:29:47 +02:00
davidoskky
389a04d250
Complete the disconnection before redirecting to the login screen
2023-01-27 14:21:33 +01:00
davidoskky
2245565f95
Remove unnecessary definition
2023-01-25 21:25:32 +01:00
davidoskky
014858f06b
Remove unused import
2023-01-25 20:40:20 +01:00
davidoskky
3f1f86a78e
Adjust the image closing animation
2023-01-25 10:34:03 +01:00
davidoskky
a549169a7c
Add a dark hue to the underlying article when swiping to close images
2023-01-25 10:27:38 +01:00
davidoskky
be7cae365a
Rename activity style to avoid interferences
2023-01-25 02:09:41 +01:00
davidoskky
cef3b2e593
Adapt the style of the image activity to the rest of the application
2023-01-25 01:54:35 +01:00
davidoskky
ae927ebc57
Resolve issues when swiping down to close images
2023-01-25 00:46:43 +01:00
davidoskky
ddc72d85b0
Close the image fragment only if the image has been dragged down
2023-01-21 16:37:25 +01:00
davidoskky
68bbf5b2d3
Animate swipe down to close images
2023-01-20 16:36:52 +01:00
davidoskky
2b6659f4ec
Swipe down to close images
2023-01-11 22:28:14 +01:00
davidoskky
e51915d1cd
Include author field when updating the database
continuous-integration/drone/pr Build is passing
2022-12-28 14:25:56 +01:00
davidoskky
3a654f6ede
Migrate the database table
2022-12-28 14:25:34 +01:00
davidoskky
5227751dca
Make the author field nullable
continuous-integration/drone/pr Build is passing
2022-12-28 11:02:43 +01:00
davidoskky
dbe97f564e
Revert imageview changes
continuous-integration/drone/pr Build is passing
2022-11-11 09:40:36 +01:00
davidoskky
c09a32e9ad
Add checkerboard background to the images in the image view
...
continuous-integration/drone/pr Build is passing
A checkerboard is drawn beneath the image in the imageview to allow
a simpler viewing of images with transparency
2022-11-09 16:39:00 +01:00
davidoskky
b02a588dff
Add a checkerboard background drawable
2022-11-09 16:34:37 +01:00
davidoskky
4b63afe62a
Update badges tests
continuous-integration/drone/pr Build is passing
2022-11-01 21:51:46 +01:00
davidoskky
02d734eee8
Do not edit the repository items from outside the repository
continuous-integration/drone/pr Build is running
2022-11-01 21:29:04 +01:00
davidoskky
c5cdfc0d53
Update bottom bar badges through a state flow
2022-11-01 21:28:14 +01:00
davidoskky
6d610ed61a
Fix repeating items in recyclerview
continuous-integration/drone/pr Build is passing
2022-11-01 19:53:22 +01:00
davidoskky
792950be7c
Remove unreachable condition
2022-11-01 19:52:43 +01:00
davidoskky
667e9c1a5d
Adjust tests to changes in the repository
continuous-integration/drone/pr Build is passing
2022-10-21 22:56:35 +02:00
davidoskky
53b1d1f8b2
Rework repository initialization
2022-10-21 22:42:32 +02:00
davidoskky
c25e8889a4
Prevent crash when logging in
continuous-integration/drone/pr Build was killed
2022-10-17 19:35:52 +02:00
davidoskky
8bfe14c019
Actually filter database items
continuous-integration/drone/pr Build is passing
2022-10-14 00:10:35 +02:00
davidoskky
208babbce3
Correct tests
2022-10-14 00:03:20 +02:00
davidoskky
02098a7aa9
Rearrange filtering steps
continuous-integration/drone/pr Build is passing
2022-10-11 00:52:12 +02:00
davidoskky
d0a982f385
Add tests for offline filtering
continuous-integration/drone/pr Build is passing
2022-10-08 17:15:41 +02:00
davidoskky
1d1c121aab
Filter items from database according to tag and source
2022-10-08 17:15:22 +02:00
davidoskky
fe12819163
Correct database source title
2022-10-08 17:14:12 +02:00
davidoskky
1d2e5069b8
Avoid double snackbar generation
continuous-integration/drone/pr Build is passing
2022-10-04 16:47:13 +02:00
davidoskky
a147646743
Correct mechanism of mark and unmark snackbars
continuous-integration/drone/pr Build is running
2022-10-04 16:43:21 +02:00
davidoskky
32e7fc0038
Correct boolean serialization
continuous-integration/drone/pr Build is passing
2022-10-04 15:01:22 +02:00
davidoskky
c15bf44032
Adjust repository tests
continuous-integration/drone/pr Build is passing
2022-10-02 01:01:39 +02:00
davidoskky
0bcd55bd4e
Add translated strings
continuous-integration/drone/pr Build is failing
2022-10-01 22:51:09 +02:00
davidoskky
ebef0b3511
Start monitoring connectivity status when the repository is initiated.
continuous-integration/drone/pr Build is running
2022-10-01 22:43:48 +02:00
davidoskky
713ceb05bf
Remove unnecessary data class
continuous-integration/drone/pr Build is failing
2022-09-30 15:07:17 +02:00
davidoskky
dc8381b661
Add missing string
2022-09-30 15:00:25 +02:00
davidoskky
b5b820c64b
Remove database access from the Home
2022-09-30 15:00:01 +02:00
davidoskky
f7055626d9
Start monitoring the connectivity before loading the Repository
2022-09-30 14:56:10 +02:00
davidoskky
22da30eaa8
Remove unnecessary call to api
continuous-integration/drone/pr Build is passing
2022-09-30 13:17:40 +02:00
davidoskky
79fd115f5e
Only return new cached items
2022-09-30 13:16:42 +02:00
davidoskky
8dc3d319cd
Cleanup
continuous-integration/drone/pr Build is failing
2022-09-30 11:59:08 +02:00
davidoskky
27bb056397
Cleanup
continuous-integration/drone/pr Build is running
2022-09-30 11:49:31 +02:00
davidoskky
f9ba13dc32
Always cache images in background
continuous-integration/drone/pr Build is passing
2022-09-30 11:23:43 +02:00
davidoskky
6f60ef4346
Remove unnecessary return value
continuous-integration/drone/pr Build is failing
2022-09-30 09:11:55 +02:00
davidoskky
a9c7ec3dc1
Cache items in background without filtering
continuous-integration/drone/pr Build is passing
2022-09-30 01:19:28 +02:00
davidoskky
920d4ac1ef
Correctly implement disabling sources update
2022-09-29 19:37:33 +02:00
davidoskky
0e96d313ec
Add tags parameters explicitly
2022-09-29 19:09:09 +02:00
davidoskky
7211fdb1a3
Fix update remote tests
2022-09-29 18:58:00 +02:00
davidoskky
d311c2cdeb
Fix sources tests
2022-09-28 18:45:21 +02:00
davidoskky
219cae5d74
Fix tags tests
2022-09-28 18:22:06 +02:00
davidoskky
2968aee309
Fix badges tests
2022-09-28 09:43:28 +02:00
davidoskky
6cb4b35c93
Introduce useful assertions in repository instantiation tests
2022-09-28 09:14:47 +02:00
davidoskky
4781e30da2
Remove unnecessary safe calls
continuous-integration/drone/pr Build is passing
2022-09-27 23:44:42 +02:00
davidoskky
c8759cc035
Fix tags tests
continuous-integration/drone/pr Build is running
2022-09-27 23:37:30 +02:00
davidoskky
cb4f2f02ef
Fix repository.tags() returning null
2022-09-27 23:26:44 +02:00
davidoskky
7517626ab7
Include database return definition within test function
2022-09-27 23:25:47 +02:00
davidoskky
41c951b659
Add test cases for repository instantiation cases
continuous-integration/drone/pr Build is passing
2022-09-27 23:16:30 +02:00
davidoskky
e2afff0b8e
Add comment
continuous-integration/drone/pr Build is passing
2022-09-26 23:19:31 +02:00
davidoskky
a382fc89ea
Test item caching
continuous-integration/drone/pr Build is running
2022-09-26 23:11:26 +02:00
davidoskky
3f0a3903ae
Test refresh login information
continuous-integration/drone/pr Build is passing
2022-09-26 22:50:55 +02:00
davidoskky
f46f98cef0
Test login
continuous-integration/drone/pr Build is running
2022-09-26 22:46:37 +02:00
davidoskky
bf6f1a917e
Test update remote
continuous-integration/drone/pr Build is running
2022-09-26 22:42:24 +02:00
davidoskky
71c0a4d340
Test delete source
continuous-integration/drone/pr Build is passing
2022-09-26 22:26:01 +02:00
davidoskky
63c550ead3
Test create source
continuous-integration/drone/pr Build is running
2022-09-26 22:21:48 +02:00
davidoskky
366b2e10f1
Adjust tests to changes in the data models
continuous-integration/drone/pr Build is passing
2022-09-25 22:02:25 +02:00
davidoskky
d2436bb976
Merge branch 'master' into repository_tests
...
# Conflicts:
# .drone.yml
2022-09-25 20:24:46 +02:00
davidoskky
ef994460c1
get sources tests
continuous-integration/drone/pr Build is failing
2022-09-18 18:14:14 +02:00
davidoskky
758708e18d
Tags tests
continuous-integration/drone/pr Build is failing
2022-09-17 22:04:24 +02:00
davidoskky
c0381144d1
Add CI test step
continuous-integration/drone/pr Build is failing
2022-09-17 21:29:37 +02:00
davidoskky
cda3ba6cb4
Test badge fetching
continuous-integration/drone/pr Build is passing
2022-09-16 12:04:05 +02:00
davidoskky
a4636cc0c8
Add item fetching tests
continuous-integration/drone/pr Build is passing
2022-09-15 14:07:50 +02:00
davidoskky
60c24fc75a
Check that the api is being used rather than the db
continuous-integration/drone/pr Build is passing
2022-09-10 09:37:14 +02:00
davidoskky
5853a19937
Normal items fetch test
continuous-integration/drone/pr Build is passing
2022-09-10 09:08:26 +02:00
davidoskky
99f2c04bf6
Initial testing setup
continuous-integration/drone/pr Build is passing
2022-09-09 13:43:53 +02:00
davidoskky
bdc77ab8ef
Remove unused lambda
continuous-integration/drone/pr Build is passing
continuous-integration/drone/tag Build is passing
2022-09-06 12:36:37 +02:00
davidoskky
6bd06cb458
Correctly handle the back button in settings
continuous-integration/drone/pr Build is running
2022-09-06 12:28:31 +02:00
davidoskky
e281751bb0
Fetch api version on login
continuous-integration/drone/pr Build is passing
2022-08-24 23:26:49 +02:00
davidoskky
4c78b22614
Use the connectivity-status library from the repository rather than the local copy
continuous-integration/drone/pr Build is failing
2022-08-22 19:33:58 +02:00
davidoskky
1d5ab3205e
Localize strings
continuous-integration/drone/pr Build is failing
2022-08-21 23:34:47 +02:00
davidoskky
df4903cae5
Include the connectivity status library as a aar file
2022-08-21 23:34:47 +02:00
davidoskky
2a78be69b5
Send toast messages at the application level and not on a per activity basis
2022-08-21 23:34:45 +02:00
