Compare commits
	
		
			46 Commits
		
	
	
		
			v125010201
			...
			c14ae9588f
		
	
	| Author | SHA1 | Date | |
|---|---|---|---|
| c14ae9588f | |||
| 1b2e9edc8c | |||
| 7c65a63315 | |||
| 02d503e03a | |||
| 24b9320d6d | |||
| ceba58e98f | |||
| c3ee07dd85 | |||
| 93d99192b3 | |||
| 
						 | 
					359dec2ca0 | ||
| 62354ec70a | |||
| 18a17251ac | |||
| 5e91724ee2 | |||
| 212d259a33 | |||
| 3bf60f1146 | |||
| 
						 | 
					ef13e300f0 | ||
| f170d1157d | |||
| af4752f0f0 | |||
| f0fa1a17b6 | |||
| bb84d1541c | |||
| c9227b2c1c | |||
| 6eaad0c7c5 | |||
| a1c98aa7d0 | |||
| d5ec118679 | |||
| a1c0241a58 | |||
| 
						 | 
					f38936f9b4 | ||
| a90ccec707 | |||
| 
						 | 
					2564b19726 | ||
| 61c7bb20cc | |||
| 6a0f5baf0a | |||
| 39f9505c00 | |||
| 6a6d447456 | |||
| 
						 | 
					0bb4fe6aed | ||
| 7df4c3368c | |||
| c69635b5ae | |||
| 3a829df70e | |||
| 7a0202689f | |||
| b20f6888f5 | |||
| 6b96eb358d | |||
| dfc1bf9fa3 | |||
| 
						 | 
					b173664ff0 | ||
| bc20a421ae | |||
| 794500355a | |||
| 44f9dd53d3 | |||
| 717d6b664c | |||
| e23289a3dc | |||
| 
						 | 
					2f5ebe2420 | 
							
								
								
									
										10
									
								
								.gitea/workflows/assets/crowdin.yml
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										10
									
								
								.gitea/workflows/assets/crowdin.yml
									
									
									
									
									
										Normal file
									
								
							@@ -0,0 +1,10 @@
 | 
			
		||||
project_id_env: CROWDIN_PROJECT_ID
 | 
			
		||||
api_token_env: CROWDIN_PERSONAL_TOKEN
 | 
			
		||||
base_path: "../../../"
 | 
			
		||||
 | 
			
		||||
files:
 | 
			
		||||
  - source: /androidApp/src/main/res/values/strings.xml
 | 
			
		||||
    translation: /androidApp/src/main/res/values-%android_code%/%original_file_name%
 | 
			
		||||
    translate_attributes: '0'
 | 
			
		||||
    content_segmentation: '0'
 | 
			
		||||
preserve_hierarchy: true
 | 
			
		||||
@@ -10,36 +10,52 @@ jobs:
 | 
			
		||||
        uses: actions/checkout@v4
 | 
			
		||||
        with:
 | 
			
		||||
          fetch-depth: 0
 | 
			
		||||
      - name: "Check android app changes"
 | 
			
		||||
        id: check-android-changes
 | 
			
		||||
        uses: tj-actions/changed-files@v45
 | 
			
		||||
        with:
 | 
			
		||||
          files: |
 | 
			
		||||
            androidApp/src/**
 | 
			
		||||
      - name: Fetch tags
 | 
			
		||||
        if: steps.check-android-changes.outputs.any_modified == 'true'
 | 
			
		||||
        run: git fetch --tags -p
 | 
			
		||||
      - uses: actions/setup-java@v4
 | 
			
		||||
        if: steps.check-android-changes.outputs.any_modified == 'true'
 | 
			
		||||
        with:
 | 
			
		||||
          distribution: 'temurin'
 | 
			
		||||
          java-version: '17'
 | 
			
		||||
          cache: gradle
 | 
			
		||||
      - uses: gradle/actions/setup-gradle@v3
 | 
			
		||||
        if: steps.check-android-changes.outputs.any_modified == 'true'
 | 
			
		||||
      - uses: android-actions/setup-android@v3
 | 
			
		||||
        if: steps.check-android-changes.outputs.any_modified == 'true'
 | 
			
		||||
      - name: Configure gradle...
 | 
			
		||||
        if: steps.check-android-changes.outputs.any_modified == 'true'
 | 
			
		||||
        run: mkdir -p ~/.gradle && echo "org.gradle.daemon=false\nignoreGitVersion=true" >> ~/.gradle/gradle.properties
 | 
			
		||||
      - name: Build and test
 | 
			
		||||
        if: steps.check-android-changes.outputs.any_modified == 'true'
 | 
			
		||||
        run: ./gradlew build -x testReleaseUnitTest -x testDebugUnitTest -x testGithubConfigReleaseUnitTest -x testGithubConfigDebugUnitTest # These tests will be done
 | 
			
		||||
      - uses: KengoTODA/actions-setup-docker-compose@v1
 | 
			
		||||
        with:
 | 
			
		||||
          version: "2.23.3"
 | 
			
		||||
      - name: run selfoss
 | 
			
		||||
        run: |
 | 
			
		||||
          docker compose -f .gitea/workflows/assets/docker-compose.yml up -d
 | 
			
		||||
      # TESTS ARE RUN LOCALLY
 | 
			
		||||
      #      - uses: KengoTODA/actions-setup-docker-compose@v1
 | 
			
		||||
      #        with:
 | 
			
		||||
      #          version: "2.23.3"
 | 
			
		||||
      #      - name: run selfoss
 | 
			
		||||
      #        run: |
 | 
			
		||||
      #          docker compose -f .gitea/workflows/assets/docker-compose.yml up -d
 | 
			
		||||
      - name: coverage
 | 
			
		||||
        if: steps.check-android-changes.outputs.any_modified == 'true'
 | 
			
		||||
        run: |
 | 
			
		||||
          ./gradlew :koverHtmlReport
 | 
			
		||||
      - uses: actions/upload-artifact@v3
 | 
			
		||||
        if: steps.check-android-changes.outputs.any_modified == 'true'
 | 
			
		||||
        with:
 | 
			
		||||
          name: coverage
 | 
			
		||||
          path: build/reports/kover/html
 | 
			
		||||
          retention-days: 1
 | 
			
		||||
          overwrite: true
 | 
			
		||||
          include-hidden-files: true
 | 
			
		||||
      - name: Clean
 | 
			
		||||
        if: always()
 | 
			
		||||
        run: |
 | 
			
		||||
          docker compose -f .gitea/workflows/assets/docker-compose.yml stop
 | 
			
		||||
#      TESTS ARE RUN LOCALLY
 | 
			
		||||
#      - name: Clean
 | 
			
		||||
#        if: always()
 | 
			
		||||
#        run: |
 | 
			
		||||
#          docker compose -f .gitea/workflows/assets/docker-compose.yml stop
 | 
			
		||||
 
 | 
			
		||||
							
								
								
									
										65
									
								
								.gitea/workflows/common_coverage.yml
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										65
									
								
								.gitea/workflows/common_coverage.yml
									
									
									
									
									
										Normal file
									
								
							@@ -0,0 +1,65 @@
 | 
			
		||||
name: Coverage
 | 
			
		||||
on:
 | 
			
		||||
  workflow_call:
 | 
			
		||||
 | 
			
		||||
jobs:
 | 
			
		||||
  BuildAndTestAndCoverage:
 | 
			
		||||
    runs-on: ubuntu-latest
 | 
			
		||||
    steps:
 | 
			
		||||
      - name: Check out repository code
 | 
			
		||||
        uses: actions/checkout@v4
 | 
			
		||||
        with:
 | 
			
		||||
          fetch-depth: 0
 | 
			
		||||
      - name: Fetch tags
 | 
			
		||||
        run: git fetch --tags -p
 | 
			
		||||
      - uses: actions/setup-java@v4
 | 
			
		||||
        with:
 | 
			
		||||
          distribution: 'temurin'
 | 
			
		||||
          java-version: '17'
 | 
			
		||||
          cache: gradle
 | 
			
		||||
      - uses: gradle/actions/setup-gradle@v3
 | 
			
		||||
      - uses: android-actions/setup-android@v3
 | 
			
		||||
      - name: Configure gradle...
 | 
			
		||||
        run: mkdir -p ~/.gradle && echo "ignoreGitVersion=true" >> ~/.gradle/gradle.properties
 | 
			
		||||
      - uses: KengoTODA/actions-setup-docker-compose@v1
 | 
			
		||||
        with:
 | 
			
		||||
          version: "2.23.3"
 | 
			
		||||
      - name: run selfoss
 | 
			
		||||
        run: |
 | 
			
		||||
          docker compose -f .gitea/workflows/assets/docker-compose.yml up -d
 | 
			
		||||
      - name: Set env url
 | 
			
		||||
        run: |
 | 
			
		||||
          export SELFOSS_URL=172.17.0.1:8888
 | 
			
		||||
      # https://github.com/ReactiveCircus/android-emulator-runner/issues/385
 | 
			
		||||
      - name: Kill crashpad_handler processes
 | 
			
		||||
        if: always()
 | 
			
		||||
        run: |
 | 
			
		||||
          pkill -SIGTERM crashpad_handler || true
 | 
			
		||||
          sleep 5
 | 
			
		||||
          pkill -SIGKILL crashpad_handler || true
 | 
			
		||||
      - name: Tests
 | 
			
		||||
        uses: reactivecircus/android-emulator-runner@v2
 | 
			
		||||
        with:
 | 
			
		||||
          api-level: 29
 | 
			
		||||
          script: |
 | 
			
		||||
            ./gradlew androidApp:connectedAndroidTest
 | 
			
		||||
            killall -INT crashpad_handler || true
 | 
			
		||||
      - uses: actions/upload-artifact@v3
 | 
			
		||||
        if: failure()
 | 
			
		||||
        with:
 | 
			
		||||
          name: failure-espresso
 | 
			
		||||
          path: build/reports/androidTests/connected/screenshots
 | 
			
		||||
          retention-days: 2
 | 
			
		||||
          overwrite: true
 | 
			
		||||
          include-hidden-files: true
 | 
			
		||||
      - uses: actions/upload-artifact@v3
 | 
			
		||||
        with:
 | 
			
		||||
          name: coverage-espresso
 | 
			
		||||
          path: build/reports/coverage/androidTest/githubConfig/debug/connected
 | 
			
		||||
          retention-days: 1
 | 
			
		||||
          overwrite: true
 | 
			
		||||
          include-hidden-files: true
 | 
			
		||||
      - name: Clean
 | 
			
		||||
        if: always()
 | 
			
		||||
        run: |
 | 
			
		||||
          docker compose -f .gitea/workflows/assets/docker-compose.yml stop
 | 
			
		||||
@@ -16,6 +16,7 @@ jobs:
 | 
			
		||||
        uses: actions/checkout@v4
 | 
			
		||||
        with:
 | 
			
		||||
          fetch-depth: 0
 | 
			
		||||
          ref: master
 | 
			
		||||
      - name: Config git
 | 
			
		||||
        run: |
 | 
			
		||||
          git config --global user.email aminecmi+giteadrone@pm.me
 | 
			
		||||
@@ -50,7 +51,7 @@ jobs:
 | 
			
		||||
          followtags: true
 | 
			
		||||
          ssh_key: ${{ secrets.PRIVATE_KEY }}
 | 
			
		||||
          tags: true
 | 
			
		||||
          branch: release
 | 
			
		||||
          branch: master
 | 
			
		||||
      - name: copy file via ssh password
 | 
			
		||||
        uses: appleboy/scp-action@v0.1.7
 | 
			
		||||
        with:
 | 
			
		||||
@@ -124,4 +125,4 @@ jobs:
 | 
			
		||||
          priority: high
 | 
			
		||||
          convert_markdown: true
 | 
			
		||||
          body: Nouveau fichier de mapping pour la version ${{ steps.version.outputs.VERSION }}
 | 
			
		||||
          attachments: androidApp/build/outputs/mapping/githubConfigRelease/mapping.txt
 | 
			
		||||
          attachments: androidApp/build/outputs/mapping/githubConfigRelease/mapping.txt
 | 
			
		||||
 
 | 
			
		||||
@@ -5,24 +5,152 @@ on:
 | 
			
		||||
      - master
 | 
			
		||||
 | 
			
		||||
jobs:
 | 
			
		||||
  Lint:
 | 
			
		||||
  BuildAndTestAndCoverage:
 | 
			
		||||
    runs-on: ubuntu-latest
 | 
			
		||||
    steps:
 | 
			
		||||
      - name: Check out repository code
 | 
			
		||||
        uses: actions/checkout@v4
 | 
			
		||||
        with:
 | 
			
		||||
          fetch-depth: 0
 | 
			
		||||
      - name: Fetch tags
 | 
			
		||||
        run: git fetch --tags -p
 | 
			
		||||
      - uses: actions/setup-java@v4
 | 
			
		||||
        with:
 | 
			
		||||
          distribution: 'temurin'
 | 
			
		||||
          java-version: '17'
 | 
			
		||||
          cache: gradle
 | 
			
		||||
      - name: Install klint
 | 
			
		||||
        run: curl -sSLO https://github.com/pinterest/ktlint/releases/download/1.5.0/ktlint && chmod a+x ktlint && mv ktlint /usr/local/bin/
 | 
			
		||||
      - name: Install detekt
 | 
			
		||||
        run: curl -sSLO https://github.com/detekt/detekt/releases/download/v1.23.7/detekt-cli-1.23.7.zip && unzip detekt-cli-1.23.7.zip
 | 
			
		||||
      - name: Linting...
 | 
			
		||||
        run: ktlint 'shared/**/*.kt' 'androidApp/**/*.kt' '!shared/build'
 | 
			
		||||
      - name: Detecting...
 | 
			
		||||
        run: ./detekt-cli-1.23.7/bin/detekt-cli -c detekt.yml --excludes '**/shared/build/**/*.kt'
 | 
			
		||||
  build:
 | 
			
		||||
    needs: Lint
 | 
			
		||||
    uses: ./.gitea/workflows/common_build.yml
 | 
			
		||||
      - uses: gradle/actions/setup-gradle@v3
 | 
			
		||||
      - uses: android-actions/setup-android@v3
 | 
			
		||||
      - name: Configure gradle...
 | 
			
		||||
        run: mkdir -p ~/.gradle && echo "ignoreGitVersion=true" >> ~/.gradle/gradle.properties
 | 
			
		||||
      - uses: KengoTODA/actions-setup-docker-compose@v1
 | 
			
		||||
        with:
 | 
			
		||||
          version: "2.23.3"
 | 
			
		||||
      - name: run selfoss
 | 
			
		||||
        run: |
 | 
			
		||||
          docker compose -f .gitea/workflows/assets/docker-compose.yml up -d
 | 
			
		||||
      - name: Change url until I find a better way to do it
 | 
			
		||||
        run: |
 | 
			
		||||
          sed -i "s/val defaultUrl = \"http:\/\/10\.0\.2\.2\:8888\"/val defaultUrl = \"http:\/\/172\.17\.0\.1\:8888\"/g" ./androidApp/src/androidTest/kotlin/bou/amine/apps/readerforselfossv2/android/CommonTests.kt
 | 
			
		||||
      - name: Tests
 | 
			
		||||
        uses: reactivecircus/android-emulator-runner@v2
 | 
			
		||||
        with:
 | 
			
		||||
          api-level: 35
 | 
			
		||||
          profile: pixel_7a
 | 
			
		||||
          script: |
 | 
			
		||||
            ./gradlew androidApp:clearScreenshotsTask || true
 | 
			
		||||
            ./gradlew androidApp:createScreenshotDirectory
 | 
			
		||||
            adb logcat -G 16M
 | 
			
		||||
            ./gradlew JacocoDebugCodeCoverage || true
 | 
			
		||||
            ./gradlew androidApp:fetchScreenshots
 | 
			
		||||
            adb logcat 'InputReader:S' 'chatty:S' 'audio_hw_generic:S' 'LogApiCalls:D' '*:I' -d > ./androidApp/build/reports/androidTests/connected/screenshots/logs.txt
 | 
			
		||||
      - uses: actions/upload-artifact@v3
 | 
			
		||||
        if: always()
 | 
			
		||||
        with:
 | 
			
		||||
          name: screenshot-espresso
 | 
			
		||||
          path: androidApp/build/reports/androidTests/connected/screenshots
 | 
			
		||||
          retention-days: 2
 | 
			
		||||
          overwrite: true
 | 
			
		||||
          include-hidden-files: true
 | 
			
		||||
      - uses: actions/upload-artifact@v3
 | 
			
		||||
        if: always()
 | 
			
		||||
        with:
 | 
			
		||||
          name: result-espresso
 | 
			
		||||
          path: androidApp/build/reports/androidTests/connected/debug/flavors/githubConfig
 | 
			
		||||
          retention-days: 1
 | 
			
		||||
          overwrite: true
 | 
			
		||||
          include-hidden-files: true
 | 
			
		||||
      - uses: actions/upload-artifact@v3
 | 
			
		||||
        with:
 | 
			
		||||
          name: coverage-espresso
 | 
			
		||||
          path: androidApp/build/reports/jacoco/JacocoDebugCodeCoverage
 | 
			
		||||
          retention-days: 1
 | 
			
		||||
          overwrite: true
 | 
			
		||||
          include-hidden-files: true
 | 
			
		||||
      - name: Clean
 | 
			
		||||
        if: always()
 | 
			
		||||
        run: |
 | 
			
		||||
          docker compose -f .gitea/workflows/assets/docker-compose.yml stop
 | 
			
		||||
 | 
			
		||||
#  Lint:
 | 
			
		||||
#    runs-on: ubuntu-latest
 | 
			
		||||
#    steps:
 | 
			
		||||
#      - name: Check out repository code
 | 
			
		||||
#        uses: actions/checkout@v4
 | 
			
		||||
#      - uses: actions/setup-java@v4
 | 
			
		||||
#        with:
 | 
			
		||||
#          distribution: 'temurin'
 | 
			
		||||
#          java-version: '17'
 | 
			
		||||
#          cache: gradle
 | 
			
		||||
#      - name: Install klint
 | 
			
		||||
#        run: curl -sSLO https://github.com/pinterest/ktlint/releases/download/1.5.0/ktlint && chmod a+x ktlint && mv ktlint /usr/local/bin/
 | 
			
		||||
#      - name: Install detekt
 | 
			
		||||
#        run: curl -sSLO https://github.com/detekt/detekt/releases/download/v1.23.7/detekt-cli-1.23.7.zip && unzip detekt-cli-1.23.7.zip
 | 
			
		||||
#      - name: Linting...
 | 
			
		||||
#        run: ktlint 'shared/**/*.kt' 'androidApp/**/*.kt' '!shared/build'
 | 
			
		||||
#      - name: Detecting...
 | 
			
		||||
#        run: ./detekt-cli-1.23.7/bin/detekt-cli -c detekt.yml --excludes '**/shared/build/**/*.kt'
 | 
			
		||||
#  translations:
 | 
			
		||||
#    runs-on: ubuntu-latest
 | 
			
		||||
#    steps:
 | 
			
		||||
#      - name: Check out repository code
 | 
			
		||||
#        uses: actions/checkout@v4
 | 
			
		||||
#        with:
 | 
			
		||||
#          fetch-depth: 0
 | 
			
		||||
#      - name: "Check translations changes"
 | 
			
		||||
#        id: check-translations-changes
 | 
			
		||||
#        uses: tj-actions/changed-files@v45
 | 
			
		||||
#        with:
 | 
			
		||||
#          files: |
 | 
			
		||||
#            androidApp/src/main/res/values/strings.xml
 | 
			
		||||
#      - name: upload translation sources
 | 
			
		||||
#        if: steps.check-api-changes.outputs.any_modified == 'true'
 | 
			
		||||
#        uses: crowdin/github-action@v2
 | 
			
		||||
#        with:
 | 
			
		||||
#          config: './.gitea/workflows/assets/crowdin.yml'
 | 
			
		||||
#          upload_sources: true
 | 
			
		||||
#          upload_translations: false
 | 
			
		||||
#          download_translations: false
 | 
			
		||||
#          create_pull_request: false
 | 
			
		||||
#          push_translations: false
 | 
			
		||||
#        env:
 | 
			
		||||
#          CROWDIN_PROJECT_ID: ${{ secrets.CROWDIN_PROJECT_ID }}
 | 
			
		||||
#          CROWDIN_PERSONAL_TOKEN: ${{ secrets.CROWDIN_PERSONAL_TOKEN }}
 | 
			
		||||
#      - name: wait
 | 
			
		||||
#        if: steps.check-api-changes.outputs.any_modified == 'true'
 | 
			
		||||
#        run: sleep 10s
 | 
			
		||||
#      - name: download translations
 | 
			
		||||
#        if: steps.check-api-changes.outputs.any_modified == 'true'
 | 
			
		||||
#        uses: crowdin/github-action@v2
 | 
			
		||||
#        with:
 | 
			
		||||
#          config: './.gitea/workflows/assets/crowdin.yml'
 | 
			
		||||
#          upload_sources: false
 | 
			
		||||
#          upload_translations: false
 | 
			
		||||
#          download_translations: true
 | 
			
		||||
#          create_pull_request: false
 | 
			
		||||
#          push_translations: false
 | 
			
		||||
#        env:
 | 
			
		||||
#          CROWDIN_PROJECT_ID: ${{ secrets.CROWDIN_PROJECT_ID }}
 | 
			
		||||
#          CROWDIN_PERSONAL_TOKEN: ${{ secrets.CROWDIN_PERSONAL_TOKEN }}
 | 
			
		||||
#      - name: Check for uncommitted changes
 | 
			
		||||
#        if: steps.check-api-changes.outputs.any_modified == 'true'
 | 
			
		||||
#        id: check-changes
 | 
			
		||||
#        uses: mskri/check-uncommitted-changes-action@v1.0.1
 | 
			
		||||
#      - name: Commit Changes
 | 
			
		||||
#        if: steps.check-api-changes.outputs.any_modified == 'true' && steps.check-changes.outputs.changes != ''
 | 
			
		||||
#        run: |
 | 
			
		||||
#          git config --global user.email aminecmi+giteadrone@pm.me
 | 
			
		||||
#          git config --global user.name giteadrone
 | 
			
		||||
#          git add ./androidApp/src/main/res/*
 | 
			
		||||
#          git commit -m "translation: translation files"
 | 
			
		||||
#      - name: Push changes
 | 
			
		||||
#        if: steps.check-api-changes.outputs.any_modified == 'true' && steps.check-changes.outputs.changes != ''
 | 
			
		||||
#        uses: appleboy/git-push-action@v1.0.0
 | 
			
		||||
#        with:
 | 
			
		||||
#          author_name: giteadrone
 | 
			
		||||
#          author_email: aminecmi+giteadrone@pm.me
 | 
			
		||||
#          remote: ${{ secrets.REMOTE_URL }}
 | 
			
		||||
#          ssh_key: ${{ secrets.PRIVATE_KEY }}
 | 
			
		||||
#          branch: ${{ github.head_ref || github.ref_name }}
 | 
			
		||||
#  build:
 | 
			
		||||
#    needs: Lint
 | 
			
		||||
#    uses: ./.gitea/workflows/common_build.yml
 | 
			
		||||
 
 | 
			
		||||
							
								
								
									
										4
									
								
								.gitignore
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										4
									
								
								.gitignore
									
									
									
									
										vendored
									
									
								
							@@ -323,4 +323,6 @@ fabric.properties
 | 
			
		||||
crowdin.properties
 | 
			
		||||
 | 
			
		||||
.kotlin/
 | 
			
		||||
build-cache/
 | 
			
		||||
build-cache/
 | 
			
		||||
 | 
			
		||||
act
 | 
			
		||||
 
 | 
			
		||||
							
								
								
									
										73
									
								
								CHANGELOG.md
									
									
									
									
									
								
							
							
						
						
									
										73
									
								
								CHANGELOG.md
									
									
									
									
									
								
							@@ -1,3 +1,76 @@
 | 
			
		||||
**v125030711
 | 
			
		||||
 | 
			
		||||
- Merge pull request 'fix: initial status loading issues.' (#192) from connectivity into master
 | 
			
		||||
- chore: check changes for translations and android.
 | 
			
		||||
- fix: initial status loading issues.
 | 
			
		||||
- Merge pull request 'chore: new connectivity dep. Closes #84.' (#189) from connectivity into master
 | 
			
		||||
- chore: new connectivity dep. Closes #84.
 | 
			
		||||
- Changelog for v125030681
 | 
			
		||||
 | 
			
		||||
--------------------------------------------------------------------
 | 
			
		||||
 | 
			
		||||
**v125030681
 | 
			
		||||
 | 
			
		||||
- chore: do not send reports on simulators.
 | 
			
		||||
- Merge pull request 'chore: do not send reports on simulators.' (#188) from chore-acra-simulator into master
 | 
			
		||||
- chore: do not send reports on simulators.
 | 
			
		||||
- Merge pull request 'fix: Url validation was not failing login. Added tests.' (#186) from fix-invalid-url into master
 | 
			
		||||
- Merge pull request 'chore: crowding ci integration.' (#187) from chore-crowdin-ci into master
 | 
			
		||||
- chore: we don't need to check if the url is valid in upsert screen.
 | 
			
		||||
- fix: Url validation was not failing login. Added tests.
 | 
			
		||||
- chore: crowding ci integration.
 | 
			
		||||
- Show a confirmation dialog before deleting sources (#185)
 | 
			
		||||
- Changelog for v125020581
 | 
			
		||||
 | 
			
		||||
--------------------------------------------------------------------
 | 
			
		||||
 | 
			
		||||
**v125020581
 | 
			
		||||
 | 
			
		||||
- fix: url can be empty ?
 | 
			
		||||
- Changelog for v125020471
 | 
			
		||||
 | 
			
		||||
--------------------------------------------------------------------
 | 
			
		||||
 | 
			
		||||
**v125020471
 | 
			
		||||
 | 
			
		||||
- chore: no more docker-compose.
 | 
			
		||||
- bump: gradle plugin.
 | 
			
		||||
- Merge pull request 'fix: check index exists.' (#183) from fix-index into master
 | 
			
		||||
- fix: check index exists.
 | 
			
		||||
- Changelog for v125020411
 | 
			
		||||
 | 
			
		||||
--------------------------------------------------------------------
 | 
			
		||||
 | 
			
		||||
**v125020411
 | 
			
		||||
 | 
			
		||||
- Merge pull request 'bump' (#182) from bump into master
 | 
			
		||||
- chore: non transiant R classes.
 | 
			
		||||
- Merge pull request 'fix: One more missing context.' (#181) from fix-one-more-context into master
 | 
			
		||||
- bump
 | 
			
		||||
- fix: One more missing context.
 | 
			
		||||
 | 
			
		||||
--------------------------------------------------------------------
 | 
			
		||||
 | 
			
		||||
**v125010241
 | 
			
		||||
 | 
			
		||||
- Merge pull request 'fix: Link not opening.' (#178) from fix-open-link into master
 | 
			
		||||
- refactor: context fragments issues.
 | 
			
		||||
- logs: Context issues.
 | 
			
		||||
- fix: Handle empty url issue, again.
 | 
			
		||||
- fix: Link not opening.
 | 
			
		||||
- Changelog for v125010201
 | 
			
		||||
 | 
			
		||||
--------------------------------------------------------------------
 | 
			
		||||
 | 
			
		||||
**v125010201
 | 
			
		||||
 | 
			
		||||
- fix: Handle empty url issue.
 | 
			
		||||
- Merge pull request 'Removed the floating bar.' (#177) from floating-bar into master
 | 
			
		||||
- chore: changing actions in reader fragment.
 | 
			
		||||
- Changelog for v125010131
 | 
			
		||||
 | 
			
		||||
--------------------------------------------------------------------
 | 
			
		||||
 | 
			
		||||
**v125010131
 | 
			
		||||
 | 
			
		||||
- fix: reload the adapter when it's needed. Fixes #128. (#176)
 | 
			
		||||
 
 | 
			
		||||
@@ -10,30 +10,41 @@ plugins {
 | 
			
		||||
    id("com.mikepenz.aboutlibraries.plugin")
 | 
			
		||||
    id("org.jetbrains.kotlinx.kover")
 | 
			
		||||
    id("app.cash.sqldelight") version "2.0.2"
 | 
			
		||||
    jacoco
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
fun Project.execWithOutput(cmd: String, ignore: Boolean = false): String {
 | 
			
		||||
    val result: String = ByteArrayOutputStream().use { outputStream ->
 | 
			
		||||
        project.exec {
 | 
			
		||||
            commandLine = cmd.split(" ")
 | 
			
		||||
            standardOutput = outputStream
 | 
			
		||||
            isIgnoreExitValue = ignore
 | 
			
		||||
fun Project.execWithOutput(
 | 
			
		||||
    cmd: String,
 | 
			
		||||
    ignore: Boolean = false,
 | 
			
		||||
): String {
 | 
			
		||||
    val result: String =
 | 
			
		||||
        ByteArrayOutputStream().use { outputStream ->
 | 
			
		||||
            project.exec {
 | 
			
		||||
                commandLine = cmd.split(" ")
 | 
			
		||||
                standardOutput = outputStream
 | 
			
		||||
                isIgnoreExitValue = ignore
 | 
			
		||||
            }
 | 
			
		||||
            outputStream.toString()
 | 
			
		||||
        }
 | 
			
		||||
        outputStream.toString()
 | 
			
		||||
    }
 | 
			
		||||
    return result
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
fun gitVersion(): String {
 | 
			
		||||
    val maybeTagOfCurrentCommit = execWithOutput("git -C ../ describe --contains HEAD", true)
 | 
			
		||||
    val process = if (maybeTagOfCurrentCommit.isEmpty()) {
 | 
			
		||||
        println("No tag on current commit. Will take the latest one.")
 | 
			
		||||
        execWithOutput("git -C ../ for-each-ref refs/tags --sort=-refname --format='%(refname:short)' --count=1")
 | 
			
		||||
    } else {
 | 
			
		||||
        println("Tag found on current commit")
 | 
			
		||||
        execWithOutput("git -C ../ describe --contains HEAD")
 | 
			
		||||
    }
 | 
			
		||||
    return process.replace("^0", "").replace("'", "").substring(1).replace("\\.", "").trim()
 | 
			
		||||
    val process =
 | 
			
		||||
        if (maybeTagOfCurrentCommit.isEmpty()) {
 | 
			
		||||
            println("No tag on current commit. Will take the latest one.")
 | 
			
		||||
            execWithOutput("git -C ../ for-each-ref refs/tags --sort=-refname --format='%(refname:short)' --count=1")
 | 
			
		||||
        } else {
 | 
			
		||||
            println("Tag found on current commit")
 | 
			
		||||
            execWithOutput("git -C ../ describe --contains HEAD")
 | 
			
		||||
        }
 | 
			
		||||
    return process
 | 
			
		||||
        .replace("^0", "")
 | 
			
		||||
        .replace("'", "")
 | 
			
		||||
        .substring(1)
 | 
			
		||||
        .replace("\\.", "")
 | 
			
		||||
        .trim()
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
fun versionCodeFromGit(): Int {
 | 
			
		||||
@@ -54,6 +65,15 @@ fun versionNameFromGit(): String {
 | 
			
		||||
    return gitVersion()
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
val exclusions =
 | 
			
		||||
    listOf(
 | 
			
		||||
        "**/R.class",
 | 
			
		||||
        "**/R\$*.class",
 | 
			
		||||
        "**/BuildConfig.*",
 | 
			
		||||
        "**/Manifest*.*",
 | 
			
		||||
        "**/*Test*.*",
 | 
			
		||||
    )
 | 
			
		||||
 | 
			
		||||
android {
 | 
			
		||||
    compileOptions {
 | 
			
		||||
        isCoreLibraryDesugaringEnabled = true
 | 
			
		||||
@@ -85,7 +105,7 @@ android {
 | 
			
		||||
 | 
			
		||||
        // tests
 | 
			
		||||
        testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
 | 
			
		||||
        testInstrumentationRunnerArguments["clearPackageData"] = "true"
 | 
			
		||||
        testInstrumentationRunnerArguments["useTestStorageService"] = "true"
 | 
			
		||||
    }
 | 
			
		||||
    packaging {
 | 
			
		||||
        resources {
 | 
			
		||||
@@ -99,6 +119,44 @@ android {
 | 
			
		||||
            proguardFiles(getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro")
 | 
			
		||||
        }
 | 
			
		||||
        getByName("debug") {
 | 
			
		||||
            isTestCoverageEnabled = true
 | 
			
		||||
            enableAndroidTestCoverage = true
 | 
			
		||||
            installation {
 | 
			
		||||
                installOptions("-g", "-r")
 | 
			
		||||
            }
 | 
			
		||||
 | 
			
		||||
            val androidTests = "connectedAndroidTest"
 | 
			
		||||
            tasks.register<JacocoReport>("JacocoDebugCodeCoverage") {
 | 
			
		||||
                // Depend on unit tests and Android tests tasks
 | 
			
		||||
                dependsOn(listOf(androidTests))
 | 
			
		||||
                // Set task grouping and description
 | 
			
		||||
                group = "Reporting"
 | 
			
		||||
                description = "Execute UI and unit tests, generate and combine Jacoco coverage report"
 | 
			
		||||
                // Configure reports to generate both XML and HTML formats
 | 
			
		||||
                reports {
 | 
			
		||||
                    xml.required.set(true)
 | 
			
		||||
                    html.required.set(true)
 | 
			
		||||
                }
 | 
			
		||||
                // Set source directories to the main source directory
 | 
			
		||||
                sourceDirectories.setFrom(layout.projectDirectory.dir("src/main"))
 | 
			
		||||
                // Set class directories to compiled Java and Kotlin classes, excluding specified exclusions
 | 
			
		||||
                classDirectories.setFrom(
 | 
			
		||||
                    files(
 | 
			
		||||
                        fileTree(layout.buildDirectory.dir("intermediates/javac/")) {
 | 
			
		||||
                            exclude(exclusions)
 | 
			
		||||
                        },
 | 
			
		||||
                        fileTree(layout.buildDirectory.dir("tmp/kotlin-classes/")) {
 | 
			
		||||
                            exclude(exclusions)
 | 
			
		||||
                        },
 | 
			
		||||
                    ),
 | 
			
		||||
                )
 | 
			
		||||
                // Collect execution data from .exec and .ec files generated during test execution
 | 
			
		||||
                executionData.setFrom(
 | 
			
		||||
                    files(
 | 
			
		||||
                        fileTree(layout.buildDirectory) { include(listOf("**/*.exec", "**/*.ec")) },
 | 
			
		||||
                    ),
 | 
			
		||||
                )
 | 
			
		||||
            }
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
    flavorDimensions.add("build")
 | 
			
		||||
@@ -111,12 +169,10 @@ android {
 | 
			
		||||
    namespace = "bou.amine.apps.readerforselfossv2.android"
 | 
			
		||||
    testOptions {
 | 
			
		||||
        animationsDisabled = true
 | 
			
		||||
        execution = "ANDROIDX_TEST_ORCHESTRATOR"
 | 
			
		||||
        unitTests {
 | 
			
		||||
            isIncludeAndroidResources = true
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
dependencies {
 | 
			
		||||
@@ -141,12 +197,12 @@ dependencies {
 | 
			
		||||
    implementation("androidx.constraintlayout:constraintlayout:2.2.0")
 | 
			
		||||
    implementation("org.jsoup:jsoup:1.18.3")
 | 
			
		||||
 | 
			
		||||
    //multidex
 | 
			
		||||
    // multidex
 | 
			
		||||
    implementation("androidx.multidex:multidex:2.0.1")
 | 
			
		||||
 | 
			
		||||
    // About
 | 
			
		||||
    implementation("com.mikepenz:aboutlibraries-core:10.5.1")
 | 
			
		||||
    implementation("com.mikepenz:aboutlibraries:10.5.1")
 | 
			
		||||
    implementation("com.mikepenz:aboutlibraries-core:11.6.3")
 | 
			
		||||
    implementation("com.mikepenz:aboutlibraries:11.6.3")
 | 
			
		||||
 | 
			
		||||
    // Material-ish things
 | 
			
		||||
    implementation("com.ashokvarma.android:bottom-navigation-bar:2.2.0")
 | 
			
		||||
@@ -162,43 +218,41 @@ dependencies {
 | 
			
		||||
    implementation("me.relex:circleindicator:2.1.6")
 | 
			
		||||
    implementation("androidx.viewpager2:viewpager2:1.1.0")
 | 
			
		||||
 | 
			
		||||
    //Dependency Injection
 | 
			
		||||
    // Dependency Injection
 | 
			
		||||
    implementation("org.kodein.di:kodein-di:7.23.1")
 | 
			
		||||
    implementation("org.kodein.di:kodein-di-framework-android-x:7.23.1")
 | 
			
		||||
    implementation("org.kodein.di:kodein-di-framework-android-x-viewmodel:7.23.1")
 | 
			
		||||
 | 
			
		||||
    //Settings
 | 
			
		||||
    // Settings
 | 
			
		||||
    implementation("com.russhwolf:multiplatform-settings-no-arg:1.3.0")
 | 
			
		||||
 | 
			
		||||
    //Logging
 | 
			
		||||
    // Logging
 | 
			
		||||
    implementation("io.github.aakira:napier:2.7.1")
 | 
			
		||||
 | 
			
		||||
    //PhotoView
 | 
			
		||||
    // PhotoView
 | 
			
		||||
    implementation("com.github.chrisbanes:PhotoView:2.3.0")
 | 
			
		||||
 | 
			
		||||
    implementation("androidx.core:core-ktx:1.15.0")
 | 
			
		||||
 | 
			
		||||
    implementation("androidx.lifecycle:lifecycle-extensions:2.2.0")
 | 
			
		||||
 | 
			
		||||
    // Network information
 | 
			
		||||
    implementation("com.github.ln-12:multiplatform-connectivity-status:1.3.0")
 | 
			
		||||
 | 
			
		||||
    // SQLDELIGHT
 | 
			
		||||
    implementation("app.cash.sqldelight:android-driver:2.0.2")
 | 
			
		||||
 | 
			
		||||
    //test
 | 
			
		||||
    // test
 | 
			
		||||
    testImplementation("junit:junit:4.13.2")
 | 
			
		||||
    testImplementation("io.mockk:mockk:1.13.14")
 | 
			
		||||
    testImplementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.1")
 | 
			
		||||
    implementation("org.jetbrains.kotlinx:kotlinx-datetime:0.6.1")
 | 
			
		||||
    androidTestImplementation("androidx.test:runner:1.6.2")
 | 
			
		||||
    androidTestImplementation("androidx.test:rules:1.6.1")
 | 
			
		||||
    androidTestImplementation("androidx.test:runner:1.7.0-alpha01")
 | 
			
		||||
    androidTestImplementation("androidx.test:rules:1.7.0-alpha01")
 | 
			
		||||
    androidTestImplementation("androidx.test.espresso:espresso-core:3.6.1")
 | 
			
		||||
    implementation("androidx.test.espresso:espresso-idling-resource:3.6.1")
 | 
			
		||||
    androidTestImplementation("androidx.test.ext:junit-ktx:1.2.1")
 | 
			
		||||
    androidTestUtil("androidx.test:orchestrator:1.5.1")
 | 
			
		||||
    androidTestUtil("androidx.test.services:test-services:1.6.0-alpha02")
 | 
			
		||||
    testImplementation("org.robolectric:robolectric:4.14.1")
 | 
			
		||||
    testImplementation("androidx.test:core-ktx:1.6.1")
 | 
			
		||||
    testImplementation("androidx.test:core-ktx:1.7.0-alpha01")
 | 
			
		||||
    androidTestImplementation("androidx.test.uiautomator:uiautomator:2.3.0")
 | 
			
		||||
 | 
			
		||||
    implementation("ch.acra:acra-http:$acraVersion")
 | 
			
		||||
    implementation("ch.acra:acra-toast:$acraVersion")
 | 
			
		||||
@@ -210,16 +264,24 @@ tasks.withType<Test> {
 | 
			
		||||
    useJUnit()
 | 
			
		||||
    testLogging {
 | 
			
		||||
        exceptionFormat = org.gradle.api.tasks.testing.logging.TestExceptionFormat.FULL
 | 
			
		||||
        events = setOf(
 | 
			
		||||
            org.gradle.api.tasks.testing.logging.TestLogEvent.PASSED,
 | 
			
		||||
            org.gradle.api.tasks.testing.logging.TestLogEvent.FAILED,
 | 
			
		||||
            org.gradle.api.tasks.testing.logging.TestLogEvent.STANDARD_ERROR
 | 
			
		||||
        )
 | 
			
		||||
        events =
 | 
			
		||||
            setOf(
 | 
			
		||||
                org.gradle.api.tasks.testing.logging.TestLogEvent.PASSED,
 | 
			
		||||
                org.gradle.api.tasks.testing.logging.TestLogEvent.FAILED,
 | 
			
		||||
                org.gradle.api.tasks.testing.logging.TestLogEvent.STANDARD_ERROR,
 | 
			
		||||
            )
 | 
			
		||||
        showStandardStreams = true
 | 
			
		||||
    }
 | 
			
		||||
    if (this.name == "connectedAndroidTest") {
 | 
			
		||||
        configure<JacocoTaskExtension> {
 | 
			
		||||
            isIncludeNoLocationClasses = true
 | 
			
		||||
            excludes = listOf("jdk.internal.*")
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
aboutLibraries {
 | 
			
		||||
    excludeFields = arrayOf("generated")
 | 
			
		||||
    offlineMode = true
 | 
			
		||||
    fetchRemoteLicense = false
 | 
			
		||||
    fetchRemoteFunding = false
 | 
			
		||||
@@ -227,4 +289,31 @@ aboutLibraries {
 | 
			
		||||
    strictMode = com.mikepenz.aboutlibraries.plugin.StrictMode.FAIL
 | 
			
		||||
    duplicationMode = com.mikepenz.aboutlibraries.plugin.DuplicateMode.MERGE
 | 
			
		||||
    duplicationRule = com.mikepenz.aboutlibraries.plugin.DuplicateRule.GROUP
 | 
			
		||||
}
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
val clearScreenshotsTask =
 | 
			
		||||
    tasks.register<Exec>("clearScreenshots") {
 | 
			
		||||
        println("AMINE : clear")
 | 
			
		||||
        commandLine = listOf("adb", "shell", "rm", "-r", "/storage/emulated/0/Pictures/selfoss_tests/screenshots/*")
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
val createScreenshotDirectoryTask =
 | 
			
		||||
    tasks.register<Exec>("createScreenshotDirectory") {
 | 
			
		||||
        println("AMINE : create directory")
 | 
			
		||||
        group = "reporting"
 | 
			
		||||
        commandLine = listOf("adb", "shell", "mkdir", "-p", "/storage/emulated/0/Pictures/selfoss_tests/screenshots")
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
tasks.register<Exec>("fetchScreenshots") {
 | 
			
		||||
    val reportsDirectory = file("$buildDir/reports/androidTests/connected")
 | 
			
		||||
    println("AMINE : fetch")
 | 
			
		||||
    group = "reporting"
 | 
			
		||||
    executable(android.adbExecutable.toString())
 | 
			
		||||
    commandLine = listOf("adb", "pull", "/storage/emulated/0/Pictures/selfoss_tests/screenshots", reportsDirectory.toString())
 | 
			
		||||
 | 
			
		||||
    finalizedBy(clearScreenshotsTask)
 | 
			
		||||
 | 
			
		||||
    doFirst {
 | 
			
		||||
        reportsDirectory.mkdirs()
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
 
 | 
			
		||||
@@ -15,13 +15,17 @@ import androidx.test.filters.LargeTest
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.testing.CountingIdlingResourceSingleton
 | 
			
		||||
import org.junit.After
 | 
			
		||||
import org.junit.Before
 | 
			
		||||
import org.junit.FixMethodOrder
 | 
			
		||||
import org.junit.Rule
 | 
			
		||||
import org.junit.Test
 | 
			
		||||
import org.junit.runner.RunWith
 | 
			
		||||
import org.junit.runners.MethodSorters
 | 
			
		||||
 | 
			
		||||
@Suppress("ktlint:standard:class-naming", "detekt:ClassNaming")
 | 
			
		||||
@RunWith(AndroidJUnit4::class)
 | 
			
		||||
@FixMethodOrder(MethodSorters.NAME_ASCENDING)
 | 
			
		||||
@LargeTest
 | 
			
		||||
class LoginActivityTest {
 | 
			
		||||
class `1-LoginActivityTest` : WithANRException() {
 | 
			
		||||
    @get:Rule
 | 
			
		||||
    val activityRule = ActivityScenarioRule(LoginActivity::class.java)
 | 
			
		||||
 | 
			
		||||
@@ -40,7 +44,7 @@ class LoginActivityTest {
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    @Test
 | 
			
		||||
    fun viewIsInitialized() {
 | 
			
		||||
    fun `1-viewIsInitialized`() {
 | 
			
		||||
        onView(withId(R.id.urlView)).check(matches(isDisplayed()))
 | 
			
		||||
        onView(withId(R.id.selfSigned))
 | 
			
		||||
            .check(matches(isDisplayed()))
 | 
			
		||||
@@ -57,14 +61,27 @@ class LoginActivityTest {
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    @Test
 | 
			
		||||
    fun urlError() {
 | 
			
		||||
    fun `2-urlError`() {
 | 
			
		||||
        performLogin("10.0.2.2:8888")
 | 
			
		||||
        onView(withId(R.id.urlView)).perform(click())
 | 
			
		||||
        onView(withId(R.id.urlView)).check(matches(withError(R.string.login_url_problem)))
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    @Test
 | 
			
		||||
    fun `3-urlSlashError`() {
 | 
			
		||||
        performLogin("https://google.fr/toto")
 | 
			
		||||
        onView(withId(R.id.urlView)).perform(click())
 | 
			
		||||
        onView(withId(R.id.urlView)).check(matches(withError(R.string.login_url_problem)))
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    @Test
 | 
			
		||||
    fun `4-connectError`() {
 | 
			
		||||
        performLogin("http://10.0.2.2:8889")
 | 
			
		||||
        onView(withId(R.id.urlView)).check(matches(withError(R.string.wrong_infos)))
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    @Test
 | 
			
		||||
    fun multiError() {
 | 
			
		||||
    fun `5-multiError`() {
 | 
			
		||||
        onView(withId(R.id.signInButton)).perform(click())
 | 
			
		||||
        onView(withId(R.id.signInButton)).perform(click())
 | 
			
		||||
        onView(withId(R.id.signInButton)).perform(click())
 | 
			
		||||
@@ -72,8 +89,10 @@ class LoginActivityTest {
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    @Test
 | 
			
		||||
    fun connect() {
 | 
			
		||||
    fun `6-connect`() {
 | 
			
		||||
        performLogin()
 | 
			
		||||
        onView(withText(R.string.gdpr_dialog_title)).check(matches(isDisplayed()))
 | 
			
		||||
        onView(withText("OK")).perform(click())
 | 
			
		||||
        checkHomeLoadingDone()
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
@@ -1,6 +1,7 @@
 | 
			
		||||
package bou.amine.apps.readerforselfossv2.android
 | 
			
		||||
 | 
			
		||||
import androidx.test.espresso.Espresso.onView
 | 
			
		||||
import androidx.test.espresso.IdlingRegistry
 | 
			
		||||
import androidx.test.espresso.action.ViewActions
 | 
			
		||||
import androidx.test.espresso.action.ViewActions.click
 | 
			
		||||
import androidx.test.espresso.assertion.ViewAssertions.matches
 | 
			
		||||
@@ -14,21 +15,29 @@ import androidx.test.espresso.matcher.ViewMatchers.withText
 | 
			
		||||
import androidx.test.ext.junit.rules.ActivityScenarioRule
 | 
			
		||||
import androidx.test.ext.junit.runners.AndroidJUnit4
 | 
			
		||||
import androidx.test.filters.LargeTest
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.testing.CountingIdlingResourceSingleton
 | 
			
		||||
import org.hamcrest.CoreMatchers.not
 | 
			
		||||
import org.junit.Before
 | 
			
		||||
import org.junit.FixMethodOrder
 | 
			
		||||
import org.junit.Rule
 | 
			
		||||
import org.junit.Test
 | 
			
		||||
import org.junit.runner.RunWith
 | 
			
		||||
import org.junit.runners.MethodSorters
 | 
			
		||||
 | 
			
		||||
@Suppress("ktlint:standard:class-naming", "detekt:ClassNaming")
 | 
			
		||||
@RunWith(AndroidJUnit4::class)
 | 
			
		||||
@FixMethodOrder(MethodSorters.NAME_ASCENDING)
 | 
			
		||||
@LargeTest
 | 
			
		||||
class HomeActivityTest {
 | 
			
		||||
class `2-HomeActivityTest` : WithANRException() {
 | 
			
		||||
    @get:Rule
 | 
			
		||||
    val activityRule = ActivityScenarioRule(LoginActivity::class.java)
 | 
			
		||||
    val activityRule = ActivityScenarioRule(HomeActivity::class.java)
 | 
			
		||||
 | 
			
		||||
    @Before
 | 
			
		||||
    fun init() {
 | 
			
		||||
        loginAndInitHome()
 | 
			
		||||
    fun registerIdlingResource() {
 | 
			
		||||
        IdlingRegistry
 | 
			
		||||
            .getInstance()
 | 
			
		||||
            .register(CountingIdlingResourceSingleton.countingIdlingResource)
 | 
			
		||||
        checkHomeLoadingDone()
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    @Test
 | 
			
		||||
@@ -56,7 +65,7 @@ class HomeActivityTest {
 | 
			
		||||
    fun testMenuActions() {
 | 
			
		||||
        onView(withId(R.id.action_search)).perform(click())
 | 
			
		||||
        onView(
 | 
			
		||||
            withId(R.id.search_src_text),
 | 
			
		||||
            withId(com.google.android.material.R.id.search_src_text),
 | 
			
		||||
        ).check(matches(isFocused()))
 | 
			
		||||
        onView(isRoot()).perform(ViewActions.pressBack())
 | 
			
		||||
 | 
			
		||||
@@ -2,6 +2,7 @@ package bou.amine.apps.readerforselfossv2.android
 | 
			
		||||
 | 
			
		||||
import android.content.Context
 | 
			
		||||
import androidx.test.espresso.Espresso.onView
 | 
			
		||||
import androidx.test.espresso.IdlingRegistry
 | 
			
		||||
import androidx.test.espresso.action.ViewActions.click
 | 
			
		||||
import androidx.test.espresso.assertion.ViewAssertions.matches
 | 
			
		||||
import androidx.test.espresso.matcher.ViewMatchers.isDisplayed
 | 
			
		||||
@@ -10,6 +11,7 @@ import androidx.test.espresso.matcher.ViewMatchers.withText
 | 
			
		||||
import androidx.test.ext.junit.rules.ActivityScenarioRule
 | 
			
		||||
import androidx.test.ext.junit.runners.AndroidJUnit4
 | 
			
		||||
import androidx.test.filters.LargeTest
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.testing.CountingIdlingResourceSingleton
 | 
			
		||||
import org.hamcrest.CoreMatchers.allOf
 | 
			
		||||
import org.hamcrest.CoreMatchers.not
 | 
			
		||||
import org.junit.Before
 | 
			
		||||
@@ -19,9 +21,11 @@ import org.junit.runner.RunWith
 | 
			
		||||
 | 
			
		||||
@RunWith(AndroidJUnit4::class)
 | 
			
		||||
@LargeTest
 | 
			
		||||
class SettingsActivityTest {
 | 
			
		||||
@Suppress("ktlint:standard:class-naming", "detekt:ClassNaming")
 | 
			
		||||
class `3-SettingsActivityTest` : WithANRException() {
 | 
			
		||||
    @get:Rule
 | 
			
		||||
    val activityRule = ActivityScenarioRule(LoginActivity::class.java)
 | 
			
		||||
    val activityRule = ActivityScenarioRule(HomeActivity::class.java)
 | 
			
		||||
 | 
			
		||||
    lateinit var context: Context
 | 
			
		||||
 | 
			
		||||
    @Before
 | 
			
		||||
@@ -29,7 +33,9 @@ class SettingsActivityTest {
 | 
			
		||||
        activityRule.scenario.onActivity { activity ->
 | 
			
		||||
            context = activity.window.context
 | 
			
		||||
        }
 | 
			
		||||
        loginAndInitHome()
 | 
			
		||||
        IdlingRegistry
 | 
			
		||||
            .getInstance()
 | 
			
		||||
            .register(CountingIdlingResourceSingleton.countingIdlingResource)
 | 
			
		||||
        openMenu()
 | 
			
		||||
        onView(withText(R.string.title_activity_settings)).perform(click())
 | 
			
		||||
    }
 | 
			
		||||
@@ -68,6 +74,9 @@ class SettingsActivityTest {
 | 
			
		||||
        changeAndSaveSetting("", "10") {
 | 
			
		||||
            onView(withText(R.string.pref_api_timeout)).perform(click())
 | 
			
		||||
        }
 | 
			
		||||
        changeAndSaveSetting("", "60") {
 | 
			
		||||
            onView(withText(R.string.pref_api_timeout)).perform(click())
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    @Test
 | 
			
		||||
@@ -3,6 +3,7 @@ package bou.amine.apps.readerforselfossv2.android
 | 
			
		||||
import androidx.test.core.app.ApplicationProvider
 | 
			
		||||
import androidx.test.espresso.Espresso.onView
 | 
			
		||||
import androidx.test.espresso.Espresso.openActionBarOverflowOrOptionsMenu
 | 
			
		||||
import androidx.test.espresso.IdlingRegistry
 | 
			
		||||
import androidx.test.espresso.action.ViewActions
 | 
			
		||||
import androidx.test.espresso.action.ViewActions.click
 | 
			
		||||
import androidx.test.espresso.action.ViewActions.replaceText
 | 
			
		||||
@@ -19,22 +20,29 @@ import androidx.test.espresso.matcher.ViewMatchers.withText
 | 
			
		||||
import androidx.test.ext.junit.rules.ActivityScenarioRule
 | 
			
		||||
import androidx.test.ext.junit.runners.AndroidJUnit4
 | 
			
		||||
import androidx.test.filters.LargeTest
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.testing.CountingIdlingResourceSingleton
 | 
			
		||||
import org.hamcrest.CoreMatchers.allOf
 | 
			
		||||
import org.hamcrest.CoreMatchers.not
 | 
			
		||||
import org.junit.Before
 | 
			
		||||
import org.junit.FixMethodOrder
 | 
			
		||||
import org.junit.Rule
 | 
			
		||||
import org.junit.Test
 | 
			
		||||
import org.junit.runner.RunWith
 | 
			
		||||
import org.junit.runners.MethodSorters
 | 
			
		||||
 | 
			
		||||
@Suppress("ktlint:standard:class-naming", "detekt:ClassNaming")
 | 
			
		||||
@RunWith(AndroidJUnit4::class)
 | 
			
		||||
@FixMethodOrder(MethodSorters.NAME_ASCENDING)
 | 
			
		||||
@LargeTest
 | 
			
		||||
class SettingsActivityGeneralTest {
 | 
			
		||||
class `4-SettingsActivityGeneralTest` : WithANRException() {
 | 
			
		||||
    @get:Rule
 | 
			
		||||
    val activityRule = ActivityScenarioRule(LoginActivity::class.java)
 | 
			
		||||
    val activityRule = ActivityScenarioRule(HomeActivity::class.java)
 | 
			
		||||
 | 
			
		||||
    @Before
 | 
			
		||||
    fun init() {
 | 
			
		||||
        loginAndInitHome()
 | 
			
		||||
        IdlingRegistry
 | 
			
		||||
            .getInstance()
 | 
			
		||||
            .register(CountingIdlingResourceSingleton.countingIdlingResource)
 | 
			
		||||
        openActionBarOverflowOrOptionsMenu(
 | 
			
		||||
            ApplicationProvider.getApplicationContext(),
 | 
			
		||||
        )
 | 
			
		||||
@@ -1,29 +1,34 @@
 | 
			
		||||
package bou.amine.apps.readerforselfossv2.android
 | 
			
		||||
 | 
			
		||||
import android.content.Context
 | 
			
		||||
import androidx.test.core.app.ApplicationProvider
 | 
			
		||||
import androidx.test.espresso.Espresso.onView
 | 
			
		||||
import androidx.test.espresso.Espresso.openActionBarOverflowOrOptionsMenu
 | 
			
		||||
import androidx.test.espresso.IdlingRegistry
 | 
			
		||||
import androidx.test.espresso.action.ViewActions
 | 
			
		||||
import androidx.test.espresso.action.ViewActions.click
 | 
			
		||||
import androidx.test.espresso.assertion.ViewAssertions.matches
 | 
			
		||||
import androidx.test.espresso.matcher.ViewMatchers.isChecked
 | 
			
		||||
import androidx.test.espresso.matcher.ViewMatchers.isDisplayed
 | 
			
		||||
import androidx.test.espresso.matcher.ViewMatchers.isRoot
 | 
			
		||||
import androidx.test.espresso.matcher.ViewMatchers.withText
 | 
			
		||||
import androidx.test.ext.junit.rules.ActivityScenarioRule
 | 
			
		||||
import androidx.test.ext.junit.runners.AndroidJUnit4
 | 
			
		||||
import androidx.test.filters.LargeTest
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.settings.SettingsActivity
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.testing.CountingIdlingResourceSingleton
 | 
			
		||||
import org.hamcrest.CoreMatchers.allOf
 | 
			
		||||
import org.hamcrest.CoreMatchers.not
 | 
			
		||||
import org.junit.After
 | 
			
		||||
import org.junit.Before
 | 
			
		||||
import org.junit.Rule
 | 
			
		||||
import org.junit.Test
 | 
			
		||||
import org.junit.runner.RunWith
 | 
			
		||||
 | 
			
		||||
@Suppress("ktlint:standard:class-naming", "detekt:ClassNaming")
 | 
			
		||||
@RunWith(AndroidJUnit4::class)
 | 
			
		||||
@LargeTest
 | 
			
		||||
class SettingsActivityReaderTest {
 | 
			
		||||
class `5-SettingsActivityReaderTest` : WithANRException() {
 | 
			
		||||
    @get:Rule
 | 
			
		||||
    val activityRule = ActivityScenarioRule(LoginActivity::class.java)
 | 
			
		||||
    val activityRule = ActivityScenarioRule(SettingsActivity::class.java)
 | 
			
		||||
 | 
			
		||||
    lateinit var context: Context
 | 
			
		||||
 | 
			
		||||
@@ -32,14 +37,17 @@ class SettingsActivityReaderTest {
 | 
			
		||||
        activityRule.scenario.onActivity { activity ->
 | 
			
		||||
            context = activity.window.context
 | 
			
		||||
        }
 | 
			
		||||
        loginAndInitHome()
 | 
			
		||||
        openActionBarOverflowOrOptionsMenu(
 | 
			
		||||
            ApplicationProvider.getApplicationContext(),
 | 
			
		||||
        )
 | 
			
		||||
        onView(withText(R.string.title_activity_settings)).perform(click())
 | 
			
		||||
        IdlingRegistry
 | 
			
		||||
            .getInstance()
 | 
			
		||||
            .register(CountingIdlingResourceSingleton.countingIdlingResource)
 | 
			
		||||
        onView(withText(R.string.pref_header_viewer)).perform(click())
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    @After
 | 
			
		||||
    fun back() {
 | 
			
		||||
        onView(isRoot()).perform(ViewActions.pressBack())
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    @Test
 | 
			
		||||
    fun testReader() {
 | 
			
		||||
        onView(withSettingsCheckboxFrame(R.string.pref_switch_actions_pager_scroll)).check(
 | 
			
		||||
@@ -1,31 +1,36 @@
 | 
			
		||||
package bou.amine.apps.readerforselfossv2.android
 | 
			
		||||
 | 
			
		||||
import android.content.Context
 | 
			
		||||
import androidx.test.core.app.ApplicationProvider
 | 
			
		||||
import androidx.test.espresso.Espresso.onView
 | 
			
		||||
import androidx.test.espresso.Espresso.openActionBarOverflowOrOptionsMenu
 | 
			
		||||
import androidx.test.espresso.IdlingRegistry
 | 
			
		||||
import androidx.test.espresso.action.ViewActions
 | 
			
		||||
import androidx.test.espresso.action.ViewActions.click
 | 
			
		||||
import androidx.test.espresso.assertion.ViewAssertions.matches
 | 
			
		||||
import androidx.test.espresso.matcher.ViewMatchers.isChecked
 | 
			
		||||
import androidx.test.espresso.matcher.ViewMatchers.isDisplayed
 | 
			
		||||
import androidx.test.espresso.matcher.ViewMatchers.isEnabled
 | 
			
		||||
import androidx.test.espresso.matcher.ViewMatchers.isNotEnabled
 | 
			
		||||
import androidx.test.espresso.matcher.ViewMatchers.isRoot
 | 
			
		||||
import androidx.test.espresso.matcher.ViewMatchers.withText
 | 
			
		||||
import androidx.test.ext.junit.rules.ActivityScenarioRule
 | 
			
		||||
import androidx.test.ext.junit.runners.AndroidJUnit4
 | 
			
		||||
import androidx.test.filters.LargeTest
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.settings.SettingsActivity
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.testing.CountingIdlingResourceSingleton
 | 
			
		||||
import org.hamcrest.CoreMatchers.allOf
 | 
			
		||||
import org.hamcrest.CoreMatchers.not
 | 
			
		||||
import org.junit.After
 | 
			
		||||
import org.junit.Before
 | 
			
		||||
import org.junit.Rule
 | 
			
		||||
import org.junit.Test
 | 
			
		||||
import org.junit.runner.RunWith
 | 
			
		||||
 | 
			
		||||
@Suppress("ktlint:standard:class-naming", "detekt:ClassNaming")
 | 
			
		||||
@RunWith(AndroidJUnit4::class)
 | 
			
		||||
@LargeTest
 | 
			
		||||
class SettingsActivityOfflineTest {
 | 
			
		||||
class `6-SettingsActivityOfflineTest` : WithANRException() {
 | 
			
		||||
    @get:Rule
 | 
			
		||||
    val activityRule = ActivityScenarioRule(LoginActivity::class.java)
 | 
			
		||||
    val activityRule = ActivityScenarioRule(SettingsActivity::class.java)
 | 
			
		||||
 | 
			
		||||
    lateinit var context: Context
 | 
			
		||||
 | 
			
		||||
@@ -34,14 +39,17 @@ class SettingsActivityOfflineTest {
 | 
			
		||||
        activityRule.scenario.onActivity { activity ->
 | 
			
		||||
            context = activity.window.context
 | 
			
		||||
        }
 | 
			
		||||
        loginAndInitHome()
 | 
			
		||||
        openActionBarOverflowOrOptionsMenu(
 | 
			
		||||
            ApplicationProvider.getApplicationContext(),
 | 
			
		||||
        )
 | 
			
		||||
        onView(withText(R.string.title_activity_settings)).perform(click())
 | 
			
		||||
        IdlingRegistry
 | 
			
		||||
            .getInstance()
 | 
			
		||||
            .register(CountingIdlingResourceSingleton.countingIdlingResource)
 | 
			
		||||
        onView(withText(R.string.pref_header_offline)).perform(click())
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    @After
 | 
			
		||||
    fun back() {
 | 
			
		||||
        onView(isRoot()).perform(ViewActions.pressBack())
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    @Suppress("detekt:LongMethod")
 | 
			
		||||
    @Test
 | 
			
		||||
    fun testOffline() {
 | 
			
		||||
@@ -2,6 +2,7 @@ package bou.amine.apps.readerforselfossv2.android
 | 
			
		||||
 | 
			
		||||
import androidx.test.espresso.AmbiguousViewMatcherException
 | 
			
		||||
import androidx.test.espresso.Espresso.onView
 | 
			
		||||
import androidx.test.espresso.IdlingRegistry
 | 
			
		||||
import androidx.test.espresso.action.ViewActions
 | 
			
		||||
import androidx.test.espresso.action.ViewActions.click
 | 
			
		||||
import androidx.test.espresso.action.ViewActions.swipeDown
 | 
			
		||||
@@ -14,6 +15,7 @@ import androidx.test.espresso.matcher.ViewMatchers.withText
 | 
			
		||||
import androidx.test.ext.junit.rules.ActivityScenarioRule
 | 
			
		||||
import androidx.test.ext.junit.runners.AndroidJUnit4
 | 
			
		||||
import androidx.test.filters.LargeTest
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.testing.CountingIdlingResourceSingleton
 | 
			
		||||
import org.junit.After
 | 
			
		||||
import org.junit.Before
 | 
			
		||||
import org.junit.Rule
 | 
			
		||||
@@ -21,19 +23,22 @@ import org.junit.Test
 | 
			
		||||
import org.junit.runner.RunWith
 | 
			
		||||
import java.util.UUID
 | 
			
		||||
 | 
			
		||||
@Suppress("ktlint:standard:class-naming", "detekt:ClassNaming")
 | 
			
		||||
@RunWith(AndroidJUnit4::class)
 | 
			
		||||
@LargeTest
 | 
			
		||||
class SourcesActivityTest {
 | 
			
		||||
class `7-SourcesActivityTest` : WithANRException() {
 | 
			
		||||
    @get:Rule
 | 
			
		||||
    val activityRule = ActivityScenarioRule(LoginActivity::class.java)
 | 
			
		||||
    val activityRule = ActivityScenarioRule(HomeActivity::class.java)
 | 
			
		||||
 | 
			
		||||
    lateinit var sourceName: String
 | 
			
		||||
 | 
			
		||||
    @Before
 | 
			
		||||
    fun init() {
 | 
			
		||||
        IdlingRegistry
 | 
			
		||||
            .getInstance()
 | 
			
		||||
            .register(CountingIdlingResourceSingleton.countingIdlingResource)
 | 
			
		||||
        sourceName = UUID.randomUUID().toString().substring(0, 15)
 | 
			
		||||
 | 
			
		||||
        loginAndInitHome()
 | 
			
		||||
        goToSources()
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
@@ -71,12 +76,8 @@ class SourcesActivityTest {
 | 
			
		||||
    fun deleteTheCreatedSource() {
 | 
			
		||||
        onView(withText(sourceName)).check(matches(isDisplayed()))
 | 
			
		||||
        onView(withId(R.id.deleteBtn)).perform(click())
 | 
			
		||||
        onView(withText(R.string.confirm_delete_title)).check(matches(isDisplayed()))
 | 
			
		||||
        onView(withId(android.R.id.button1)).perform(click())
 | 
			
		||||
        onView(withText(sourceName)).check(doesNotExist())
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private fun goToSources() {
 | 
			
		||||
        openMenu()
 | 
			
		||||
        onView(withText(R.string.menu_home_sources))
 | 
			
		||||
            .perform(click())
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
@@ -1,7 +1,12 @@
 | 
			
		||||
package bou.amine.apps.readerforselfossv2.android
 | 
			
		||||
 | 
			
		||||
import android.content.Context
 | 
			
		||||
import android.graphics.Bitmap
 | 
			
		||||
import android.os.Environment.DIRECTORY_PICTURES
 | 
			
		||||
import android.os.Environment.getExternalStoragePublicDirectory
 | 
			
		||||
import android.util.Log
 | 
			
		||||
import androidx.annotation.ArrayRes
 | 
			
		||||
import androidx.test.espresso.Espresso
 | 
			
		||||
import androidx.test.espresso.Espresso.onData
 | 
			
		||||
import androidx.test.espresso.Espresso.onView
 | 
			
		||||
import androidx.test.espresso.action.ViewActions.click
 | 
			
		||||
@@ -9,29 +14,39 @@ import androidx.test.espresso.action.ViewActions.replaceText
 | 
			
		||||
import androidx.test.espresso.action.ViewActions.typeTextIntoFocusedView
 | 
			
		||||
import androidx.test.espresso.assertion.ViewAssertions.doesNotExist
 | 
			
		||||
import androidx.test.espresso.assertion.ViewAssertions.matches
 | 
			
		||||
import androidx.test.espresso.base.DefaultFailureHandler
 | 
			
		||||
import androidx.test.espresso.matcher.RootMatchers.isDialog
 | 
			
		||||
import androidx.test.espresso.matcher.ViewMatchers.isChecked
 | 
			
		||||
import androidx.test.espresso.matcher.ViewMatchers.isDisplayed
 | 
			
		||||
import androidx.test.espresso.matcher.ViewMatchers.isNotChecked
 | 
			
		||||
import androidx.test.espresso.matcher.ViewMatchers.withId
 | 
			
		||||
import androidx.test.espresso.matcher.ViewMatchers.withText
 | 
			
		||||
import androidx.test.platform.app.InstrumentationRegistry.getInstrumentation
 | 
			
		||||
import androidx.test.uiautomator.UiDevice
 | 
			
		||||
import androidx.test.uiautomator.UiSelector
 | 
			
		||||
import org.hamcrest.CoreMatchers.allOf
 | 
			
		||||
import org.hamcrest.CoreMatchers.not
 | 
			
		||||
import org.hamcrest.Matchers.hasToString
 | 
			
		||||
import org.junit.BeforeClass
 | 
			
		||||
import java.io.BufferedOutputStream
 | 
			
		||||
import java.io.File
 | 
			
		||||
import java.io.FileOutputStream
 | 
			
		||||
import java.io.IOException
 | 
			
		||||
import java.util.Locale
 | 
			
		||||
 | 
			
		||||
// For now, do not move this as it is modified by the integration tests
 | 
			
		||||
val defaultUrl = "http://10.0.2.2:8888"
 | 
			
		||||
 | 
			
		||||
fun performLogin(someUrl: String? = null) {
 | 
			
		||||
    Log.i("AUTOMATION", "The url used will be ${if (!someUrl.isNullOrEmpty()) someUrl else defaultUrl}")
 | 
			
		||||
    onView(withId(R.id.urlView)).perform(click()).perform(
 | 
			
		||||
        typeTextIntoFocusedView(
 | 
			
		||||
            if (!someUrl.isNullOrEmpty()) someUrl else "http://10.0.2.2:8888",
 | 
			
		||||
            if (!someUrl.isNullOrEmpty()) someUrl else defaultUrl,
 | 
			
		||||
        ),
 | 
			
		||||
    )
 | 
			
		||||
    onView(withId(R.id.signInButton)).perform(click())
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
fun loginAndInitHome() {
 | 
			
		||||
    performLogin()
 | 
			
		||||
    onView(withText(R.string.gdpr_dialog_title)).check(matches(isDisplayed()))
 | 
			
		||||
    onView(withText("OK")).perform(click())
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
fun changeAndCancelSetting(
 | 
			
		||||
    oldValue: String,
 | 
			
		||||
    newValue: String,
 | 
			
		||||
@@ -97,6 +112,12 @@ fun testPreferencesFromArray(
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
fun goToSources() {
 | 
			
		||||
    openMenu()
 | 
			
		||||
    onView(withText(R.string.menu_home_sources))
 | 
			
		||||
        .perform(click())
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
fun testAddSourceWithUrl(
 | 
			
		||||
    url: String,
 | 
			
		||||
    sourceName: String,
 | 
			
		||||
@@ -119,3 +140,92 @@ fun testAddSourceWithUrl(
 | 
			
		||||
        .perform(click())
 | 
			
		||||
    onView(withText(sourceName)).check(matches(isDisplayed()))
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
fun checkHomeLoadingDone() {
 | 
			
		||||
    onView(withId(R.id.swipeRefreshLayout)).inRoot(not(isDialog())).perform(waitUntilNotLoading(300000))
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
@Suppress("detekt:UtilityClassWithPublicConstructor")
 | 
			
		||||
open class WithANRException {
 | 
			
		||||
    companion object {
 | 
			
		||||
        // Running count of the number of Android Not Responding dialogues to prevent endless dismissal.
 | 
			
		||||
        private var anrCount = 0
 | 
			
		||||
 | 
			
		||||
        // `RootViewWithoutFocusException` class is private, need to match the message (instead of using type matching).
 | 
			
		||||
        private val rootViewWithoutFocusExceptionMsg =
 | 
			
		||||
            java.lang.String.format(
 | 
			
		||||
                Locale.ROOT,
 | 
			
		||||
                "Waited for the root of the view hierarchy to have " +
 | 
			
		||||
                    "window focus and not request layout for 10 seconds. If you specified a non " +
 | 
			
		||||
                    "default root matcher, it may be picking a root that never takes focus. " +
 | 
			
		||||
                    "Root:",
 | 
			
		||||
            )
 | 
			
		||||
        private val otherException = "System Ul isn't responding"
 | 
			
		||||
 | 
			
		||||
        private fun handleAnrDialogue() {
 | 
			
		||||
            val device = UiDevice.getInstance(getInstrumentation())
 | 
			
		||||
            // If running the device in English Locale
 | 
			
		||||
            val waitButton = device.findObject(UiSelector().textContains("wait"))
 | 
			
		||||
            if (waitButton.exists()) waitButton.click()
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        @JvmStatic
 | 
			
		||||
        @BeforeClass
 | 
			
		||||
        fun setUpHandler() {
 | 
			
		||||
            Espresso.setFailureHandler { error, viewMatcher ->
 | 
			
		||||
 | 
			
		||||
                takeScreenshot()
 | 
			
		||||
                if (error.message!!.contains(otherException)) {
 | 
			
		||||
                    handleAnrDialogue()
 | 
			
		||||
                } else if (error.message!!.contains(rootViewWithoutFocusExceptionMsg) &&
 | 
			
		||||
                    anrCount < 20
 | 
			
		||||
                ) {
 | 
			
		||||
                    anrCount++
 | 
			
		||||
                    handleAnrDialogue()
 | 
			
		||||
                } else { // chain all failures down to the default espresso handler
 | 
			
		||||
                    Log.e("AMINE", "AMINE : ${error.message}")
 | 
			
		||||
                    println("AMINE : ${error.message}")
 | 
			
		||||
                    DefaultFailureHandler(getInstrumentation().targetContext).handle(error, viewMatcher)
 | 
			
		||||
                }
 | 
			
		||||
            }
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
fun takeScreenshot() {
 | 
			
		||||
    try {
 | 
			
		||||
        val bitmap = getInstrumentation().uiAutomation.takeScreenshot()
 | 
			
		||||
 | 
			
		||||
        val folder =
 | 
			
		||||
            File(
 | 
			
		||||
                File(
 | 
			
		||||
                    getExternalStoragePublicDirectory(DIRECTORY_PICTURES),
 | 
			
		||||
                    "selfoss_tests",
 | 
			
		||||
                ).absolutePath,
 | 
			
		||||
                "screenshots",
 | 
			
		||||
            )
 | 
			
		||||
        if (!folder.exists()) {
 | 
			
		||||
            folder.mkdirs()
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        var out: BufferedOutputStream? = null
 | 
			
		||||
        val size = folder.list().size + 1
 | 
			
		||||
        try {
 | 
			
		||||
            out = BufferedOutputStream(FileOutputStream(folder.path + "/" + size + ".png"))
 | 
			
		||||
            bitmap.compress(Bitmap.CompressFormat.PNG, 100, out)
 | 
			
		||||
            Log.d("Screenshots", "Screenshot taken")
 | 
			
		||||
        } catch (e: IOException) {
 | 
			
		||||
            Log.e("Screenshots", "Could not save the screenshot", e)
 | 
			
		||||
        } finally {
 | 
			
		||||
            if (out != null) {
 | 
			
		||||
                try {
 | 
			
		||||
                    out.close()
 | 
			
		||||
                } catch (e: IOException) {
 | 
			
		||||
                    Log.e("Screenshots", "Could not save the screenshot", e)
 | 
			
		||||
                }
 | 
			
		||||
            }
 | 
			
		||||
        }
 | 
			
		||||
    } catch (ex: IOException) {
 | 
			
		||||
        Log.e("Screenshots", "Could not take the screenshot", ex)
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
 
 | 
			
		||||
@@ -8,9 +8,14 @@ import android.widget.RelativeLayout
 | 
			
		||||
import androidx.annotation.DrawableRes
 | 
			
		||||
import androidx.annotation.StringRes
 | 
			
		||||
import androidx.core.graphics.drawable.toBitmap
 | 
			
		||||
import androidx.core.view.isVisible
 | 
			
		||||
import androidx.swiperefreshlayout.widget.SwipeRefreshLayout
 | 
			
		||||
import androidx.test.core.app.ApplicationProvider
 | 
			
		||||
import androidx.test.espresso.Espresso.openActionBarOverflowOrOptionsMenu
 | 
			
		||||
import androidx.test.espresso.PerformException
 | 
			
		||||
import androidx.test.espresso.Root
 | 
			
		||||
import androidx.test.espresso.UiController
 | 
			
		||||
import androidx.test.espresso.ViewAction
 | 
			
		||||
import androidx.test.espresso.matcher.RootMatchers.isPlatformPopup
 | 
			
		||||
import androidx.test.espresso.matcher.ViewMatchers.hasSibling
 | 
			
		||||
import androidx.test.espresso.matcher.ViewMatchers.withChild
 | 
			
		||||
@@ -19,11 +24,15 @@ import androidx.test.espresso.matcher.ViewMatchers.withId
 | 
			
		||||
import androidx.test.espresso.matcher.ViewMatchers.withParent
 | 
			
		||||
import androidx.test.espresso.matcher.ViewMatchers.withResourceName
 | 
			
		||||
import androidx.test.espresso.matcher.ViewMatchers.withText
 | 
			
		||||
import androidx.test.espresso.util.HumanReadables
 | 
			
		||||
import androidx.test.espresso.util.TreeIterables
 | 
			
		||||
import org.hamcrest.CoreMatchers.allOf
 | 
			
		||||
import org.hamcrest.CoreMatchers.any
 | 
			
		||||
import org.hamcrest.Description
 | 
			
		||||
import org.hamcrest.Matcher
 | 
			
		||||
import org.hamcrest.Matchers
 | 
			
		||||
import org.hamcrest.TypeSafeMatcher
 | 
			
		||||
import java.util.concurrent.TimeoutException
 | 
			
		||||
 | 
			
		||||
fun withError(
 | 
			
		||||
    @StringRes id: Int,
 | 
			
		||||
@@ -44,6 +53,47 @@ fun withError(
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
fun waitUntilNotLoading(millis: Long): ViewAction {
 | 
			
		||||
    return object : ViewAction {
 | 
			
		||||
        override fun getConstraints(): Matcher<View> = any(View::class.java)
 | 
			
		||||
 | 
			
		||||
        override fun getDescription(): String = "wait for a specific view is not loading during $millis millis."
 | 
			
		||||
 | 
			
		||||
        override fun perform(
 | 
			
		||||
            uiController: UiController,
 | 
			
		||||
            view: View?,
 | 
			
		||||
        ) {
 | 
			
		||||
            uiController.loopMainThreadUntilIdle()
 | 
			
		||||
            val startTime = System.currentTimeMillis()
 | 
			
		||||
            val endTime = startTime + millis
 | 
			
		||||
 | 
			
		||||
            do {
 | 
			
		||||
                // either the empty view is displayed
 | 
			
		||||
                for (child in TreeIterables.breadthFirstViewTraversal(view)) {
 | 
			
		||||
                    // found view with required ID
 | 
			
		||||
                    if (withId(R.id.emptyText).matches(child) && child.isVisible) {
 | 
			
		||||
                        return
 | 
			
		||||
                    }
 | 
			
		||||
                }
 | 
			
		||||
 | 
			
		||||
                // or the refresh layout is refreshing
 | 
			
		||||
                if (view is SwipeRefreshLayout && !view.isRefreshing) {
 | 
			
		||||
                    return
 | 
			
		||||
                }
 | 
			
		||||
                uiController.loopMainThreadForAtLeast(100)
 | 
			
		||||
            } while (System.currentTimeMillis() < endTime)
 | 
			
		||||
 | 
			
		||||
            // timeout happens
 | 
			
		||||
            throw PerformException
 | 
			
		||||
                .Builder()
 | 
			
		||||
                .withActionDescription(this.description)
 | 
			
		||||
                .withViewDescription(HumanReadables.describe(view))
 | 
			
		||||
                .withCause(TimeoutException())
 | 
			
		||||
                .build()
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
fun isPopupWindow(): Matcher<Root> = isPlatformPopup()
 | 
			
		||||
 | 
			
		||||
fun withDrawable(
 | 
			
		||||
 
 | 
			
		||||
							
								
								
									
										87
									
								
								androidApp/src/debug/AndroidManifest.xml
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										87
									
								
								androidApp/src/debug/AndroidManifest.xml
									
									
									
									
									
										Normal file
									
								
							@@ -0,0 +1,87 @@
 | 
			
		||||
<?xml version="1.0" encoding="utf-8"?>
 | 
			
		||||
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
 | 
			
		||||
    xmlns:tools="http://schemas.android.com/tools">
 | 
			
		||||
 | 
			
		||||
    <uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
 | 
			
		||||
    <uses-permission android:name="android.permission.INTERNET" />
 | 
			
		||||
    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
 | 
			
		||||
    <uses-permission android:name="android.permission.MANAGE_EXTERNAL_STORAGE" />
 | 
			
		||||
    <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
 | 
			
		||||
 | 
			
		||||
    <application
 | 
			
		||||
        android:name=".MyApp"
 | 
			
		||||
        android:allowBackup="false"
 | 
			
		||||
        android:configChanges="uiMode"
 | 
			
		||||
        android:dataExtractionRules="@xml/data_extraction_rules"
 | 
			
		||||
        android:fullBackupContent="false"
 | 
			
		||||
        android:icon="@mipmap/ic_launcher"
 | 
			
		||||
        android:label="@string/app_name"
 | 
			
		||||
        android:networkSecurityConfig="@xml/network_security_config"
 | 
			
		||||
        android:requestLegacyExternalStorage="true"
 | 
			
		||||
        android:supportsRtl="true"
 | 
			
		||||
        android:theme="@style/NoBar"
 | 
			
		||||
        tools:replace="android:allowBackup">
 | 
			
		||||
        <activity
 | 
			
		||||
            android:name=".MainActivity"
 | 
			
		||||
            android:exported="true"
 | 
			
		||||
            android:theme="@style/SplashTheme">
 | 
			
		||||
            <intent-filter>
 | 
			
		||||
                <action android:name="android.intent.action.MAIN" />
 | 
			
		||||
                <category android:name="android.intent.category.LAUNCHER" />
 | 
			
		||||
            </intent-filter>
 | 
			
		||||
 | 
			
		||||
            <meta-data
 | 
			
		||||
                android:name="android.app.shortcuts"
 | 
			
		||||
                android:resource="@xml/shortcuts" />
 | 
			
		||||
        </activity>
 | 
			
		||||
        <activity
 | 
			
		||||
            android:name=".LoginActivity"
 | 
			
		||||
            android:label="@string/title_activity_login"></activity>
 | 
			
		||||
        <activity android:name=".HomeActivity"></activity>
 | 
			
		||||
        <activity
 | 
			
		||||
            android:name=".settings.SettingsActivity"
 | 
			
		||||
            android:label="@string/title_activity_settings"
 | 
			
		||||
            android:parentActivityName=".HomeActivity">
 | 
			
		||||
            <meta-data
 | 
			
		||||
                android:name="android.support.PARENT_ACTIVITY"
 | 
			
		||||
                android:value=".HomeActivity" />
 | 
			
		||||
        </activity>
 | 
			
		||||
        <activity
 | 
			
		||||
            android:name=".SourcesActivity"
 | 
			
		||||
            android:parentActivityName=".HomeActivity">
 | 
			
		||||
            <meta-data
 | 
			
		||||
                android:name="android.support.PARENT_ACTIVITY"
 | 
			
		||||
                android:value=".HomeActivity" />
 | 
			
		||||
        </activity>
 | 
			
		||||
        <activity
 | 
			
		||||
            android:name=".UpsertSourceActivity"
 | 
			
		||||
            android:exported="true"
 | 
			
		||||
            android:parentActivityName=".SourcesActivity">
 | 
			
		||||
            <meta-data
 | 
			
		||||
                android:name="android.support.PARENT_ACTIVITY"
 | 
			
		||||
                android:value=".SourcesActivity" />
 | 
			
		||||
 | 
			
		||||
            <intent-filter>
 | 
			
		||||
                <action android:name="android.intent.action.SEND" />
 | 
			
		||||
                <category android:name="android.intent.category.DEFAULT" />
 | 
			
		||||
                <data android:mimeType="text/plain" />
 | 
			
		||||
            </intent-filter>
 | 
			
		||||
        </activity>
 | 
			
		||||
        <activity android:name=".ReaderActivity"></activity>
 | 
			
		||||
        <activity
 | 
			
		||||
            android:name=".ImageActivity"
 | 
			
		||||
            android:theme="@style/Theme.AppCompat.ImageActivity"></activity>
 | 
			
		||||
 | 
			
		||||
        <meta-data
 | 
			
		||||
            android:name="android.webkit.WebView.MetricsOptOut"
 | 
			
		||||
            android:value="true" />
 | 
			
		||||
 | 
			
		||||
        <meta-data
 | 
			
		||||
            android:name="android.webkit.WebView.EnableSafeBrowsing"
 | 
			
		||||
            android:value="true" />
 | 
			
		||||
 | 
			
		||||
        <meta-data
 | 
			
		||||
            android:name="android.max_aspect"
 | 
			
		||||
            android:value="2.1" />
 | 
			
		||||
    </application>
 | 
			
		||||
</manifest>
 | 
			
		||||
@@ -31,7 +31,7 @@ import bou.amine.apps.readerforselfossv2.android.settings.SettingsActivity
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.testing.CountingIdlingResourceSingleton
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.utils.bottombar.maybeShow
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.utils.bottombar.removeBadge
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.utils.openUrlInBrowser
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.utils.openUrlInBrowserAsNewTask
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.model.SelfossModel
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.repository.Repository
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.service.AppSettingsService
 | 
			
		||||
@@ -104,7 +104,7 @@ class HomeActivity :
 | 
			
		||||
 | 
			
		||||
        if (appSettingsService.isItemCachingEnabled()) {
 | 
			
		||||
            CountingIdlingResourceSingleton.increment()
 | 
			
		||||
            CoroutineScope(Dispatchers.Main).launch {
 | 
			
		||||
            CoroutineScope(Dispatchers.IO).launch {
 | 
			
		||||
                repository.tryToCacheItemsAndGetNewOnes()
 | 
			
		||||
                CountingIdlingResourceSingleton.decrement()
 | 
			
		||||
            }
 | 
			
		||||
@@ -120,12 +120,8 @@ class HomeActivity :
 | 
			
		||||
        binding.swipeRefreshLayout.setOnRefreshListener {
 | 
			
		||||
            repository.offlineOverride = false
 | 
			
		||||
            lastFetchDone = false
 | 
			
		||||
            CountingIdlingResourceSingleton.increment()
 | 
			
		||||
            CoroutineScope(Dispatchers.Main).launch {
 | 
			
		||||
                getElementsAccordingToTab()
 | 
			
		||||
                binding.swipeRefreshLayout.isRefreshing = false
 | 
			
		||||
                CountingIdlingResourceSingleton.decrement()
 | 
			
		||||
            }
 | 
			
		||||
            getElementsAccordingToTab()
 | 
			
		||||
            binding.swipeRefreshLayout.isRefreshing = false
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        val swipeDirs =
 | 
			
		||||
@@ -289,7 +285,7 @@ class HomeActivity :
 | 
			
		||||
 | 
			
		||||
        handleRecurringTask()
 | 
			
		||||
        CountingIdlingResourceSingleton.increment()
 | 
			
		||||
        CoroutineScope(Dispatchers.Main).launch {
 | 
			
		||||
        CoroutineScope(Dispatchers.IO).launch {
 | 
			
		||||
            repository.handleDBActions()
 | 
			
		||||
            CountingIdlingResourceSingleton.decrement()
 | 
			
		||||
        }
 | 
			
		||||
@@ -463,8 +459,8 @@ class HomeActivity :
 | 
			
		||||
        itemType: ItemType,
 | 
			
		||||
    ) {
 | 
			
		||||
        CountingIdlingResourceSingleton.increment()
 | 
			
		||||
        CoroutineScope(Dispatchers.Main).launch {
 | 
			
		||||
            binding.swipeRefreshLayout.isRefreshing = true
 | 
			
		||||
        binding.swipeRefreshLayout.isRefreshing = true
 | 
			
		||||
        CoroutineScope(Dispatchers.IO).launch {
 | 
			
		||||
            repository.displayedItems = itemType
 | 
			
		||||
            items =
 | 
			
		||||
                if (appendResults) {
 | 
			
		||||
@@ -472,8 +468,12 @@ class HomeActivity :
 | 
			
		||||
                } else {
 | 
			
		||||
                    repository.getNewerItems()
 | 
			
		||||
                }
 | 
			
		||||
            binding.swipeRefreshLayout.isRefreshing = false
 | 
			
		||||
            handleListResult()
 | 
			
		||||
            CountingIdlingResourceSingleton.increment()
 | 
			
		||||
            launch(Dispatchers.Main) {
 | 
			
		||||
                binding.swipeRefreshLayout.isRefreshing = false
 | 
			
		||||
                handleListResult()
 | 
			
		||||
                CountingIdlingResourceSingleton.decrement()
 | 
			
		||||
            }
 | 
			
		||||
            CountingIdlingResourceSingleton.decrement()
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
@@ -599,7 +599,7 @@ class HomeActivity :
 | 
			
		||||
    override fun onOptionsItemSelected(item: MenuItem): Boolean {
 | 
			
		||||
        when (item.itemId) {
 | 
			
		||||
            R.id.issue_tracker -> {
 | 
			
		||||
                baseContext.openUrlInBrowser(AppSettingsService.BUG_URL)
 | 
			
		||||
                baseContext.openUrlInBrowserAsNewTask(AppSettingsService.BUG_URL)
 | 
			
		||||
                return true
 | 
			
		||||
            }
 | 
			
		||||
 | 
			
		||||
@@ -613,22 +613,26 @@ class HomeActivity :
 | 
			
		||||
                needsConfirmation(R.string.menu_home_refresh, R.string.refresh_dialog_message) {
 | 
			
		||||
                    Toast.makeText(this, R.string.refresh_in_progress, Toast.LENGTH_SHORT).show()
 | 
			
		||||
                    CountingIdlingResourceSingleton.increment()
 | 
			
		||||
                    CoroutineScope(Dispatchers.Main).launch {
 | 
			
		||||
                    CoroutineScope(Dispatchers.IO).launch {
 | 
			
		||||
                        val updatedRemote = repository.updateRemote()
 | 
			
		||||
                        if (updatedRemote) {
 | 
			
		||||
                            Toast
 | 
			
		||||
                                .makeText(
 | 
			
		||||
                                    this@HomeActivity,
 | 
			
		||||
                                    R.string.refresh_success_response,
 | 
			
		||||
                                    Toast.LENGTH_LONG,
 | 
			
		||||
                                ).show()
 | 
			
		||||
                        } else {
 | 
			
		||||
                            Toast
 | 
			
		||||
                                .makeText(
 | 
			
		||||
                                    this@HomeActivity,
 | 
			
		||||
                                    R.string.refresh_failer_message,
 | 
			
		||||
                                    Toast.LENGTH_SHORT,
 | 
			
		||||
                                ).show()
 | 
			
		||||
                        CountingIdlingResourceSingleton.increment()
 | 
			
		||||
                        launch(Dispatchers.Main) {
 | 
			
		||||
                            if (updatedRemote) {
 | 
			
		||||
                                Toast
 | 
			
		||||
                                    .makeText(
 | 
			
		||||
                                        this@HomeActivity,
 | 
			
		||||
                                        R.string.refresh_success_response,
 | 
			
		||||
                                        Toast.LENGTH_LONG,
 | 
			
		||||
                                    ).show()
 | 
			
		||||
                            } else {
 | 
			
		||||
                                Toast
 | 
			
		||||
                                    .makeText(
 | 
			
		||||
                                        this@HomeActivity,
 | 
			
		||||
                                        R.string.refresh_failer_message,
 | 
			
		||||
                                        Toast.LENGTH_SHORT,
 | 
			
		||||
                                    ).show()
 | 
			
		||||
                            }
 | 
			
		||||
                            CountingIdlingResourceSingleton.decrement()
 | 
			
		||||
                        }
 | 
			
		||||
                        CountingIdlingResourceSingleton.decrement()
 | 
			
		||||
                    }
 | 
			
		||||
@@ -639,30 +643,33 @@ class HomeActivity :
 | 
			
		||||
            R.id.readAll -> {
 | 
			
		||||
                if (elementsShown == ItemType.UNREAD) {
 | 
			
		||||
                    needsConfirmation(R.string.readAll, R.string.markall_dialog_message) {
 | 
			
		||||
                        binding.swipeRefreshLayout.isRefreshing = true
 | 
			
		||||
                        CountingIdlingResourceSingleton.increment()
 | 
			
		||||
                        CoroutineScope(Dispatchers.Main).launch {
 | 
			
		||||
                        binding.swipeRefreshLayout.isRefreshing = true
 | 
			
		||||
                        CoroutineScope(Dispatchers.IO).launch {
 | 
			
		||||
                            val success = repository.markAllAsRead(items)
 | 
			
		||||
                            if (success) {
 | 
			
		||||
                                Toast
 | 
			
		||||
                                    .makeText(
 | 
			
		||||
                                        this@HomeActivity,
 | 
			
		||||
                                        R.string.all_posts_read,
 | 
			
		||||
                                        Toast.LENGTH_SHORT,
 | 
			
		||||
                                    ).show()
 | 
			
		||||
                                tabNewBadge.removeBadge()
 | 
			
		||||
                            CountingIdlingResourceSingleton.increment()
 | 
			
		||||
                            launch(Dispatchers.Main) {
 | 
			
		||||
                                if (success) {
 | 
			
		||||
                                    Toast
 | 
			
		||||
                                        .makeText(
 | 
			
		||||
                                            this@HomeActivity,
 | 
			
		||||
                                            R.string.all_posts_read,
 | 
			
		||||
                                            Toast.LENGTH_SHORT,
 | 
			
		||||
                                        ).show()
 | 
			
		||||
                                    tabNewBadge.removeBadge()
 | 
			
		||||
 | 
			
		||||
                                getElementsAccordingToTab()
 | 
			
		||||
                            } else {
 | 
			
		||||
                                Toast
 | 
			
		||||
                                    .makeText(
 | 
			
		||||
                                        this@HomeActivity,
 | 
			
		||||
                                        R.string.all_posts_not_read,
 | 
			
		||||
                                        Toast.LENGTH_SHORT,
 | 
			
		||||
                                    ).show()
 | 
			
		||||
                                    getElementsAccordingToTab()
 | 
			
		||||
                                } else {
 | 
			
		||||
                                    Toast
 | 
			
		||||
                                        .makeText(
 | 
			
		||||
                                            this@HomeActivity,
 | 
			
		||||
                                            R.string.all_posts_not_read,
 | 
			
		||||
                                            Toast.LENGTH_SHORT,
 | 
			
		||||
                                        ).show()
 | 
			
		||||
                                }
 | 
			
		||||
                                binding.swipeRefreshLayout.isRefreshing = false
 | 
			
		||||
                                CountingIdlingResourceSingleton.decrement()
 | 
			
		||||
                            }
 | 
			
		||||
                            handleListResult()
 | 
			
		||||
                            binding.swipeRefreshLayout.isRefreshing = false
 | 
			
		||||
                            CountingIdlingResourceSingleton.decrement()
 | 
			
		||||
                        }
 | 
			
		||||
                    }
 | 
			
		||||
 
 | 
			
		||||
@@ -108,7 +108,7 @@ class LoginActivity :
 | 
			
		||||
 | 
			
		||||
    private fun goToMain() {
 | 
			
		||||
        CountingIdlingResourceSingleton.increment()
 | 
			
		||||
        CoroutineScope(Dispatchers.Main).launch {
 | 
			
		||||
        CoroutineScope(Dispatchers.IO).launch {
 | 
			
		||||
            repository.updateApiInformation()
 | 
			
		||||
            ACRA.errorReporter.putCustomData(
 | 
			
		||||
                "SELFOSS_API_VERSION",
 | 
			
		||||
@@ -127,6 +127,9 @@ class LoginActivity :
 | 
			
		||||
        binding.urlView.error = getString(R.string.wrong_infos)
 | 
			
		||||
        binding.loginView.error = getString(R.string.wrong_infos)
 | 
			
		||||
        binding.passwordView.error = getString(R.string.wrong_infos)
 | 
			
		||||
        binding.urlView.requestFocus()
 | 
			
		||||
 | 
			
		||||
        showProgress(false)
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private fun attemptLogin() {
 | 
			
		||||
@@ -149,9 +152,10 @@ class LoginActivity :
 | 
			
		||||
                .toString()
 | 
			
		||||
                .trim()
 | 
			
		||||
 | 
			
		||||
        failInvalidUrl(url)
 | 
			
		||||
        failLoginDetails(password, login)
 | 
			
		||||
 | 
			
		||||
        val cancelUrl = failInvalidUrl(url)
 | 
			
		||||
        if (cancelUrl) return
 | 
			
		||||
        val cancelDetails = failLoginDetails(password, login)
 | 
			
		||||
        if (cancelDetails) return
 | 
			
		||||
        showProgress(true)
 | 
			
		||||
 | 
			
		||||
        appSettingsService.updateSelfSigned(binding.selfSigned.isChecked)
 | 
			
		||||
@@ -159,41 +163,48 @@ class LoginActivity :
 | 
			
		||||
        repository.refreshLoginInformation(url, login, password)
 | 
			
		||||
 | 
			
		||||
        CountingIdlingResourceSingleton.increment()
 | 
			
		||||
        CoroutineScope(Dispatchers.Main).launch {
 | 
			
		||||
        CoroutineScope(Dispatchers.IO).launch {
 | 
			
		||||
            try {
 | 
			
		||||
                repository.updateApiInformation()
 | 
			
		||||
                val result = repository.login()
 | 
			
		||||
                CountingIdlingResourceSingleton.increment()
 | 
			
		||||
                launch(Dispatchers.Main) {
 | 
			
		||||
                    if (result) {
 | 
			
		||||
                        val errorFetching = repository.checkIfFetchFails()
 | 
			
		||||
                        if (!errorFetching) {
 | 
			
		||||
                            goToMain()
 | 
			
		||||
                        } else {
 | 
			
		||||
                            preferenceError()
 | 
			
		||||
                        }
 | 
			
		||||
                    } else {
 | 
			
		||||
                        preferenceError()
 | 
			
		||||
                    }
 | 
			
		||||
                    CountingIdlingResourceSingleton.decrement()
 | 
			
		||||
                }
 | 
			
		||||
            } catch (e: Exception) {
 | 
			
		||||
                if (e.message?.startsWith("No transformation found") == true) {
 | 
			
		||||
                    Toast
 | 
			
		||||
                        .makeText(
 | 
			
		||||
                            applicationContext,
 | 
			
		||||
                            R.string.application_selfoss_only,
 | 
			
		||||
                            Toast.LENGTH_LONG,
 | 
			
		||||
                        ).show()
 | 
			
		||||
                    preferenceError()
 | 
			
		||||
                    showProgress(false)
 | 
			
		||||
                CountingIdlingResourceSingleton.increment()
 | 
			
		||||
                launch(Dispatchers.Main) {
 | 
			
		||||
                    if (e.message?.startsWith("No transformation found") == true) {
 | 
			
		||||
                        Toast
 | 
			
		||||
                            .makeText(
 | 
			
		||||
                                applicationContext,
 | 
			
		||||
                                R.string.application_selfoss_only,
 | 
			
		||||
                                Toast.LENGTH_LONG,
 | 
			
		||||
                            ).show()
 | 
			
		||||
                        preferenceError()
 | 
			
		||||
                    }
 | 
			
		||||
                    CountingIdlingResourceSingleton.decrement()
 | 
			
		||||
                }
 | 
			
		||||
            } finally {
 | 
			
		||||
                CountingIdlingResourceSingleton.decrement()
 | 
			
		||||
            }
 | 
			
		||||
            val result = repository.login()
 | 
			
		||||
            if (result) {
 | 
			
		||||
                val errorFetching = repository.checkIfFetchFails()
 | 
			
		||||
                if (!errorFetching) {
 | 
			
		||||
                    goToMain()
 | 
			
		||||
                } else {
 | 
			
		||||
                    preferenceError()
 | 
			
		||||
                }
 | 
			
		||||
            } else {
 | 
			
		||||
                preferenceError()
 | 
			
		||||
            }
 | 
			
		||||
            showProgress(false)
 | 
			
		||||
            CountingIdlingResourceSingleton.decrement()
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private fun failLoginDetails(
 | 
			
		||||
        password: String,
 | 
			
		||||
        login: String,
 | 
			
		||||
    ) {
 | 
			
		||||
    ): Boolean {
 | 
			
		||||
        var lastFocusedView: View? = null
 | 
			
		||||
        var cancel = false
 | 
			
		||||
        if (isWithLogin) {
 | 
			
		||||
@@ -210,9 +221,10 @@ class LoginActivity :
 | 
			
		||||
            }
 | 
			
		||||
        }
 | 
			
		||||
        maybeCancelAndFocusView(cancel, lastFocusedView)
 | 
			
		||||
        return cancel
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private fun failInvalidUrl(url: String) {
 | 
			
		||||
    private fun failInvalidUrl(url: String): Boolean {
 | 
			
		||||
        val focusView = binding.urlView
 | 
			
		||||
        var cancel = false
 | 
			
		||||
        if (url.isBaseUrlInvalid()) {
 | 
			
		||||
@@ -232,6 +244,7 @@ class LoginActivity :
 | 
			
		||||
            }
 | 
			
		||||
        }
 | 
			
		||||
        maybeCancelAndFocusView(cancel, focusView)
 | 
			
		||||
        return cancel
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private fun maybeCancelAndFocusView(
 | 
			
		||||
 
 | 
			
		||||
@@ -10,18 +10,16 @@ import androidx.lifecycle.LifecycleOwner
 | 
			
		||||
import androidx.lifecycle.ProcessLifecycleOwner
 | 
			
		||||
import androidx.multidex.MultiDexApplication
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.testing.TestingHelper
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.viewmodel.AppViewModel
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.dao.DriverFactory
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.dao.ReaderForSelfossDB
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.di.networkModule
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.repository.Repository
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.service.AppSettingsService
 | 
			
		||||
import com.github.ln_12.library.ConnectivityStatus
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.service.ConnectivityService
 | 
			
		||||
import io.github.aakira.napier.DebugAntilog
 | 
			
		||||
import io.github.aakira.napier.Napier
 | 
			
		||||
import kotlinx.coroutines.CoroutineScope
 | 
			
		||||
import kotlinx.coroutines.Dispatchers
 | 
			
		||||
import kotlinx.coroutines.flow.MutableStateFlow
 | 
			
		||||
import kotlinx.coroutines.launch
 | 
			
		||||
import org.acra.ACRA
 | 
			
		||||
import org.acra.ReportField
 | 
			
		||||
@@ -44,27 +42,21 @@ class MyApp :
 | 
			
		||||
        import(networkModule)
 | 
			
		||||
        bind<DriverFactory>() with singleton { DriverFactory(applicationContext) }
 | 
			
		||||
        bind<ReaderForSelfossDB>() with singleton { ReaderForSelfossDB(driverFactory.createDriver()) }
 | 
			
		||||
        bind<ConnectivityService>() with singleton { ConnectivityService() }
 | 
			
		||||
        bind<Repository>() with
 | 
			
		||||
            singleton {
 | 
			
		||||
                Repository(
 | 
			
		||||
                    instance(),
 | 
			
		||||
                    instance(),
 | 
			
		||||
                    isConnectionAvailable,
 | 
			
		||||
                    instance(),
 | 
			
		||||
                    instance(),
 | 
			
		||||
                )
 | 
			
		||||
            }
 | 
			
		||||
        bind<ConnectivityStatus>() with singleton { ConnectivityStatus(applicationContext) }
 | 
			
		||||
        bind<AppViewModel>() with singleton { AppViewModel(repository = instance()) }
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private val repository: Repository by instance()
 | 
			
		||||
    private val viewModel: AppViewModel by instance()
 | 
			
		||||
    private val connectivityStatus: ConnectivityStatus by instance()
 | 
			
		||||
    private val driverFactory: DriverFactory by instance()
 | 
			
		||||
 | 
			
		||||
    @Suppress("detekt:ForbiddenComment")
 | 
			
		||||
    // TODO: handle with the "previous" way
 | 
			
		||||
    private val isConnectionAvailable: MutableStateFlow<Boolean> = MutableStateFlow(true)
 | 
			
		||||
    private val connectivityService: ConnectivityService by instance()
 | 
			
		||||
 | 
			
		||||
    override fun onCreate() {
 | 
			
		||||
        super.onCreate()
 | 
			
		||||
@@ -77,13 +69,12 @@ class MyApp :
 | 
			
		||||
 | 
			
		||||
            ProcessLifecycleOwner.get().lifecycle.addObserver(
 | 
			
		||||
                AppLifeCycleObserver(
 | 
			
		||||
                    connectivityStatus,
 | 
			
		||||
                    repository,
 | 
			
		||||
                    connectivityService,
 | 
			
		||||
                ),
 | 
			
		||||
            )
 | 
			
		||||
 | 
			
		||||
            CoroutineScope(Dispatchers.Main).launch {
 | 
			
		||||
                viewModel.networkAvailableProvider.collect { networkAvailable ->
 | 
			
		||||
            CoroutineScope(Dispatchers.Default).launch {
 | 
			
		||||
                connectivityService.networkAvailableProvider.collect { networkAvailable ->
 | 
			
		||||
                    val toastMessage =
 | 
			
		||||
                        if (networkAvailable) {
 | 
			
		||||
                            repository.handleDBActions()
 | 
			
		||||
@@ -109,6 +100,7 @@ class MyApp :
 | 
			
		||||
        super.attachBaseContext(base)
 | 
			
		||||
 | 
			
		||||
        initAcra {
 | 
			
		||||
            sendReportsInDevMode = false
 | 
			
		||||
            reportFormat = StringFormat.JSON
 | 
			
		||||
            reportContent =
 | 
			
		||||
                listOf(
 | 
			
		||||
@@ -188,18 +180,15 @@ class MyApp :
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    class AppLifeCycleObserver(
 | 
			
		||||
        val connectivityStatus: ConnectivityStatus,
 | 
			
		||||
        val repository: Repository,
 | 
			
		||||
        val connectivityService: ConnectivityService,
 | 
			
		||||
    ) : DefaultLifecycleObserver {
 | 
			
		||||
        override fun onResume(owner: LifecycleOwner) {
 | 
			
		||||
            super.onResume(owner)
 | 
			
		||||
            repository.connectionMonitored = true
 | 
			
		||||
            connectivityStatus.start()
 | 
			
		||||
            connectivityService.start()
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        override fun onPause(owner: LifecycleOwner) {
 | 
			
		||||
            repository.connectionMonitored = false
 | 
			
		||||
            connectivityStatus.stop()
 | 
			
		||||
            connectivityService.stop()
 | 
			
		||||
            super.onPause(owner)
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
 
 | 
			
		||||
@@ -27,7 +27,7 @@ class ReaderActivity :
 | 
			
		||||
    DIAware {
 | 
			
		||||
    private var currentItem: Int = 0
 | 
			
		||||
 | 
			
		||||
    private lateinit var toolbarMenu: Menu
 | 
			
		||||
    private var toolbarMenu: Menu? = null
 | 
			
		||||
 | 
			
		||||
    private lateinit var binding: ActivityReaderBinding
 | 
			
		||||
 | 
			
		||||
@@ -37,22 +37,6 @@ class ReaderActivity :
 | 
			
		||||
    private val repository: Repository by instance()
 | 
			
		||||
    private val appSettingsService: AppSettingsService by instance()
 | 
			
		||||
 | 
			
		||||
    private fun showMenuItem(willAddToFavorite: Boolean) {
 | 
			
		||||
        if (willAddToFavorite) {
 | 
			
		||||
            toolbarMenu.findItem(R.id.star).icon?.setTint(Color.WHITE)
 | 
			
		||||
        } else {
 | 
			
		||||
            toolbarMenu.findItem(R.id.star).icon?.setTint(Color.RED)
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private fun canFavorite() {
 | 
			
		||||
        showMenuItem(true)
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private fun canRemoveFromFavorite() {
 | 
			
		||||
        showMenuItem(false)
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    @Suppress("detekt:SwallowedException")
 | 
			
		||||
    override fun onCreate(savedInstanceState: Bundle?) {
 | 
			
		||||
        super.onCreate(savedInstanceState)
 | 
			
		||||
@@ -73,14 +57,21 @@ class ReaderActivity :
 | 
			
		||||
            finish()
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        try {
 | 
			
		||||
            readItem(allItems[currentItem])
 | 
			
		||||
        } catch (e: IndexOutOfBoundsException) {
 | 
			
		||||
            finish()
 | 
			
		||||
        }
 | 
			
		||||
        readItem()
 | 
			
		||||
 | 
			
		||||
        binding.pager.adapter = ScreenSlidePagerAdapter(this)
 | 
			
		||||
        binding.pager.setCurrentItem(currentItem, false)
 | 
			
		||||
 | 
			
		||||
        binding.pager.registerOnPageChangeCallback(
 | 
			
		||||
            object : ViewPager2.OnPageChangeCallback() {
 | 
			
		||||
                override fun onPageSelected(position: Int) {
 | 
			
		||||
                    super.onPageSelected(position)
 | 
			
		||||
                    currentItem = position
 | 
			
		||||
                    updateStarIcon()
 | 
			
		||||
                    readItem()
 | 
			
		||||
                }
 | 
			
		||||
            },
 | 
			
		||||
        )
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    override fun onResume() {
 | 
			
		||||
@@ -89,14 +80,22 @@ class ReaderActivity :
 | 
			
		||||
        binding.indicator.setViewPager(binding.pager)
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private fun readItem(item: SelfossModel.Item) {
 | 
			
		||||
        if (appSettingsService.isMarkOnScrollEnabled() && !appSettingsService.getPublicAccess()) {
 | 
			
		||||
    private fun readItem() {
 | 
			
		||||
        val item = allItems.getOrNull(currentItem)
 | 
			
		||||
        if (appSettingsService.isMarkOnScrollEnabled() && !appSettingsService.getPublicAccess() && item != null) {
 | 
			
		||||
            CoroutineScope(Dispatchers.IO).launch {
 | 
			
		||||
                repository.markAsRead(item)
 | 
			
		||||
            }
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private fun updateStarIcon() {
 | 
			
		||||
        if (toolbarMenu != null) {
 | 
			
		||||
            val isStarred = allItems.getOrNull(currentItem)?.starred ?: false
 | 
			
		||||
            toolbarMenu!!.findItem(R.id.star)?.icon?.setTint(if (isStarred) Color.RED else Color.WHITE)
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    override fun onSaveInstanceState(oldInstanceState: Bundle) {
 | 
			
		||||
        super.onSaveInstanceState(oldInstanceState)
 | 
			
		||||
        oldInstanceState.clear()
 | 
			
		||||
@@ -136,13 +135,14 @@ class ReaderActivity :
 | 
			
		||||
 | 
			
		||||
    private fun alignmentMenu() {
 | 
			
		||||
        val showJustify = appSettingsService.getActiveAllignment() == AppSettingsService.ALIGN_LEFT
 | 
			
		||||
        toolbarMenu.findItem(R.id.align_left).isVisible = !showJustify
 | 
			
		||||
        toolbarMenu.findItem(R.id.align_justify).isVisible = showJustify
 | 
			
		||||
        if (toolbarMenu != null) {
 | 
			
		||||
            toolbarMenu!!.findItem(R.id.align_left).isVisible = !showJustify
 | 
			
		||||
            toolbarMenu!!.findItem(R.id.align_justify).isVisible = showJustify
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    override fun onCreateOptionsMenu(menu: Menu): Boolean {
 | 
			
		||||
        val inflater = menuInflater
 | 
			
		||||
        inflater.inflate(R.menu.reader_menu, menu)
 | 
			
		||||
        menuInflater.inflate(R.menu.reader_menu, menu)
 | 
			
		||||
        toolbarMenu = menu
 | 
			
		||||
 | 
			
		||||
        alignmentMenu()
 | 
			
		||||
@@ -150,85 +150,50 @@ class ReaderActivity :
 | 
			
		||||
        if (appSettingsService.getPublicAccess()) {
 | 
			
		||||
            menu.removeItem(R.id.star)
 | 
			
		||||
        } else {
 | 
			
		||||
            if (allItems.isNotEmpty() && allItems[currentItem].starred) {
 | 
			
		||||
                canRemoveFromFavorite()
 | 
			
		||||
            } else {
 | 
			
		||||
                canFavorite()
 | 
			
		||||
            }
 | 
			
		||||
 | 
			
		||||
            binding.pager.registerOnPageChangeCallback(
 | 
			
		||||
                object : ViewPager2.OnPageChangeCallback() {
 | 
			
		||||
                    override fun onPageSelected(position: Int) {
 | 
			
		||||
                        super.onPageSelected(position)
 | 
			
		||||
 | 
			
		||||
                        if (allItems[position].starred) {
 | 
			
		||||
                            canRemoveFromFavorite()
 | 
			
		||||
                        } else {
 | 
			
		||||
                            canFavorite()
 | 
			
		||||
                        }
 | 
			
		||||
                        readItem(allItems[position])
 | 
			
		||||
                    }
 | 
			
		||||
                },
 | 
			
		||||
            )
 | 
			
		||||
            updateStarIcon()
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        return true
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    override fun onOptionsItemSelected(item: MenuItem): Boolean {
 | 
			
		||||
        fun afterSave() {
 | 
			
		||||
            allItems[binding.pager.currentItem] =
 | 
			
		||||
                allItems[binding.pager.currentItem].toggleStar()
 | 
			
		||||
            canRemoveFromFavorite()
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        fun afterUnsave() {
 | 
			
		||||
            allItems[binding.pager.currentItem] = allItems[binding.pager.currentItem].toggleStar()
 | 
			
		||||
            canFavorite()
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        when (item.itemId) {
 | 
			
		||||
            android.R.id.home -> {
 | 
			
		||||
                onBackPressedDispatcher.onBackPressed()
 | 
			
		||||
                return true
 | 
			
		||||
            }
 | 
			
		||||
 | 
			
		||||
            R.id.star -> {
 | 
			
		||||
                if (allItems[binding.pager.currentItem].starred) {
 | 
			
		||||
                    CoroutineScope(Dispatchers.IO).launch {
 | 
			
		||||
                        repository.unstarr(allItems[binding.pager.currentItem])
 | 
			
		||||
                    }
 | 
			
		||||
                    afterUnsave()
 | 
			
		||||
                } else {
 | 
			
		||||
                    CoroutineScope(Dispatchers.IO).launch {
 | 
			
		||||
                        repository.starr(allItems[binding.pager.currentItem])
 | 
			
		||||
                    }
 | 
			
		||||
                    afterSave()
 | 
			
		||||
                }
 | 
			
		||||
            }
 | 
			
		||||
 | 
			
		||||
            R.id.align_left -> {
 | 
			
		||||
                switchAlignmentSetting(AppSettingsService.ALIGN_LEFT)
 | 
			
		||||
                refreshFragment()
 | 
			
		||||
            }
 | 
			
		||||
 | 
			
		||||
            R.id.align_justify -> {
 | 
			
		||||
                switchAlignmentSetting(AppSettingsService.JUSTIFY)
 | 
			
		||||
                refreshFragment()
 | 
			
		||||
            }
 | 
			
		||||
            android.R.id.home -> onBackPressedDispatcher.onBackPressed()
 | 
			
		||||
            R.id.star -> toggleFavorite()
 | 
			
		||||
            R.id.align_left -> switchAlignmentSetting(AppSettingsService.ALIGN_LEFT)
 | 
			
		||||
            R.id.align_justify -> switchAlignmentSetting(AppSettingsService.JUSTIFY)
 | 
			
		||||
        }
 | 
			
		||||
        return super.onOptionsItemSelected(item)
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private fun switchAlignmentSetting(allignment: Int) {
 | 
			
		||||
        appSettingsService.changeAllignment(allignment)
 | 
			
		||||
        alignmentMenu()
 | 
			
		||||
    private fun toggleFavorite() {
 | 
			
		||||
        val item = allItems.getOrNull(currentItem) ?: return
 | 
			
		||||
 | 
			
		||||
        val starred = item.starred
 | 
			
		||||
 | 
			
		||||
        CoroutineScope(Dispatchers.IO).launch {
 | 
			
		||||
            if (starred) {
 | 
			
		||||
                repository.unstarr(item)
 | 
			
		||||
            } else {
 | 
			
		||||
                repository.starr(item)
 | 
			
		||||
            }
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        item.toggleStar()
 | 
			
		||||
        updateStarIcon()
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private fun refreshFragment() {
 | 
			
		||||
        finish()
 | 
			
		||||
        overridePendingTransition(0, 0)
 | 
			
		||||
        startActivity(intent)
 | 
			
		||||
        overridePendingTransition(0, 0)
 | 
			
		||||
    private fun switchAlignmentSetting(alignment: Int) {
 | 
			
		||||
        appSettingsService.changeAllignment(alignment)
 | 
			
		||||
        alignmentMenu()
 | 
			
		||||
 | 
			
		||||
        val fragmentManager = supportFragmentManager
 | 
			
		||||
        val fragments = fragmentManager.fragments
 | 
			
		||||
 | 
			
		||||
        for (fragment in fragments) {
 | 
			
		||||
            if (fragment is ArticleFragment) {
 | 
			
		||||
                fragment.refreshAlignment()
 | 
			
		||||
            }
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
 
 | 
			
		||||
@@ -50,6 +50,7 @@ class SourcesActivity :
 | 
			
		||||
 | 
			
		||||
    override fun onResume() {
 | 
			
		||||
        super.onResume()
 | 
			
		||||
        CountingIdlingResourceSingleton.increment()
 | 
			
		||||
        val mLayoutManager = LinearLayoutManager(this)
 | 
			
		||||
 | 
			
		||||
        var items: ArrayList<SelfossModel.SourceDetail>
 | 
			
		||||
@@ -57,25 +58,28 @@ class SourcesActivity :
 | 
			
		||||
        binding.recyclerView.setHasFixedSize(true)
 | 
			
		||||
        binding.recyclerView.layoutManager = mLayoutManager
 | 
			
		||||
 | 
			
		||||
        CountingIdlingResourceSingleton.increment()
 | 
			
		||||
        CoroutineScope(Dispatchers.Main).launch {
 | 
			
		||||
        CoroutineScope(Dispatchers.IO).launch {
 | 
			
		||||
            val response = repository.getSourcesDetails()
 | 
			
		||||
            if (response.isNotEmpty()) {
 | 
			
		||||
                items = response
 | 
			
		||||
                val mAdapter =
 | 
			
		||||
                    SourcesListAdapter(
 | 
			
		||||
                        this@SourcesActivity,
 | 
			
		||||
                        items,
 | 
			
		||||
                    )
 | 
			
		||||
                binding.recyclerView.adapter = mAdapter
 | 
			
		||||
                mAdapter.notifyDataSetChanged()
 | 
			
		||||
            } else {
 | 
			
		||||
                Toast
 | 
			
		||||
                    .makeText(
 | 
			
		||||
                        this@SourcesActivity,
 | 
			
		||||
                        R.string.cant_get_sources,
 | 
			
		||||
                        Toast.LENGTH_SHORT,
 | 
			
		||||
                    ).show()
 | 
			
		||||
            CountingIdlingResourceSingleton.increment()
 | 
			
		||||
            launch(Dispatchers.Main) {
 | 
			
		||||
                if (response.isNotEmpty()) {
 | 
			
		||||
                    items = response
 | 
			
		||||
                    val mAdapter =
 | 
			
		||||
                        SourcesListAdapter(
 | 
			
		||||
                            this@SourcesActivity,
 | 
			
		||||
                            items,
 | 
			
		||||
                        )
 | 
			
		||||
                    binding.recyclerView.adapter = mAdapter
 | 
			
		||||
                    mAdapter.notifyDataSetChanged()
 | 
			
		||||
                } else {
 | 
			
		||||
                    Toast
 | 
			
		||||
                        .makeText(
 | 
			
		||||
                            this@SourcesActivity,
 | 
			
		||||
                            R.string.cant_get_sources,
 | 
			
		||||
                            Toast.LENGTH_SHORT,
 | 
			
		||||
                        ).show()
 | 
			
		||||
                }
 | 
			
		||||
                CountingIdlingResourceSingleton.decrement()
 | 
			
		||||
            }
 | 
			
		||||
            CountingIdlingResourceSingleton.decrement()
 | 
			
		||||
        }
 | 
			
		||||
 
 | 
			
		||||
@@ -9,11 +9,10 @@ import android.widget.TextView
 | 
			
		||||
import android.widget.Toast
 | 
			
		||||
import androidx.appcompat.app.AppCompatActivity
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.databinding.ActivityUpsertSourceBinding
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.utils.isBaseUrlInvalid
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.testing.CountingIdlingResourceSingleton
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.model.NetworkUnavailableException
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.model.SelfossModel
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.repository.Repository
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.service.AppSettingsService
 | 
			
		||||
import kotlinx.coroutines.CoroutineScope
 | 
			
		||||
import kotlinx.coroutines.Dispatchers
 | 
			
		||||
import kotlinx.coroutines.launch
 | 
			
		||||
@@ -31,7 +30,6 @@ class UpsertSourceActivity :
 | 
			
		||||
 | 
			
		||||
    override val di by closestDI()
 | 
			
		||||
    private val repository: Repository by instance()
 | 
			
		||||
    private val appSettingsService: AppSettingsService by instance()
 | 
			
		||||
 | 
			
		||||
    override fun onCreate(savedInstanceState: Bundle?) {
 | 
			
		||||
        super.onCreate(savedInstanceState)
 | 
			
		||||
@@ -76,13 +74,7 @@ class UpsertSourceActivity :
 | 
			
		||||
 | 
			
		||||
    override fun onResume() {
 | 
			
		||||
        super.onResume()
 | 
			
		||||
 | 
			
		||||
        val baseUrl = appSettingsService.getBaseUrl()
 | 
			
		||||
        if (baseUrl.isEmpty() || baseUrl.isBaseUrlInvalid()) {
 | 
			
		||||
            mustLoginToAddSource()
 | 
			
		||||
        } else {
 | 
			
		||||
            handleSpoutsSpinner()
 | 
			
		||||
        }
 | 
			
		||||
        handleSpoutsSpinner()
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    @Suppress("detekt:SwallowedException")
 | 
			
		||||
@@ -117,36 +109,42 @@ class UpsertSourceActivity :
 | 
			
		||||
            binding.progress.visibility = View.GONE
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        CoroutineScope(Dispatchers.Main).launch {
 | 
			
		||||
        CountingIdlingResourceSingleton.increment()
 | 
			
		||||
        CoroutineScope(Dispatchers.IO).launch {
 | 
			
		||||
            try {
 | 
			
		||||
                val items = repository.getSpouts()
 | 
			
		||||
                if (items.isNotEmpty()) {
 | 
			
		||||
                    val itemsStrings = items.map { it.value.name }
 | 
			
		||||
                    for ((key, value) in items) {
 | 
			
		||||
                        spoutsKV[value.name] = key
 | 
			
		||||
                CountingIdlingResourceSingleton.increment()
 | 
			
		||||
                launch(Dispatchers.Main) {
 | 
			
		||||
                    if (items.isNotEmpty()) {
 | 
			
		||||
                        val itemsStrings = items.map { it.value.name }
 | 
			
		||||
                        for ((key, value) in items) {
 | 
			
		||||
                            spoutsKV[value.name] = key
 | 
			
		||||
                        }
 | 
			
		||||
 | 
			
		||||
                        binding.progress.visibility = View.GONE
 | 
			
		||||
                        binding.formContainer.visibility = View.VISIBLE
 | 
			
		||||
 | 
			
		||||
                        val spinnerArrayAdapter =
 | 
			
		||||
                            ArrayAdapter(
 | 
			
		||||
                                this@UpsertSourceActivity,
 | 
			
		||||
                                android.R.layout.simple_spinner_item,
 | 
			
		||||
                                itemsStrings,
 | 
			
		||||
                            )
 | 
			
		||||
                        spinnerArrayAdapter.setDropDownViewResource(android.R.layout.simple_spinner_dropdown_item)
 | 
			
		||||
                        binding.spoutsSpinner.adapter = spinnerArrayAdapter
 | 
			
		||||
 | 
			
		||||
                        if (existingSource != null) {
 | 
			
		||||
                            initFields(items)
 | 
			
		||||
                        }
 | 
			
		||||
                    } else {
 | 
			
		||||
                        handleSpoutFailure()
 | 
			
		||||
                    }
 | 
			
		||||
 | 
			
		||||
                    binding.progress.visibility = View.GONE
 | 
			
		||||
                    binding.formContainer.visibility = View.VISIBLE
 | 
			
		||||
 | 
			
		||||
                    val spinnerArrayAdapter =
 | 
			
		||||
                        ArrayAdapter(
 | 
			
		||||
                            this@UpsertSourceActivity,
 | 
			
		||||
                            android.R.layout.simple_spinner_item,
 | 
			
		||||
                            itemsStrings,
 | 
			
		||||
                        )
 | 
			
		||||
                    spinnerArrayAdapter.setDropDownViewResource(android.R.layout.simple_spinner_dropdown_item)
 | 
			
		||||
                    binding.spoutsSpinner.adapter = spinnerArrayAdapter
 | 
			
		||||
 | 
			
		||||
                    if (existingSource != null) {
 | 
			
		||||
                        initFields(items)
 | 
			
		||||
                    }
 | 
			
		||||
                } else {
 | 
			
		||||
                    handleSpoutFailure()
 | 
			
		||||
                    CountingIdlingResourceSingleton.decrement()
 | 
			
		||||
                }
 | 
			
		||||
            } catch (e: NetworkUnavailableException) {
 | 
			
		||||
                handleSpoutFailure(networkIssue = true)
 | 
			
		||||
            }
 | 
			
		||||
            CountingIdlingResourceSingleton.decrement()
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
@@ -157,13 +155,6 @@ class UpsertSourceActivity :
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private fun mustLoginToAddSource() {
 | 
			
		||||
        Toast.makeText(this, getString(R.string.addStringNoUrl), Toast.LENGTH_SHORT).show()
 | 
			
		||||
        val i = Intent(this, LoginActivity::class.java)
 | 
			
		||||
        startActivity(i)
 | 
			
		||||
        finish()
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private fun handleSaveSource() {
 | 
			
		||||
        val url = binding.sourceUri.text.toString()
 | 
			
		||||
 | 
			
		||||
@@ -176,7 +167,8 @@ class UpsertSourceActivity :
 | 
			
		||||
            }
 | 
			
		||||
 | 
			
		||||
            else -> {
 | 
			
		||||
                CoroutineScope(Dispatchers.Main).launch {
 | 
			
		||||
                CountingIdlingResourceSingleton.increment()
 | 
			
		||||
                CoroutineScope(Dispatchers.IO).launch {
 | 
			
		||||
                    val successfullyAddedSource =
 | 
			
		||||
                        if (existingSource != null) {
 | 
			
		||||
                            repository.updateSource(
 | 
			
		||||
@@ -194,16 +186,21 @@ class UpsertSourceActivity :
 | 
			
		||||
                                binding.tags.text.toString(),
 | 
			
		||||
                            )
 | 
			
		||||
                        }
 | 
			
		||||
                    if (successfullyAddedSource) {
 | 
			
		||||
                        finish()
 | 
			
		||||
                    } else {
 | 
			
		||||
                        Toast
 | 
			
		||||
                            .makeText(
 | 
			
		||||
                                this@UpsertSourceActivity,
 | 
			
		||||
                                R.string.cant_create_source,
 | 
			
		||||
                                Toast.LENGTH_SHORT,
 | 
			
		||||
                            ).show()
 | 
			
		||||
                    CountingIdlingResourceSingleton.increment()
 | 
			
		||||
                    launch(Dispatchers.Main) {
 | 
			
		||||
                        if (successfullyAddedSource) {
 | 
			
		||||
                            finish()
 | 
			
		||||
                        } else {
 | 
			
		||||
                            Toast
 | 
			
		||||
                                .makeText(
 | 
			
		||||
                                    this@UpsertSourceActivity,
 | 
			
		||||
                                    R.string.cant_create_source,
 | 
			
		||||
                                    Toast.LENGTH_SHORT,
 | 
			
		||||
                                ).show()
 | 
			
		||||
                        }
 | 
			
		||||
                        CountingIdlingResourceSingleton.decrement()
 | 
			
		||||
                    }
 | 
			
		||||
                    CountingIdlingResourceSingleton.decrement()
 | 
			
		||||
                }
 | 
			
		||||
            }
 | 
			
		||||
        }
 | 
			
		||||
 
 | 
			
		||||
@@ -6,9 +6,8 @@ import android.content.Intent
 | 
			
		||||
import android.view.LayoutInflater
 | 
			
		||||
import android.view.View
 | 
			
		||||
import android.view.ViewGroup
 | 
			
		||||
import android.widget.Button
 | 
			
		||||
import android.widget.Toast
 | 
			
		||||
import androidx.constraintlayout.widget.ConstraintLayout
 | 
			
		||||
import androidx.appcompat.app.AlertDialog
 | 
			
		||||
import androidx.recyclerview.widget.RecyclerView
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.R
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.UpsertSourceActivity
 | 
			
		||||
@@ -32,69 +31,21 @@ class SourcesListAdapter(
 | 
			
		||||
    private val items: ArrayList<SelfossModel.SourceDetail>,
 | 
			
		||||
) : RecyclerView.Adapter<SourcesListAdapter.ViewHolder>(),
 | 
			
		||||
    DIAware {
 | 
			
		||||
    private val c: Context = app.baseContext
 | 
			
		||||
    private lateinit var binding: SourceListItemBinding
 | 
			
		||||
 | 
			
		||||
    override val di: DI by closestDI(app)
 | 
			
		||||
    private val repository: Repository by instance()
 | 
			
		||||
    private val appSettingsService: AppSettingsService by instance()
 | 
			
		||||
 | 
			
		||||
    override fun onCreateViewHolder(
 | 
			
		||||
        parent: ViewGroup,
 | 
			
		||||
        viewType: Int,
 | 
			
		||||
    ): ViewHolder {
 | 
			
		||||
        binding = SourceListItemBinding.inflate(LayoutInflater.from(parent.context), parent, false)
 | 
			
		||||
        return ViewHolder(binding.root)
 | 
			
		||||
        val binding = SourceListItemBinding.inflate(LayoutInflater.from(parent.context), parent, false)
 | 
			
		||||
        return ViewHolder(binding)
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    override fun onBindViewHolder(
 | 
			
		||||
        holder: ViewHolder,
 | 
			
		||||
        position: Int,
 | 
			
		||||
    ) {
 | 
			
		||||
        val itm = items[position]
 | 
			
		||||
 | 
			
		||||
        val deleteBtn: Button = holder.mView.findViewById(R.id.deleteBtn)
 | 
			
		||||
 | 
			
		||||
        deleteBtn.setOnClickListener {
 | 
			
		||||
            val (id, title) = items[position]
 | 
			
		||||
            CoroutineScope(Dispatchers.IO).launch {
 | 
			
		||||
                val successfullyDeletedSource = repository.deleteSource(id, title)
 | 
			
		||||
                if (successfullyDeletedSource) {
 | 
			
		||||
                    items.removeAt(position)
 | 
			
		||||
                    notifyItemRemoved(position)
 | 
			
		||||
                    notifyItemRangeChanged(position, itemCount)
 | 
			
		||||
                } else {
 | 
			
		||||
                    Toast
 | 
			
		||||
                        .makeText(
 | 
			
		||||
                            app,
 | 
			
		||||
                            R.string.can_delete_source,
 | 
			
		||||
                            Toast.LENGTH_SHORT,
 | 
			
		||||
                        ).show()
 | 
			
		||||
                }
 | 
			
		||||
            }
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        holder.mView.setOnClickListener {
 | 
			
		||||
            val source = items[position]
 | 
			
		||||
 | 
			
		||||
            repository.setSelectedSource(source)
 | 
			
		||||
            app.startActivity(Intent(app, UpsertSourceActivity::class.java))
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        if (itm.getIcon(repository.baseUrl).isEmpty()) {
 | 
			
		||||
            binding.itemImage.setBackgroundAndText(itm.title.getHtmlDecoded())
 | 
			
		||||
        } else {
 | 
			
		||||
            c.circularDrawable(itm.getIcon(repository.baseUrl), binding.itemImage, appSettingsService)
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        if (!itm.error.isNullOrBlank()) {
 | 
			
		||||
            binding.errorText.visibility = View.VISIBLE
 | 
			
		||||
            binding.errorText.text = itm.error
 | 
			
		||||
        } else {
 | 
			
		||||
            binding.errorText.visibility = View.GONE
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        binding.sourceTitle.text = itm.title.getHtmlDecoded()
 | 
			
		||||
        holder.bind(items[position], position)
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    override fun getItemId(position: Int) = position.toLong()
 | 
			
		||||
@@ -104,6 +55,72 @@ class SourcesListAdapter(
 | 
			
		||||
    override fun getItemCount(): Int = items.size
 | 
			
		||||
 | 
			
		||||
    inner class ViewHolder(
 | 
			
		||||
        val mView: ConstraintLayout,
 | 
			
		||||
    ) : RecyclerView.ViewHolder(mView)
 | 
			
		||||
        val binding: SourceListItemBinding,
 | 
			
		||||
    ) : RecyclerView.ViewHolder(binding.root) {
 | 
			
		||||
        private val context: Context = app.applicationContext
 | 
			
		||||
        private val repository: Repository by instance()
 | 
			
		||||
        private val appSettingsService: AppSettingsService by instance()
 | 
			
		||||
 | 
			
		||||
        fun bind(
 | 
			
		||||
            source: SelfossModel.SourceDetail,
 | 
			
		||||
            position: Int,
 | 
			
		||||
        ) {
 | 
			
		||||
            binding.apply {
 | 
			
		||||
                sourceTitle.text = source.title.getHtmlDecoded()
 | 
			
		||||
                if (source.getIcon(repository.baseUrl).isEmpty()) {
 | 
			
		||||
                    itemImage.setBackgroundAndText(source.title.getHtmlDecoded())
 | 
			
		||||
                } else {
 | 
			
		||||
                    context.circularDrawable(source.getIcon(repository.baseUrl), itemImage, appSettingsService)
 | 
			
		||||
                }
 | 
			
		||||
 | 
			
		||||
                errorText.apply {
 | 
			
		||||
                    visibility = if (!source.error.isNullOrBlank()) View.VISIBLE else View.GONE
 | 
			
		||||
                    text = source.error
 | 
			
		||||
                }
 | 
			
		||||
 | 
			
		||||
                deleteBtn.setOnClickListener { showDeleteConfirmationDialog(source, position) }
 | 
			
		||||
 | 
			
		||||
                root.setOnClickListener {
 | 
			
		||||
                    repository.setSelectedSource(source)
 | 
			
		||||
                    app.startActivity(Intent(app, UpsertSourceActivity::class.java))
 | 
			
		||||
                }
 | 
			
		||||
            }
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        private fun showDeleteConfirmationDialog(
 | 
			
		||||
            source: SelfossModel.SourceDetail,
 | 
			
		||||
            position: Int,
 | 
			
		||||
        ) {
 | 
			
		||||
            AlertDialog
 | 
			
		||||
                .Builder(app)
 | 
			
		||||
                .setTitle(app.getString(R.string.confirm_delete_title))
 | 
			
		||||
                .setMessage(app.getString(R.string.confirm_delete_message, source.title))
 | 
			
		||||
                .setPositiveButton(android.R.string.ok) { _, _ -> deleteSource(source, position) }
 | 
			
		||||
                .setNegativeButton(android.R.string.cancel, null)
 | 
			
		||||
                .show()
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        private fun deleteSource(
 | 
			
		||||
            source: SelfossModel.SourceDetail,
 | 
			
		||||
            position: Int,
 | 
			
		||||
        ) {
 | 
			
		||||
            CoroutineScope(Dispatchers.IO).launch {
 | 
			
		||||
                val successfullyDeletedSource = repository.deleteSource(source.id, source.title)
 | 
			
		||||
                launch(Dispatchers.Main) {
 | 
			
		||||
                    if (successfullyDeletedSource) {
 | 
			
		||||
                        items.removeAt(position)
 | 
			
		||||
                        notifyItemRemoved(position)
 | 
			
		||||
                        notifyItemRangeChanged(position, itemCount)
 | 
			
		||||
                    } else {
 | 
			
		||||
                        Toast
 | 
			
		||||
                            .makeText(
 | 
			
		||||
                                app,
 | 
			
		||||
                                R.string.can_delete_source,
 | 
			
		||||
                                Toast.LENGTH_SHORT,
 | 
			
		||||
                            ).show()
 | 
			
		||||
                    }
 | 
			
		||||
                }
 | 
			
		||||
            }
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
 
 | 
			
		||||
@@ -33,14 +33,16 @@ import bou.amine.apps.readerforselfossv2.android.utils.glide.bitmapFitCenter
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.utils.glide.getBitmapInputStream
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.utils.glide.getGlideImageForResource
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.utils.isUrlValid
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.utils.maybeIfContext
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.utils.openItemUrlInBrowserAsNewTask
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.utils.openUrlInBrowser
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.utils.openUrlInBrowserAsNewTask
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.utils.shareLink
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.model.MercuryModel
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.model.SelfossModel
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.repository.Repository
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.rest.MercuryApi
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.service.AppSettingsService
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.service.ConnectivityService
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.utils.getHtmlDecoded
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.utils.getImages
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.utils.getThumbnail
 | 
			
		||||
@@ -74,7 +76,7 @@ class ArticleFragment :
 | 
			
		||||
    private var colorSurface: Int = 0
 | 
			
		||||
    private var fontSize: Int = DEFAULT_FONT_SIZE
 | 
			
		||||
    private lateinit var item: SelfossModel.Item
 | 
			
		||||
    private lateinit var url: String
 | 
			
		||||
    private var url: String? = null
 | 
			
		||||
    private lateinit var contentText: String
 | 
			
		||||
    private lateinit var contentSource: String
 | 
			
		||||
    private lateinit var contentImage: String
 | 
			
		||||
@@ -87,6 +89,7 @@ class ArticleFragment :
 | 
			
		||||
    override val di: DI by closestDI()
 | 
			
		||||
    private val repository: Repository by instance()
 | 
			
		||||
    private val appSettingsService: AppSettingsService by instance()
 | 
			
		||||
    private val connectivityService: ConnectivityService by instance()
 | 
			
		||||
 | 
			
		||||
    private var typeface: Typeface? = null
 | 
			
		||||
    private var resId: Int = 0
 | 
			
		||||
@@ -117,8 +120,8 @@ class ArticleFragment :
 | 
			
		||||
                e.sendSilentlyWithAcra()
 | 
			
		||||
            }
 | 
			
		||||
 | 
			
		||||
            colorOnSurface = requireContext().getColorFromAttr(R.attr.colorOnSurface)
 | 
			
		||||
            colorSurface = requireContext().getColorFromAttr(R.attr.colorSurface)
 | 
			
		||||
            colorOnSurface = getColorFromAttr(com.google.android.material.R.attr.colorOnSurface)
 | 
			
		||||
            colorSurface = getColorFromAttr(com.google.android.material.R.attr.colorSurface)
 | 
			
		||||
 | 
			
		||||
            contentText = item.content
 | 
			
		||||
            contentTitle = item.title.getHtmlDecoded()
 | 
			
		||||
@@ -147,11 +150,11 @@ class ArticleFragment :
 | 
			
		||||
            handleContent()
 | 
			
		||||
        } catch (e: InflateException) {
 | 
			
		||||
            e.sendSilentlyWithAcraWithName("webview not available")
 | 
			
		||||
            try {
 | 
			
		||||
            maybeIfContext {
 | 
			
		||||
                AlertDialog
 | 
			
		||||
                    .Builder(requireContext())
 | 
			
		||||
                    .setMessage(requireContext().getString(R.string.webview_dialog_issue_message))
 | 
			
		||||
                    .setTitle(requireContext().getString(R.string.webview_dialog_issue_title))
 | 
			
		||||
                    .Builder(it)
 | 
			
		||||
                    .setMessage(it.getString(R.string.webview_dialog_issue_message))
 | 
			
		||||
                    .setTitle(it.getString(R.string.webview_dialog_issue_title))
 | 
			
		||||
                    .setPositiveButton(
 | 
			
		||||
                        android.R.string.ok,
 | 
			
		||||
                    ) { _, _ ->
 | 
			
		||||
@@ -159,8 +162,6 @@ class ArticleFragment :
 | 
			
		||||
                        requireActivity().finish()
 | 
			
		||||
                    }.create()
 | 
			
		||||
                    .show()
 | 
			
		||||
            } catch (e: IllegalStateException) {
 | 
			
		||||
                e.sendSilentlyWithAcraWithName("Context required is null")
 | 
			
		||||
            }
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
@@ -169,8 +170,8 @@ class ArticleFragment :
 | 
			
		||||
 | 
			
		||||
    private fun handleContent() {
 | 
			
		||||
        if (contentText.isEmptyOrNullOrNullString()) {
 | 
			
		||||
            if (repository.isNetworkAvailable()) {
 | 
			
		||||
                getContentFromMercury()
 | 
			
		||||
            if (connectivityService.isNetworkAvailable() && url.isUrlValid()) {
 | 
			
		||||
                getContentFromMercury(url!!)
 | 
			
		||||
            }
 | 
			
		||||
        } else {
 | 
			
		||||
            binding.titleView.text = contentTitle
 | 
			
		||||
@@ -182,7 +183,7 @@ class ArticleFragment :
 | 
			
		||||
 | 
			
		||||
            if (!contentImage.isEmptyOrNullOrNullString() && context != null) {
 | 
			
		||||
                binding.imageView.visibility = View.VISIBLE
 | 
			
		||||
                requireContext().bitmapFitCenter(contentImage, binding.imageView, appSettingsService)
 | 
			
		||||
                maybeIfContext { it.bitmapFitCenter(contentImage, binding.imageView, appSettingsService) }
 | 
			
		||||
            } else {
 | 
			
		||||
                binding.imageView.visibility = View.GONE
 | 
			
		||||
            }
 | 
			
		||||
@@ -194,39 +195,39 @@ class ArticleFragment :
 | 
			
		||||
        fab.mainFabClosedIconColor = colorOnSurface
 | 
			
		||||
        fab.mainFabOpenedIconColor = colorOnSurface
 | 
			
		||||
 | 
			
		||||
        handleFloatingToolbarActionItems()
 | 
			
		||||
        maybeIfContext { handleFloatingToolbarActionItems(it) }
 | 
			
		||||
 | 
			
		||||
        fab.setOnActionSelectedListener { actionItem ->
 | 
			
		||||
            when (actionItem.id) {
 | 
			
		||||
                R.id.share_action -> requireActivity().shareLink(url, contentTitle)
 | 
			
		||||
                R.id.open_action -> requireActivity().openItemUrlInBrowserAsNewTask(this@ArticleFragment.item)
 | 
			
		||||
                R.id.unread_action ->
 | 
			
		||||
                    try {
 | 
			
		||||
                        if (this@ArticleFragment.item.unread) {
 | 
			
		||||
                            CoroutineScope(Dispatchers.IO).launch {
 | 
			
		||||
                                repository.markAsRead(this@ArticleFragment.item)
 | 
			
		||||
                            }
 | 
			
		||||
                            this@ArticleFragment.item.unread = false
 | 
			
		||||
                    if (this@ArticleFragment.item.unread) {
 | 
			
		||||
                        CoroutineScope(Dispatchers.IO).launch {
 | 
			
		||||
                            repository.markAsRead(this@ArticleFragment.item)
 | 
			
		||||
                        }
 | 
			
		||||
                        this@ArticleFragment.item.unread = false
 | 
			
		||||
                        maybeIfContext {
 | 
			
		||||
                            Toast
 | 
			
		||||
                                .makeText(
 | 
			
		||||
                                    requireContext(),
 | 
			
		||||
                                    it,
 | 
			
		||||
                                    R.string.marked_as_read,
 | 
			
		||||
                                    Toast.LENGTH_LONG,
 | 
			
		||||
                                ).show()
 | 
			
		||||
                        } else {
 | 
			
		||||
                            CoroutineScope(Dispatchers.IO).launch {
 | 
			
		||||
                                repository.unmarkAsRead(this@ArticleFragment.item)
 | 
			
		||||
                            }
 | 
			
		||||
                            this@ArticleFragment.item.unread = true
 | 
			
		||||
                        }
 | 
			
		||||
                    } else {
 | 
			
		||||
                        CoroutineScope(Dispatchers.IO).launch {
 | 
			
		||||
                            repository.unmarkAsRead(this@ArticleFragment.item)
 | 
			
		||||
                        }
 | 
			
		||||
                        this@ArticleFragment.item.unread = true
 | 
			
		||||
                        maybeIfContext {
 | 
			
		||||
                            Toast
 | 
			
		||||
                                .makeText(
 | 
			
		||||
                                    context,
 | 
			
		||||
                                    it,
 | 
			
		||||
                                    R.string.marked_as_unread,
 | 
			
		||||
                                    Toast.LENGTH_LONG,
 | 
			
		||||
                                ).show()
 | 
			
		||||
                        }
 | 
			
		||||
                    } catch (e: IllegalStateException) {
 | 
			
		||||
                        e.sendSilentlyWithAcraWithName("Context required is null")
 | 
			
		||||
                    }
 | 
			
		||||
 | 
			
		||||
                else -> Unit
 | 
			
		||||
@@ -235,14 +236,14 @@ class ArticleFragment :
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private fun handleFloatingToolbarActionItems() {
 | 
			
		||||
    private fun handleFloatingToolbarActionItems(c: Context) {
 | 
			
		||||
        fab.addHomeMadeActionItem(
 | 
			
		||||
            R.id.share_action,
 | 
			
		||||
            resources.getDrawable(R.drawable.ic_share_white_24dp),
 | 
			
		||||
            R.string.reader_action_share,
 | 
			
		||||
            colorOnSurface,
 | 
			
		||||
            colorSurface,
 | 
			
		||||
            requireContext(),
 | 
			
		||||
            c,
 | 
			
		||||
        )
 | 
			
		||||
        fab.addHomeMadeActionItem(
 | 
			
		||||
            R.id.open_action,
 | 
			
		||||
@@ -250,7 +251,7 @@ class ArticleFragment :
 | 
			
		||||
            R.string.reader_action_open,
 | 
			
		||||
            colorOnSurface,
 | 
			
		||||
            colorSurface,
 | 
			
		||||
            requireContext(),
 | 
			
		||||
            c,
 | 
			
		||||
        )
 | 
			
		||||
        fab.addHomeMadeActionItem(
 | 
			
		||||
            R.id.unread_action,
 | 
			
		||||
@@ -258,21 +259,23 @@ class ArticleFragment :
 | 
			
		||||
            R.string.unmark,
 | 
			
		||||
            colorOnSurface,
 | 
			
		||||
            colorSurface,
 | 
			
		||||
            requireContext(),
 | 
			
		||||
            c,
 | 
			
		||||
        )
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private fun refreshAlignment() {
 | 
			
		||||
    fun refreshAlignment() {
 | 
			
		||||
        textAlignment =
 | 
			
		||||
            when (appSettingsService.getActiveAllignment()) {
 | 
			
		||||
                1 -> "justify"
 | 
			
		||||
                2 -> "left"
 | 
			
		||||
                else -> "justify"
 | 
			
		||||
            }
 | 
			
		||||
 | 
			
		||||
        htmlToWebview()
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    @Suppress("detekt:SwallowedException")
 | 
			
		||||
    private fun getContentFromMercury() {
 | 
			
		||||
    private fun getContentFromMercury(url: String) {
 | 
			
		||||
        binding.progressBar.visibility = View.VISIBLE
 | 
			
		||||
 | 
			
		||||
        CoroutineScope(Dispatchers.Main).launch {
 | 
			
		||||
@@ -311,9 +314,11 @@ class ArticleFragment :
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private fun handleLeadImage(leadImageUrl: String?) {
 | 
			
		||||
        if (!leadImageUrl.isNullOrEmpty() && context != null) {
 | 
			
		||||
            binding.imageView.visibility = View.VISIBLE
 | 
			
		||||
            requireContext().bitmapFitCenter(leadImageUrl, binding.imageView, appSettingsService)
 | 
			
		||||
        if (!leadImageUrl.isNullOrEmpty()) {
 | 
			
		||||
            maybeIfContext {
 | 
			
		||||
                binding.imageView.visibility = View.VISIBLE
 | 
			
		||||
                it.bitmapFitCenter(leadImageUrl, binding.imageView, appSettingsService)
 | 
			
		||||
            }
 | 
			
		||||
        } else {
 | 
			
		||||
            binding.imageView.visibility = View.GONE
 | 
			
		||||
        }
 | 
			
		||||
@@ -327,11 +332,10 @@ class ArticleFragment :
 | 
			
		||||
                    view: WebView?,
 | 
			
		||||
                    url: String,
 | 
			
		||||
                ): Boolean =
 | 
			
		||||
                    if (context != null &&
 | 
			
		||||
                        url.isUrlValid() &&
 | 
			
		||||
                    if (url.isUrlValid() &&
 | 
			
		||||
                        binding.webcontent.hitTestResult.type != WebView.HitTestResult.SRC_IMAGE_ANCHOR_TYPE
 | 
			
		||||
                    ) {
 | 
			
		||||
                        requireContext().openUrlInBrowser(url)
 | 
			
		||||
                        maybeIfContext { it.openUrlInBrowserAsNewTask(url) }
 | 
			
		||||
                        true
 | 
			
		||||
                    } else {
 | 
			
		||||
                        false
 | 
			
		||||
@@ -374,23 +378,14 @@ class ArticleFragment :
 | 
			
		||||
 | 
			
		||||
    @Suppress("detekt:LongMethod", "detekt:ImplicitDefaultLocale")
 | 
			
		||||
    private fun htmlToWebview() {
 | 
			
		||||
        val context: Context
 | 
			
		||||
        try {
 | 
			
		||||
            context = requireContext()
 | 
			
		||||
        } catch (e: IllegalStateException) {
 | 
			
		||||
            e.sendSilentlyWithAcraWithName("Context required is null")
 | 
			
		||||
            return
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        try {
 | 
			
		||||
        maybeIfContext {
 | 
			
		||||
            val attrs: IntArray = intArrayOf(android.R.attr.fontFamily)
 | 
			
		||||
            val a: TypedArray = context.obtainStyledAttributes(resId, attrs)
 | 
			
		||||
            val a: TypedArray = it.obtainStyledAttributes(resId, attrs)
 | 
			
		||||
 | 
			
		||||
            binding.webcontent.settings.standardFontFamily = a.getString(0)
 | 
			
		||||
            binding.webcontent.visibility = View.VISIBLE
 | 
			
		||||
        } catch (e: IllegalStateException) {
 | 
			
		||||
            e.sendSilentlyWithAcraWithName("Context issue when setting attributes, but context wasn't null before")
 | 
			
		||||
            ""
 | 
			
		||||
        }
 | 
			
		||||
        binding.webcontent.visibility = View.VISIBLE
 | 
			
		||||
 | 
			
		||||
        val colorSurfaceString =
 | 
			
		||||
            String.format(
 | 
			
		||||
@@ -404,13 +399,12 @@ class ArticleFragment :
 | 
			
		||||
                WHITE_COLOR_HEX and (if (colorOnSurface != DATA_NULL_UNDEFINED) colorOnSurface else 0),
 | 
			
		||||
            )
 | 
			
		||||
 | 
			
		||||
        binding.webcontent.settings.useWideViewPort = true
 | 
			
		||||
        binding.webcontent.settings.loadWithOverviewMode = true
 | 
			
		||||
        binding.webcontent.settings.javaScriptEnabled = false
 | 
			
		||||
 | 
			
		||||
        handleImageLoading()
 | 
			
		||||
        try {
 | 
			
		||||
            binding.webcontent.settings.useWideViewPort = true
 | 
			
		||||
            binding.webcontent.settings.loadWithOverviewMode = true
 | 
			
		||||
            binding.webcontent.settings.javaScriptEnabled = false
 | 
			
		||||
 | 
			
		||||
            handleImageLoading()
 | 
			
		||||
 | 
			
		||||
            val gestureDetector =
 | 
			
		||||
                GestureDetector(
 | 
			
		||||
                    activity,
 | 
			
		||||
@@ -424,49 +418,50 @@ class ArticleFragment :
 | 
			
		||||
                    event,
 | 
			
		||||
                )
 | 
			
		||||
            }
 | 
			
		||||
 | 
			
		||||
            binding.webcontent.settings.layoutAlgorithm =
 | 
			
		||||
                WebSettings.LayoutAlgorithm.TEXT_AUTOSIZING
 | 
			
		||||
        } catch (e: IllegalStateException) {
 | 
			
		||||
            e.sendSilentlyWithAcraWithName("Context is null but wasn't, and that's causing issues with webview config")
 | 
			
		||||
            e.sendSilentlyWithAcraWithName("Gesture detector issue ?")
 | 
			
		||||
            return
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        try {
 | 
			
		||||
            var baseUrl: String? = null
 | 
			
		||||
            try {
 | 
			
		||||
                val itemUrl = URL(url)
 | 
			
		||||
                baseUrl = itemUrl.protocol + "://" + itemUrl.host
 | 
			
		||||
            } catch (e: MalformedURLException) {
 | 
			
		||||
                e.sendSilentlyWithAcraWithName("htmlToWebview > $url")
 | 
			
		||||
            }
 | 
			
		||||
        binding.webcontent.settings.layoutAlgorithm =
 | 
			
		||||
            WebSettings.LayoutAlgorithm.TEXT_AUTOSIZING
 | 
			
		||||
 | 
			
		||||
            val fontName =
 | 
			
		||||
        var baseUrl: String? = null
 | 
			
		||||
        try {
 | 
			
		||||
            val itemUrl = URL(url.orEmpty())
 | 
			
		||||
            baseUrl = itemUrl.protocol + "://" + itemUrl.host
 | 
			
		||||
        } catch (e: MalformedURLException) {
 | 
			
		||||
            e.sendSilentlyWithAcraWithName("htmlToWebview > ${url.orEmpty()}")
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        val fontName: String =
 | 
			
		||||
            maybeIfContext {
 | 
			
		||||
                when (font) {
 | 
			
		||||
                    getString(R.string.open_sans_font_id) -> "Open Sans"
 | 
			
		||||
                    getString(R.string.roboto_font_id) -> "Roboto"
 | 
			
		||||
                    getString(R.string.source_code_pro_font_id) -> "Source Code Pro"
 | 
			
		||||
                    it.getString(R.string.open_sans_font_id) -> "Open Sans"
 | 
			
		||||
                    it.getString(R.string.roboto_font_id) -> "Roboto"
 | 
			
		||||
                    it.getString(R.string.source_code_pro_font_id) -> "Source Code Pro"
 | 
			
		||||
                    else -> ""
 | 
			
		||||
                }
 | 
			
		||||
            }?.toString().orEmpty()
 | 
			
		||||
 | 
			
		||||
            val fontLinkAndStyle =
 | 
			
		||||
                if (font.isNotEmpty()) {
 | 
			
		||||
                    """<link href="https://fonts.googleapis.com/css?family=${
 | 
			
		||||
                        fontName.replace(
 | 
			
		||||
                            " ",
 | 
			
		||||
                            "+",
 | 
			
		||||
                        )
 | 
			
		||||
                    }" rel="stylesheet">
 | 
			
		||||
        val fontLinkAndStyle =
 | 
			
		||||
            if (fontName.isNotEmpty()) {
 | 
			
		||||
                """<link href="https://fonts.googleapis.com/css?family=${
 | 
			
		||||
                    fontName.replace(
 | 
			
		||||
                        " ",
 | 
			
		||||
                        "+",
 | 
			
		||||
                    )
 | 
			
		||||
                }" rel="stylesheet">
 | 
			
		||||
                |<style>
 | 
			
		||||
                |   * {
 | 
			
		||||
                |       font-family: '$fontName';
 | 
			
		||||
                |   }
 | 
			
		||||
                |</style>
 | 
			
		||||
                    """.trimMargin()
 | 
			
		||||
                } else {
 | 
			
		||||
                    ""
 | 
			
		||||
                }
 | 
			
		||||
 | 
			
		||||
                """.trimMargin()
 | 
			
		||||
            } else {
 | 
			
		||||
                ""
 | 
			
		||||
            }
 | 
			
		||||
        try {
 | 
			
		||||
            binding.webcontent.loadDataWithBaseURL(
 | 
			
		||||
                baseUrl,
 | 
			
		||||
                """<html>
 | 
			
		||||
@@ -483,7 +478,7 @@ class ArticleFragment :
 | 
			
		||||
                |        color: ${
 | 
			
		||||
                    String.format(
 | 
			
		||||
                        "#%06X",
 | 
			
		||||
                        WHITE_COLOR_HEX and context.resources.getColor(R.color.colorAccent),
 | 
			
		||||
                        WHITE_COLOR_HEX and (maybeIfContext { it.resources.getColor(R.color.colorAccent) } as Int),
 | 
			
		||||
                    )
 | 
			
		||||
                } !important;
 | 
			
		||||
                |      }
 | 
			
		||||
@@ -540,10 +535,8 @@ class ArticleFragment :
 | 
			
		||||
 | 
			
		||||
    private fun openInBrowserAfterFailing() {
 | 
			
		||||
        binding.progressBar.visibility = View.GONE
 | 
			
		||||
        try {
 | 
			
		||||
            requireContext().openItemUrlInBrowserAsNewTask(this@ArticleFragment.item)
 | 
			
		||||
        } catch (e: IllegalStateException) {
 | 
			
		||||
            e.sendSilentlyWithAcraWithName("Context required is null")
 | 
			
		||||
        maybeIfContext {
 | 
			
		||||
            it.openItemUrlInBrowserAsNewTask(this@ArticleFragment.item)
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
 
 | 
			
		||||
@@ -1,6 +1,5 @@
 | 
			
		||||
package bou.amine.apps.readerforselfossv2.android.fragments
 | 
			
		||||
 | 
			
		||||
import android.content.Context
 | 
			
		||||
import android.graphics.Color
 | 
			
		||||
import android.graphics.drawable.Drawable
 | 
			
		||||
import android.graphics.drawable.GradientDrawable
 | 
			
		||||
@@ -15,8 +14,10 @@ import android.view.ViewGroup
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.HomeActivity
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.R
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.databinding.FilterFragmentBinding
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.testing.CountingIdlingResourceSingleton
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.utils.acra.sendSilentlyWithAcraWithName
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.utils.glide.imageIntoViewTarget
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.utils.maybeIfContext
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.repository.Repository
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.service.AppSettingsService
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.utils.getColorHexCode
 | 
			
		||||
@@ -59,12 +60,14 @@ class FilterSheetFragment :
 | 
			
		||||
            )
 | 
			
		||||
 | 
			
		||||
        try {
 | 
			
		||||
            CountingIdlingResourceSingleton.increment()
 | 
			
		||||
            CoroutineScope(Dispatchers.Main).launch {
 | 
			
		||||
                handleTagChips(requireContext())
 | 
			
		||||
                handleSourceChips(requireContext())
 | 
			
		||||
                handleTagChips()
 | 
			
		||||
                handleSourceChips()
 | 
			
		||||
 | 
			
		||||
                binding.progressBar2.visibility = GONE
 | 
			
		||||
                binding.filterView.visibility = VISIBLE
 | 
			
		||||
                CountingIdlingResourceSingleton.decrement()
 | 
			
		||||
            }
 | 
			
		||||
        } catch (e: IllegalStateException) {
 | 
			
		||||
            dismiss()
 | 
			
		||||
@@ -79,29 +82,39 @@ class FilterSheetFragment :
 | 
			
		||||
        return binding.root
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private suspend fun handleSourceChips(context: Context) {
 | 
			
		||||
    private suspend fun handleSourceChips() {
 | 
			
		||||
        val sourceGroup = binding.sourcesGroup
 | 
			
		||||
 | 
			
		||||
        repository.getSourcesDetailsOrStats().forEachIndexed { _, source ->
 | 
			
		||||
            val c = Chip(context)
 | 
			
		||||
            val c: Chip? =
 | 
			
		||||
                maybeIfContext {
 | 
			
		||||
                    Chip(it)
 | 
			
		||||
                } as Chip?
 | 
			
		||||
 | 
			
		||||
            if (c == null) {
 | 
			
		||||
                return
 | 
			
		||||
            }
 | 
			
		||||
 | 
			
		||||
            c.ellipsize = TextUtils.TruncateAt.END
 | 
			
		||||
 | 
			
		||||
            context.imageIntoViewTarget(
 | 
			
		||||
                source.getIcon(repository.baseUrl),
 | 
			
		||||
                object : ViewTarget<Chip?, Drawable?>(c) {
 | 
			
		||||
                    override fun onResourceReady(
 | 
			
		||||
                        resource: Drawable,
 | 
			
		||||
                        transition: Transition<in Drawable?>?,
 | 
			
		||||
                    ) {
 | 
			
		||||
                        try {
 | 
			
		||||
                            c.chipIcon = resource
 | 
			
		||||
                        } catch (e: Exception) {
 | 
			
		||||
                            e.sendSilentlyWithAcraWithName("sources > onResourceReady")
 | 
			
		||||
            maybeIfContext {
 | 
			
		||||
                it.imageIntoViewTarget(
 | 
			
		||||
                    source.getIcon(repository.baseUrl),
 | 
			
		||||
                    object : ViewTarget<Chip?, Drawable?>(c) {
 | 
			
		||||
                        override fun onResourceReady(
 | 
			
		||||
                            resource: Drawable,
 | 
			
		||||
                            transition: Transition<in Drawable?>?,
 | 
			
		||||
                        ) {
 | 
			
		||||
                            try {
 | 
			
		||||
                                c.chipIcon = resource
 | 
			
		||||
                            } catch (e: Exception) {
 | 
			
		||||
                                e.sendSilentlyWithAcraWithName("sources > onResourceReady")
 | 
			
		||||
                            }
 | 
			
		||||
                        }
 | 
			
		||||
                    }
 | 
			
		||||
                },
 | 
			
		||||
                appSettingsService,
 | 
			
		||||
            )
 | 
			
		||||
                    },
 | 
			
		||||
                    appSettingsService,
 | 
			
		||||
                )
 | 
			
		||||
            }
 | 
			
		||||
 | 
			
		||||
            c.text = source.title.getHtmlDecoded()
 | 
			
		||||
 | 
			
		||||
@@ -137,13 +150,17 @@ class FilterSheetFragment :
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private suspend fun handleTagChips(context: Context) {
 | 
			
		||||
    private suspend fun handleTagChips() {
 | 
			
		||||
        val tagGroup = binding.tagsGroup
 | 
			
		||||
 | 
			
		||||
        val tags = repository.getTags()
 | 
			
		||||
 | 
			
		||||
        tags.forEachIndexed { _, tag ->
 | 
			
		||||
            val c = Chip(context)
 | 
			
		||||
            val c: Chip? = maybeIfContext { Chip(it) } as Chip?
 | 
			
		||||
            if (c == null) {
 | 
			
		||||
                return
 | 
			
		||||
            }
 | 
			
		||||
 | 
			
		||||
            c.ellipsize = TextUtils.TruncateAt.END
 | 
			
		||||
            c.text = tag.tag
 | 
			
		||||
 | 
			
		||||
 
 | 
			
		||||
@@ -5,39 +5,57 @@ import android.content.Intent
 | 
			
		||||
import android.util.TypedValue
 | 
			
		||||
import androidx.annotation.AttrRes
 | 
			
		||||
import androidx.annotation.ColorInt
 | 
			
		||||
import androidx.fragment.app.Fragment
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.R
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.utils.acra.sendSilentlyWithAcraWithName
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.utils.toStringUriWithHttp
 | 
			
		||||
 | 
			
		||||
fun Context.shareLink(
 | 
			
		||||
    itemUrl: String,
 | 
			
		||||
    itemUrl: String?,
 | 
			
		||||
    itemTitle: String,
 | 
			
		||||
) {
 | 
			
		||||
    val sendIntent = Intent()
 | 
			
		||||
    sendIntent.flags = Intent.FLAG_ACTIVITY_NEW_TASK
 | 
			
		||||
    sendIntent.action = Intent.ACTION_SEND
 | 
			
		||||
    sendIntent.putExtra(Intent.EXTRA_TEXT, itemUrl.toStringUriWithHttp())
 | 
			
		||||
    sendIntent.putExtra(Intent.EXTRA_SUBJECT, itemTitle)
 | 
			
		||||
    sendIntent.type = "text/plain"
 | 
			
		||||
    startActivity(
 | 
			
		||||
        Intent
 | 
			
		||||
            .createChooser(
 | 
			
		||||
                sendIntent,
 | 
			
		||||
                getString(R.string.share),
 | 
			
		||||
            ).setFlags(Intent.FLAG_ACTIVITY_NEW_TASK),
 | 
			
		||||
    )
 | 
			
		||||
    if (itemUrl.isUrlValid()) {
 | 
			
		||||
        val sendIntent = Intent()
 | 
			
		||||
        sendIntent.flags = Intent.FLAG_ACTIVITY_NEW_TASK
 | 
			
		||||
        sendIntent.action = Intent.ACTION_SEND
 | 
			
		||||
        sendIntent.putExtra(Intent.EXTRA_TEXT, itemUrl!!.toStringUriWithHttp())
 | 
			
		||||
        sendIntent.putExtra(Intent.EXTRA_SUBJECT, itemTitle)
 | 
			
		||||
        sendIntent.type = "text/plain"
 | 
			
		||||
        startActivity(
 | 
			
		||||
            Intent
 | 
			
		||||
                .createChooser(
 | 
			
		||||
                    sendIntent,
 | 
			
		||||
                    getString(R.string.share),
 | 
			
		||||
                ).setFlags(Intent.FLAG_ACTIVITY_NEW_TASK),
 | 
			
		||||
        )
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
@ColorInt
 | 
			
		||||
fun Context.getColorFromAttr(
 | 
			
		||||
fun Fragment.getColorFromAttr(
 | 
			
		||||
    @AttrRes attrColor: Int,
 | 
			
		||||
    resolveRefs: Boolean = true,
 | 
			
		||||
): Int {
 | 
			
		||||
    val typedValue = TypedValue()
 | 
			
		||||
    try {
 | 
			
		||||
        this.theme.resolveAttribute(attrColor, typedValue, resolveRefs)
 | 
			
		||||
    } catch (e: Throwable) {
 | 
			
		||||
        e.sendSilentlyWithAcraWithName("ColorFromAttr")
 | 
			
		||||
    }
 | 
			
		||||
    maybeIfContextWithLog { this.requireContext().theme.resolveAttribute(attrColor, typedValue, resolveRefs) }
 | 
			
		||||
    return typedValue.data
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
@Suppress("detekt:SwallowedException")
 | 
			
		||||
fun Fragment.maybeIfContext(fn: (Context) -> Any): Any? {
 | 
			
		||||
    try {
 | 
			
		||||
        return fn(this.requireContext())
 | 
			
		||||
    } catch (e: Exception) {
 | 
			
		||||
        // Do nothing
 | 
			
		||||
        return null
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
fun Fragment.maybeIfContextWithLog(fn: (Context) -> Any): Any? {
 | 
			
		||||
    try {
 | 
			
		||||
        return fn(this.requireContext())
 | 
			
		||||
    } catch (e: Exception) {
 | 
			
		||||
        e.sendSilentlyWithAcraWithName("Fragment context issue...")
 | 
			
		||||
        return null
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
 
 | 
			
		||||
@@ -15,12 +15,12 @@ import android.widget.Toast
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.R
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.android.ReaderActivity
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.model.SelfossModel
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.utils.toStringUriWithHttp
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.utils.isEmptyOrNullOrNullString
 | 
			
		||||
import okhttp3.HttpUrl.Companion.toHttpUrlOrNull
 | 
			
		||||
 | 
			
		||||
fun Context.openItemUrl(
 | 
			
		||||
    currentItem: Int,
 | 
			
		||||
    linkDecoded: String,
 | 
			
		||||
    linkDecoded: String?,
 | 
			
		||||
    articleViewer: Boolean,
 | 
			
		||||
    app: Activity,
 | 
			
		||||
) {
 | 
			
		||||
@@ -37,12 +37,13 @@ fun Context.openItemUrl(
 | 
			
		||||
            intent.putExtra("currentItem", currentItem)
 | 
			
		||||
            app.startActivity(intent)
 | 
			
		||||
        } else {
 | 
			
		||||
            this.openUrlInBrowserAsNewTask(linkDecoded)
 | 
			
		||||
            this.openUrlInBrowserAsNewTask(linkDecoded!!)
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
fun String.isUrlValid(): Boolean = this.toHttpUrlOrNull() != null && Patterns.WEB_URL.matcher(this).matches()
 | 
			
		||||
fun String?.isUrlValid(): Boolean =
 | 
			
		||||
    !this.isEmptyOrNullOrNullString() && this!!.toHttpUrlOrNull() != null && Patterns.WEB_URL.matcher(this).matches()
 | 
			
		||||
 | 
			
		||||
fun String.isBaseUrlInvalid(): Boolean {
 | 
			
		||||
    val baseUrl = this.toHttpUrlOrNull()
 | 
			
		||||
@@ -56,14 +57,16 @@ fun String.isBaseUrlInvalid(): Boolean {
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
fun Context.openItemUrlInBrowserAsNewTask(i: SelfossModel.Item) {
 | 
			
		||||
    this.openUrlInBrowserAsNewTask(i.getLinkDecoded().toStringUriWithHttp())
 | 
			
		||||
    this.openUrlInBrowserAsNewTask(i.getLinkDecoded())
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
fun Context.openUrlInBrowserAsNewTask(url: String) {
 | 
			
		||||
    val intent = Intent(Intent.ACTION_VIEW)
 | 
			
		||||
    intent.flags = Intent.FLAG_ACTIVITY_NEW_TASK
 | 
			
		||||
    intent.data = Uri.parse(url)
 | 
			
		||||
    this.mayBeStartActivity(intent)
 | 
			
		||||
fun Context.openUrlInBrowserAsNewTask(url: String?) {
 | 
			
		||||
    if (url.isUrlValid()) {
 | 
			
		||||
        val intent = Intent(Intent.ACTION_VIEW)
 | 
			
		||||
        intent.flags = Intent.FLAG_ACTIVITY_NEW_TASK
 | 
			
		||||
        intent.data = Uri.parse(url)
 | 
			
		||||
        this.mayBeStartActivity(intent)
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
fun Context.openUrlInBrowser(url: String) {
 | 
			
		||||
 
 | 
			
		||||
@@ -22,5 +22,5 @@ class AcraReportingAdministrator : ReportingAdministrator {
 | 
			
		||||
        context: Context,
 | 
			
		||||
        config: CoreConfiguration,
 | 
			
		||||
        crashReportData: CrashReportData,
 | 
			
		||||
    ): Boolean = crashReportData.get("BRAND") != "redroid"
 | 
			
		||||
    ): Boolean = crashReportData.get("BRAND") != "redroid" && !crashReportData.get("PHONE_MODEL").toString().startsWith("sdk_gphone")
 | 
			
		||||
}
 | 
			
		||||
 
 | 
			
		||||
@@ -23,10 +23,11 @@ import kotlin.io.encoding.ExperimentalEncodingApi
 | 
			
		||||
 | 
			
		||||
private const val PRELOAD_IMAGE_TIMEOUT = 10000
 | 
			
		||||
 | 
			
		||||
@Suppress("detekt:ReturnCount")
 | 
			
		||||
@OptIn(ExperimentalEncodingApi::class)
 | 
			
		||||
fun String.toGlideUrl(appSettingsService: AppSettingsService): GlideUrl {
 | 
			
		||||
fun String.toGlideUrl(appSettingsService: AppSettingsService): Any { // GlideUrl Or String
 | 
			
		||||
    if (this.isEmptyOrNullOrNullString()) {
 | 
			
		||||
        return GlideUrl("")
 | 
			
		||||
        return ""
 | 
			
		||||
    }
 | 
			
		||||
    if (appSettingsService.getBasicUserName().isNotEmpty()) {
 | 
			
		||||
        val authString = "${appSettingsService.getBasicUserName()}:${appSettingsService.getBasicPassword()}"
 | 
			
		||||
 
 | 
			
		||||
@@ -1,32 +0,0 @@
 | 
			
		||||
package bou.amine.apps.readerforselfossv2.android.viewmodel
 | 
			
		||||
 | 
			
		||||
import androidx.lifecycle.ViewModel
 | 
			
		||||
import androidx.lifecycle.viewModelScope
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.repository.Repository
 | 
			
		||||
import kotlinx.coroutines.flow.MutableSharedFlow
 | 
			
		||||
import kotlinx.coroutines.flow.asSharedFlow
 | 
			
		||||
import kotlinx.coroutines.launch
 | 
			
		||||
 | 
			
		||||
class AppViewModel(
 | 
			
		||||
    private val repository: Repository,
 | 
			
		||||
) : ViewModel() {
 | 
			
		||||
    private val _networkAvailableProvider = MutableSharedFlow<Boolean>()
 | 
			
		||||
    val networkAvailableProvider = _networkAvailableProvider.asSharedFlow()
 | 
			
		||||
    private var wasConnected = true
 | 
			
		||||
 | 
			
		||||
    init {
 | 
			
		||||
        viewModelScope.launch {
 | 
			
		||||
            repository.isConnectionAvailable.collect { isConnected ->
 | 
			
		||||
                if (repository.connectionMonitored) {
 | 
			
		||||
                    if (isConnected && !wasConnected && repository.connectionMonitored) {
 | 
			
		||||
                        _networkAvailableProvider.emit(true)
 | 
			
		||||
                        wasConnected = true
 | 
			
		||||
                    } else if (!isConnected && wasConnected && repository.connectionMonitored) {
 | 
			
		||||
                        _networkAvailableProvider.emit(false)
 | 
			
		||||
                        wasConnected = false
 | 
			
		||||
                    }
 | 
			
		||||
                }
 | 
			
		||||
            }
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
@@ -24,7 +24,6 @@
 | 
			
		||||
    <string name="all_posts_not_read">"No s'han llegit totes les publicacions"</string>
 | 
			
		||||
    <string name="all_posts_read">"S'han llegit totes les publicacions"</string>
 | 
			
		||||
    <string name="undo_string">"Desfés"</string>
 | 
			
		||||
    <string name="addStringNoUrl">"Inicieu la sessió per afegir fonts."</string>
 | 
			
		||||
    <string name="cant_get_sources">"No es pot obtenir la llista de fonts."</string>
 | 
			
		||||
    <string name="cant_create_source">"No es pot crear la font."</string>
 | 
			
		||||
    <string name="cant_get_spouts_no_network">"Can't get spouts list because of a network issue."</string>
 | 
			
		||||
@@ -107,7 +106,6 @@
 | 
			
		||||
    <string name="reader_text_align_justify">Justify</string>
 | 
			
		||||
    <string name="settings_reader_font">Reader font</string>
 | 
			
		||||
    <string name="remove_source">Remove source</string>
 | 
			
		||||
    <string name="pref_theme_title">Light/Dark mode</string>
 | 
			
		||||
    <string name="mode_dark">Dark mode</string>
 | 
			
		||||
    <string name="mode_system">Follow the system setting</string>
 | 
			
		||||
    <string name="mode_light">Light mode</string>
 | 
			
		||||
@@ -129,4 +127,6 @@
 | 
			
		||||
    <string name="action_about">"Quant a"</string>
 | 
			
		||||
    <string name="marked_as_read">"Element llegit"</string>
 | 
			
		||||
    <string name="marked_as_unread">"Item unread"</string>
 | 
			
		||||
    <string name="confirm_delete_title">Confirm Deletion</string>
 | 
			
		||||
    <string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
 | 
			
		||||
</resources>
 | 
			
		||||
 
 | 
			
		||||
@@ -24,7 +24,6 @@
 | 
			
		||||
    <string name="all_posts_not_read">"Nicht alle Beiträge wurden gelesen"</string>
 | 
			
		||||
    <string name="all_posts_read">"Alle Beiträge wurden gelesen"</string>
 | 
			
		||||
    <string name="undo_string">"Rückgängig"</string>
 | 
			
		||||
    <string name="addStringNoUrl">"Melde dich an um Quellen hinzuzufügen."</string>
 | 
			
		||||
    <string name="cant_get_sources">"Quellen können nicht abgerufen werden."</string>
 | 
			
		||||
    <string name="cant_create_source">"Quelle kann nicht gespeichert werden."</string>
 | 
			
		||||
    <string name="cant_get_spouts_no_network">"Fehler beim Laden der Spouts-Liste aufgrund von Netzwerkproblemen."</string>
 | 
			
		||||
@@ -107,7 +106,6 @@
 | 
			
		||||
    <string name="reader_text_align_justify">Blocksatz</string>
 | 
			
		||||
    <string name="settings_reader_font">Schriftgröße im Lesemodus</string>
 | 
			
		||||
    <string name="remove_source">Quelle entfernen</string>
 | 
			
		||||
    <string name="pref_theme_title">Heller/Dunkler Modus</string>
 | 
			
		||||
    <string name="mode_dark">Dunkler Modus</string>
 | 
			
		||||
    <string name="mode_system">Systemeinstellungen übernehmen</string>
 | 
			
		||||
    <string name="mode_light">Heller Modus</string>
 | 
			
		||||
@@ -129,4 +127,6 @@
 | 
			
		||||
    <string name="action_about">"Über"</string>
 | 
			
		||||
    <string name="marked_as_read">"Artikel gelesen"</string>
 | 
			
		||||
    <string name="marked_as_unread">"Item unread"</string>
 | 
			
		||||
    <string name="confirm_delete_title">Confirm Deletion</string>
 | 
			
		||||
    <string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
 | 
			
		||||
</resources>
 | 
			
		||||
 
 | 
			
		||||
@@ -24,7 +24,6 @@
 | 
			
		||||
    <string name="all_posts_not_read">"No todas las publicaciones fueron leídas"</string>
 | 
			
		||||
    <string name="all_posts_read">"Todas las publicaciones fueron leídas"</string>
 | 
			
		||||
    <string name="undo_string">"Deshacer"</string>
 | 
			
		||||
    <string name="addStringNoUrl">"Iniciar sesión para añadir fuentes."</string>
 | 
			
		||||
    <string name="cant_get_sources">"No se puede obtener la lista de fuentes."</string>
 | 
			
		||||
    <string name="cant_create_source">"No se puede crear la fuente."</string>
 | 
			
		||||
    <string name="cant_get_spouts_no_network">"Can't get spouts list because of a network issue."</string>
 | 
			
		||||
@@ -107,7 +106,6 @@
 | 
			
		||||
    <string name="reader_text_align_justify">Justificado</string>
 | 
			
		||||
    <string name="settings_reader_font">Modo lectura</string>
 | 
			
		||||
    <string name="remove_source">Remove source</string>
 | 
			
		||||
    <string name="pref_theme_title">Light/Dark mode</string>
 | 
			
		||||
    <string name="mode_dark">Dark mode</string>
 | 
			
		||||
    <string name="mode_system">Follow the system setting</string>
 | 
			
		||||
    <string name="mode_light">Light mode</string>
 | 
			
		||||
@@ -129,4 +127,6 @@
 | 
			
		||||
    <string name="action_about">"Acerca de"</string>
 | 
			
		||||
    <string name="marked_as_read">"Artículo leído"</string>
 | 
			
		||||
    <string name="marked_as_unread">"Artículo no leído"</string>
 | 
			
		||||
    <string name="confirm_delete_title">Confirm Deletion</string>
 | 
			
		||||
    <string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
 | 
			
		||||
</resources>
 | 
			
		||||
 
 | 
			
		||||
@@ -24,7 +24,6 @@
 | 
			
		||||
    <string name="all_posts_not_read">"Tous les posts n'ont pas été lus"</string>
 | 
			
		||||
    <string name="all_posts_read">"Tous les posts sont lus"</string>
 | 
			
		||||
    <string name="undo_string">"Annuler"</string>
 | 
			
		||||
    <string name="addStringNoUrl">"Identifiez-vous pour ajouter une source."</string>
 | 
			
		||||
    <string name="cant_get_sources">"Impossible de récupérer la liste des sources."</string>
 | 
			
		||||
    <string name="cant_create_source">"Impossible de créer la source."</string>
 | 
			
		||||
    <string name="cant_get_spouts_no_network">"Impossible d'obtenir la liste des spouts en raison d'un problème de réseau."</string>
 | 
			
		||||
@@ -107,7 +106,6 @@
 | 
			
		||||
    <string name="reader_text_align_justify">Justifier le texte</string>
 | 
			
		||||
    <string name="settings_reader_font">Police du lecteur d\'articles</string>
 | 
			
		||||
    <string name="remove_source">Supprimer la source</string>
 | 
			
		||||
    <string name="pref_theme_title">Thème Clair/Sombre</string>
 | 
			
		||||
    <string name="mode_dark">Thème sombre</string>
 | 
			
		||||
    <string name="mode_system">Utiliser les paramètres système</string>
 | 
			
		||||
    <string name="mode_light">Thème clair</string>
 | 
			
		||||
@@ -129,4 +127,6 @@
 | 
			
		||||
    <string name="action_about">"À propos"</string>
 | 
			
		||||
    <string name="marked_as_read">"Marqué comme lu"</string>
 | 
			
		||||
    <string name="marked_as_unread">"Marqué comme non lu"</string>
 | 
			
		||||
    <string name="confirm_delete_title">Confirm Deletion</string>
 | 
			
		||||
    <string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
 | 
			
		||||
</resources>
 | 
			
		||||
 
 | 
			
		||||
@@ -24,7 +24,6 @@
 | 
			
		||||
    <string name="all_posts_not_read">"Non se leron todas as publicacións"</string>
 | 
			
		||||
    <string name="all_posts_read">"Leronse todas as publicacións"</string>
 | 
			
		||||
    <string name="undo_string">"Desfacer"</string>
 | 
			
		||||
    <string name="addStringNoUrl">"Accede pra engadir fontes."</string>
 | 
			
		||||
    <string name="cant_get_sources">"Non se pode obter a lista de fontes."</string>
 | 
			
		||||
    <string name="cant_create_source">"Non se pode crear unha fonte."</string>
 | 
			
		||||
    <string name="cant_get_spouts_no_network">"Non se pode obter a lista de spouts por mor dun erro de rede."</string>
 | 
			
		||||
@@ -107,7 +106,6 @@
 | 
			
		||||
    <string name="reader_text_align_justify">Xustificado</string>
 | 
			
		||||
    <string name="settings_reader_font">Modo lector</string>
 | 
			
		||||
    <string name="remove_source">Eliminar fonte</string>
 | 
			
		||||
    <string name="pref_theme_title">Modo Claro/Escuro</string>
 | 
			
		||||
    <string name="mode_dark">Modo escuro</string>
 | 
			
		||||
    <string name="mode_system">Seguir axustes do sistema</string>
 | 
			
		||||
    <string name="mode_light">Modo claro</string>
 | 
			
		||||
@@ -129,4 +127,6 @@
 | 
			
		||||
    <string name="action_about">"Acerca de"</string>
 | 
			
		||||
    <string name="marked_as_read">"Elemento lido"</string>
 | 
			
		||||
    <string name="marked_as_unread">"Elemento non lido"</string>
 | 
			
		||||
    <string name="confirm_delete_title">Confirm Deletion</string>
 | 
			
		||||
    <string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
 | 
			
		||||
</resources>
 | 
			
		||||
 
 | 
			
		||||
@@ -24,7 +24,6 @@
 | 
			
		||||
    <string name="all_posts_not_read">"Semua pos belum dibaca"</string>
 | 
			
		||||
    <string name="all_posts_read">"Semua pos sudah dibaca"</string>
 | 
			
		||||
    <string name="undo_string">"Urung"</string>
 | 
			
		||||
    <string name="addStringNoUrl">"Masuk untuk menambah sumber."</string>
 | 
			
		||||
    <string name="cant_get_sources">"Tidak bisa mendapatkan daftar sumber."</string>
 | 
			
		||||
    <string name="cant_create_source">"Tidak dapat membuat sumber."</string>
 | 
			
		||||
    <string name="cant_get_spouts_no_network">"Can't get spouts list because of a network issue."</string>
 | 
			
		||||
@@ -107,7 +106,6 @@
 | 
			
		||||
    <string name="reader_text_align_justify">Justify</string>
 | 
			
		||||
    <string name="settings_reader_font">Reader font</string>
 | 
			
		||||
    <string name="remove_source">Remove source</string>
 | 
			
		||||
    <string name="pref_theme_title">Light/Dark mode</string>
 | 
			
		||||
    <string name="mode_dark">Dark mode</string>
 | 
			
		||||
    <string name="mode_system">Follow the system setting</string>
 | 
			
		||||
    <string name="mode_light">Light mode</string>
 | 
			
		||||
@@ -129,4 +127,6 @@
 | 
			
		||||
    <string name="action_about">"Tentang"</string>
 | 
			
		||||
    <string name="marked_as_read">"Membaca item"</string>
 | 
			
		||||
    <string name="marked_as_unread">"Item unread"</string>
 | 
			
		||||
    <string name="confirm_delete_title">Confirm Deletion</string>
 | 
			
		||||
    <string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
 | 
			
		||||
</resources>
 | 
			
		||||
 
 | 
			
		||||
@@ -24,7 +24,6 @@
 | 
			
		||||
    <string name="all_posts_not_read">"All posts weren't read"</string>
 | 
			
		||||
    <string name="all_posts_read">"Tutti i messaggi sono stati letti"</string>
 | 
			
		||||
    <string name="undo_string">"Annulla"</string>
 | 
			
		||||
    <string name="addStringNoUrl">"Autenticati per aggiungere fonti."</string>
 | 
			
		||||
    <string name="cant_get_sources">"Can't get sources list."</string>
 | 
			
		||||
    <string name="cant_create_source">"Can't create source."</string>
 | 
			
		||||
    <string name="cant_get_spouts_no_network">"Can't get spouts list because of a network issue."</string>
 | 
			
		||||
@@ -107,7 +106,6 @@
 | 
			
		||||
    <string name="reader_text_align_justify">Justify</string>
 | 
			
		||||
    <string name="settings_reader_font">Reader font</string>
 | 
			
		||||
    <string name="remove_source">Remove source</string>
 | 
			
		||||
    <string name="pref_theme_title">Light/Dark mode</string>
 | 
			
		||||
    <string name="mode_dark">Dark mode</string>
 | 
			
		||||
    <string name="mode_system">Follow the system setting</string>
 | 
			
		||||
    <string name="mode_light">Light mode</string>
 | 
			
		||||
@@ -129,4 +127,6 @@
 | 
			
		||||
    <string name="action_about">"Informazioni"</string>
 | 
			
		||||
    <string name="marked_as_read">"Articolo letto"</string>
 | 
			
		||||
    <string name="marked_as_unread">"Item unread"</string>
 | 
			
		||||
    <string name="confirm_delete_title">Confirm Deletion</string>
 | 
			
		||||
    <string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
 | 
			
		||||
</resources>
 | 
			
		||||
 
 | 
			
		||||
@@ -24,7 +24,6 @@
 | 
			
		||||
    <string name="all_posts_not_read">"모든 게시물을 읽지 않았습니다."</string>
 | 
			
		||||
    <string name="all_posts_read">"모든 게시물을 읽었습니다."</string>
 | 
			
		||||
    <string name="undo_string">"실행 취소"</string>
 | 
			
		||||
    <string name="addStringNoUrl">"로그인 소스를 추가 해야 합니다."</string>
 | 
			
		||||
    <string name="cant_get_sources">"소스 리스트를 얻을 수 없습니다."</string>
 | 
			
		||||
    <string name="cant_create_source">"소스를 만들 수 없습니다."</string>
 | 
			
		||||
    <string name="cant_get_spouts_no_network">"Can't get spouts list because of a network issue."</string>
 | 
			
		||||
@@ -107,7 +106,6 @@
 | 
			
		||||
    <string name="reader_text_align_justify">Justify</string>
 | 
			
		||||
    <string name="settings_reader_font">Reader font</string>
 | 
			
		||||
    <string name="remove_source">Remove source</string>
 | 
			
		||||
    <string name="pref_theme_title">Light/Dark mode</string>
 | 
			
		||||
    <string name="mode_dark">Dark mode</string>
 | 
			
		||||
    <string name="mode_system">Follow the system setting</string>
 | 
			
		||||
    <string name="mode_light">Light mode</string>
 | 
			
		||||
@@ -129,4 +127,6 @@
 | 
			
		||||
    <string name="action_about">"정보"</string>
 | 
			
		||||
    <string name="marked_as_read">"항목 읽기"</string>
 | 
			
		||||
    <string name="marked_as_unread">"Item unread"</string>
 | 
			
		||||
    <string name="confirm_delete_title">Confirm Deletion</string>
 | 
			
		||||
    <string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
 | 
			
		||||
</resources>
 | 
			
		||||
 
 | 
			
		||||
@@ -24,7 +24,6 @@
 | 
			
		||||
    <string name="all_posts_not_read">"Fout bij markeren als gelezen"</string>
 | 
			
		||||
    <string name="all_posts_read">"Alle artikelen gemarkeerd als gelezen"</string>
 | 
			
		||||
    <string name="undo_string">"Ongedaan maken"</string>
 | 
			
		||||
    <string name="addStringNoUrl">"Login om bronnen toe te voegen"</string>
 | 
			
		||||
    <string name="cant_get_sources">"Kan de lijst met bronnen niet ophalen"</string>
 | 
			
		||||
    <string name="cant_create_source">"Kan bron niet creëeren"</string>
 | 
			
		||||
    <string name="cant_get_spouts_no_network">"Can't get spouts list because of a network issue."</string>
 | 
			
		||||
@@ -107,7 +106,6 @@
 | 
			
		||||
    <string name="reader_text_align_justify">Justify</string>
 | 
			
		||||
    <string name="settings_reader_font">Reader font</string>
 | 
			
		||||
    <string name="remove_source">Remove source</string>
 | 
			
		||||
    <string name="pref_theme_title">Light/Dark mode</string>
 | 
			
		||||
    <string name="mode_dark">Dark mode</string>
 | 
			
		||||
    <string name="mode_system">Follow the system setting</string>
 | 
			
		||||
    <string name="mode_light">Light mode</string>
 | 
			
		||||
@@ -129,4 +127,6 @@
 | 
			
		||||
    <string name="action_about">"Over"</string>
 | 
			
		||||
    <string name="marked_as_read">"Artikel gelezen"</string>
 | 
			
		||||
    <string name="marked_as_unread">"Item unread"</string>
 | 
			
		||||
    <string name="confirm_delete_title">Confirm Deletion</string>
 | 
			
		||||
    <string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
 | 
			
		||||
</resources>
 | 
			
		||||
 
 | 
			
		||||
@@ -24,7 +24,6 @@
 | 
			
		||||
    <string name="all_posts_not_read">"Nenhum post foi lido"</string>
 | 
			
		||||
    <string name="all_posts_read">"Todos os posts foram lidos"</string>
 | 
			
		||||
    <string name="undo_string">"Desfazer"</string>
 | 
			
		||||
    <string name="addStringNoUrl">"Faça login para adicionar fontes."</string>
 | 
			
		||||
    <string name="cant_get_sources">"Não é possível obter a lista de fontes."</string>
 | 
			
		||||
    <string name="cant_create_source">"Não é possível criar fonte."</string>
 | 
			
		||||
    <string name="cant_get_spouts_no_network">"Can't get spouts list because of a network issue."</string>
 | 
			
		||||
@@ -107,7 +106,6 @@
 | 
			
		||||
    <string name="reader_text_align_justify">Justify</string>
 | 
			
		||||
    <string name="settings_reader_font">Reader font</string>
 | 
			
		||||
    <string name="remove_source">Remove source</string>
 | 
			
		||||
    <string name="pref_theme_title">Light/Dark mode</string>
 | 
			
		||||
    <string name="mode_dark">Dark mode</string>
 | 
			
		||||
    <string name="mode_system">Follow the system setting</string>
 | 
			
		||||
    <string name="mode_light">Light mode</string>
 | 
			
		||||
@@ -129,4 +127,6 @@
 | 
			
		||||
    <string name="action_about">"Sobre"</string>
 | 
			
		||||
    <string name="marked_as_read">"Item lido"</string>
 | 
			
		||||
    <string name="marked_as_unread">"Item unread"</string>
 | 
			
		||||
    <string name="confirm_delete_title">Confirm Deletion</string>
 | 
			
		||||
    <string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
 | 
			
		||||
</resources>
 | 
			
		||||
 
 | 
			
		||||
@@ -24,7 +24,6 @@
 | 
			
		||||
    <string name="all_posts_not_read">"Todas as postagens não foram lidas"</string>
 | 
			
		||||
    <string name="all_posts_read">"Todas as postagens foram lidas"</string>
 | 
			
		||||
    <string name="undo_string">"Desfazer"</string>
 | 
			
		||||
    <string name="addStringNoUrl">"Logar para adicionar fontes."</string>
 | 
			
		||||
    <string name="cant_get_sources">"Não é possível obter a lista de fontes."</string>
 | 
			
		||||
    <string name="cant_create_source">"Não é possível criar a fonte."</string>
 | 
			
		||||
    <string name="cant_get_spouts_no_network">"Can't get spouts list because of a network issue."</string>
 | 
			
		||||
@@ -107,7 +106,6 @@
 | 
			
		||||
    <string name="reader_text_align_justify">Justify</string>
 | 
			
		||||
    <string name="settings_reader_font">Reader font</string>
 | 
			
		||||
    <string name="remove_source">Remove source</string>
 | 
			
		||||
    <string name="pref_theme_title">Light/Dark mode</string>
 | 
			
		||||
    <string name="mode_dark">Dark mode</string>
 | 
			
		||||
    <string name="mode_system">Follow the system setting</string>
 | 
			
		||||
    <string name="mode_light">Light mode</string>
 | 
			
		||||
@@ -129,4 +127,6 @@
 | 
			
		||||
    <string name="action_about">"Sobre"</string>
 | 
			
		||||
    <string name="marked_as_read">"Item lido"</string>
 | 
			
		||||
    <string name="marked_as_unread">"Item unread"</string>
 | 
			
		||||
    <string name="confirm_delete_title">Confirm Deletion</string>
 | 
			
		||||
    <string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
 | 
			
		||||
</resources>
 | 
			
		||||
 
 | 
			
		||||
@@ -24,7 +24,6 @@
 | 
			
		||||
    <string name="all_posts_not_read">"All posts weren't read"</string>
 | 
			
		||||
    <string name="all_posts_read">"All posts were read"</string>
 | 
			
		||||
    <string name="undo_string">"Undo"</string>
 | 
			
		||||
    <string name="addStringNoUrl">"Log in to add sources."</string>
 | 
			
		||||
    <string name="cant_get_sources">"Can't get sources list."</string>
 | 
			
		||||
    <string name="cant_create_source">"Can't create source."</string>
 | 
			
		||||
    <string name="cant_get_spouts_no_network">"Can't get spouts list because of a network issue."</string>
 | 
			
		||||
@@ -107,7 +106,6 @@
 | 
			
		||||
    <string name="reader_text_align_justify">Justify</string>
 | 
			
		||||
    <string name="settings_reader_font">Reader font</string>
 | 
			
		||||
    <string name="remove_source">Remove source</string>
 | 
			
		||||
    <string name="pref_theme_title">Light/Dark mode</string>
 | 
			
		||||
    <string name="mode_dark">Dark mode</string>
 | 
			
		||||
    <string name="mode_system">Follow the system setting</string>
 | 
			
		||||
    <string name="mode_light">Light mode</string>
 | 
			
		||||
@@ -129,4 +127,6 @@
 | 
			
		||||
    <string name="action_about">"මේ ගැන"</string>
 | 
			
		||||
    <string name="marked_as_read">"Item read"</string>
 | 
			
		||||
    <string name="marked_as_unread">"Item unread"</string>
 | 
			
		||||
    <string name="confirm_delete_title">Confirm Deletion</string>
 | 
			
		||||
    <string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
 | 
			
		||||
</resources>
 | 
			
		||||
 
 | 
			
		||||
@@ -24,7 +24,6 @@
 | 
			
		||||
    <string name="all_posts_not_read">"Tüm mesajlar okunmadı"</string>
 | 
			
		||||
    <string name="all_posts_read">"Tüm mesajlar okundu"</string>
 | 
			
		||||
    <string name="undo_string">"Geri al"</string>
 | 
			
		||||
    <string name="addStringNoUrl">"Kaynakları eklemek için giriş yapın."</string>
 | 
			
		||||
    <string name="cant_get_sources">"Kaynakları listesi alınamıyor."</string>
 | 
			
		||||
    <string name="cant_create_source">"Kaynak oluşturulamıyor."</string>
 | 
			
		||||
    <string name="cant_get_spouts_no_network">"Can't get spouts list because of a network issue."</string>
 | 
			
		||||
@@ -107,7 +106,6 @@
 | 
			
		||||
    <string name="reader_text_align_justify">Justify</string>
 | 
			
		||||
    <string name="settings_reader_font">Reader font</string>
 | 
			
		||||
    <string name="remove_source">Remove source</string>
 | 
			
		||||
    <string name="pref_theme_title">Light/Dark mode</string>
 | 
			
		||||
    <string name="mode_dark">Dark mode</string>
 | 
			
		||||
    <string name="mode_system">Follow the system setting</string>
 | 
			
		||||
    <string name="mode_light">Light mode</string>
 | 
			
		||||
@@ -129,4 +127,6 @@
 | 
			
		||||
    <string name="action_about">"Hakkında"</string>
 | 
			
		||||
    <string name="marked_as_read">"Öğeleri oku"</string>
 | 
			
		||||
    <string name="marked_as_unread">"Item unread"</string>
 | 
			
		||||
    <string name="confirm_delete_title">Confirm Deletion</string>
 | 
			
		||||
    <string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
 | 
			
		||||
</resources>
 | 
			
		||||
 
 | 
			
		||||
@@ -24,7 +24,6 @@
 | 
			
		||||
    <string name="all_posts_not_read">"所有帖子都未读"</string>
 | 
			
		||||
    <string name="all_posts_read">"所有帖子已读"</string>
 | 
			
		||||
    <string name="undo_string">"撤销"</string>
 | 
			
		||||
    <string name="addStringNoUrl">"登录以添加数据源。"</string>
 | 
			
		||||
    <string name="cant_get_sources">"无法获取数据列表。"</string>
 | 
			
		||||
    <string name="cant_create_source">"无法创建源数据。"</string>
 | 
			
		||||
    <string name="cant_get_spouts_no_network">"由于网络问题,无法获取 spouts 列表。"</string>
 | 
			
		||||
@@ -107,7 +106,6 @@
 | 
			
		||||
    <string name="reader_text_align_justify">左右对齐</string>
 | 
			
		||||
    <string name="settings_reader_font">阅读器字体</string>
 | 
			
		||||
    <string name="remove_source">删除源</string>
 | 
			
		||||
    <string name="pref_theme_title">浅色/深色模式</string>
 | 
			
		||||
    <string name="mode_dark">深色模式</string>
 | 
			
		||||
    <string name="mode_system">遵循系统设置</string>
 | 
			
		||||
    <string name="mode_light">浅色模式</string>
 | 
			
		||||
@@ -129,4 +127,6 @@
 | 
			
		||||
    <string name="action_about">"关于我们"</string>
 | 
			
		||||
    <string name="marked_as_read">"已读"</string>
 | 
			
		||||
    <string name="marked_as_unread">"未读条目"</string>
 | 
			
		||||
    <string name="confirm_delete_title">Confirm Deletion</string>
 | 
			
		||||
    <string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
 | 
			
		||||
</resources>
 | 
			
		||||
 
 | 
			
		||||
@@ -24,7 +24,6 @@
 | 
			
		||||
    <string name="all_posts_not_read">"所有帖子都未读"</string>
 | 
			
		||||
    <string name="all_posts_read">"所有帖子已读"</string>
 | 
			
		||||
    <string name="undo_string">"撤销"</string>
 | 
			
		||||
    <string name="addStringNoUrl">"登录以添加数据源。"</string>
 | 
			
		||||
    <string name="cant_get_sources">"无法获取数据列表。"</string>
 | 
			
		||||
    <string name="cant_create_source">"无法创建源数据。"</string>
 | 
			
		||||
    <string name="cant_get_spouts_no_network">"Can't get spouts list because of a network issue."</string>
 | 
			
		||||
@@ -107,7 +106,6 @@
 | 
			
		||||
    <string name="reader_text_align_justify">Justify</string>
 | 
			
		||||
    <string name="settings_reader_font">Reader font</string>
 | 
			
		||||
    <string name="remove_source">Remove source</string>
 | 
			
		||||
    <string name="pref_theme_title">Light/Dark mode</string>
 | 
			
		||||
    <string name="mode_dark">Dark mode</string>
 | 
			
		||||
    <string name="mode_system">Follow the system setting</string>
 | 
			
		||||
    <string name="mode_light">Light mode</string>
 | 
			
		||||
@@ -129,4 +127,6 @@
 | 
			
		||||
    <string name="action_about">"关于我们"</string>
 | 
			
		||||
    <string name="marked_as_read">"已读"</string>
 | 
			
		||||
    <string name="marked_as_unread">"未讀項目"</string>
 | 
			
		||||
    <string name="confirm_delete_title">Confirm Deletion</string>
 | 
			
		||||
    <string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
 | 
			
		||||
</resources>
 | 
			
		||||
 
 | 
			
		||||
@@ -23,7 +23,6 @@
 | 
			
		||||
    <string name="all_posts_not_read">"All posts weren't read"</string>
 | 
			
		||||
    <string name="all_posts_read">"All posts were read"</string>
 | 
			
		||||
    <string name="undo_string">"Undo"</string>
 | 
			
		||||
    <string name="addStringNoUrl">"Log in to add sources."</string>
 | 
			
		||||
    <string name="cant_get_sources">"Can't get sources list."</string>
 | 
			
		||||
    <string name="cant_create_source">"Can't create source."</string>
 | 
			
		||||
    <string name="cant_get_spouts_no_network">"Can't get spouts list because of a network issue."</string>
 | 
			
		||||
@@ -109,7 +108,6 @@
 | 
			
		||||
    <string name="open_sans_font_id" translatable="false">open_sans</string>
 | 
			
		||||
    <string name="roboto_font_id" translatable="false">roboto</string>
 | 
			
		||||
    <string name="remove_source">Remove source</string>
 | 
			
		||||
    <string name="pref_theme_title">Light/Dark mode</string>
 | 
			
		||||
    <string name="mode_dark">Dark mode</string>
 | 
			
		||||
    <string name="mode_system">Follow the system setting</string>
 | 
			
		||||
    <string name="mode_light">Light mode</string>
 | 
			
		||||
@@ -131,4 +129,6 @@
 | 
			
		||||
    <string name="action_about">"About"</string>
 | 
			
		||||
    <string name="marked_as_read">"Item read"</string>
 | 
			
		||||
    <string name="marked_as_unread">"Item unread"</string>
 | 
			
		||||
    <string name="confirm_delete_title">Confirm Deletion</string>
 | 
			
		||||
    <string name="confirm_delete_message">Are you sure you want to delete the following source?\n%s</string>
 | 
			
		||||
</resources>
 | 
			
		||||
 
 | 
			
		||||
@@ -1,3 +1,5 @@
 | 
			
		||||
@file:Suppress("ktlint")
 | 
			
		||||
/*
 | 
			
		||||
package bou.amine.apps.readerforselfossv2.android.tests.robolectric
 | 
			
		||||
 | 
			
		||||
import android.view.Menu
 | 
			
		||||
@@ -25,3 +27,4 @@ fun Menu.assertVisible(
 | 
			
		||||
    val item = this.findItem(id)
 | 
			
		||||
    assertTrue(item.isVisible)
 | 
			
		||||
}
 | 
			
		||||
*/
 | 
			
		||||
 
 | 
			
		||||
@@ -1,3 +1,5 @@
 | 
			
		||||
@file:Suppress("ktlint")
 | 
			
		||||
/*
 | 
			
		||||
package bou.amine.apps.readerforselfossv2.android.tests.robolectric
 | 
			
		||||
 | 
			
		||||
import android.widget.Button
 | 
			
		||||
@@ -57,7 +59,8 @@ class LoginActivityTest {
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    /* @Test
 | 
			
		||||
 */
 | 
			
		||||
/* @Test
 | 
			
		||||
     fun connect() {
 | 
			
		||||
         Robolectric.buildActivity(LoginActivity::class.java).use { controller ->
 | 
			
		||||
             controller.setup() // Moves the Activity to the RESUMED state
 | 
			
		||||
@@ -72,4 +75,7 @@ class LoginActivityTest {
 | 
			
		||||
             assertEquals(expectedIntent.component, actual.component)
 | 
			
		||||
         }
 | 
			
		||||
     }*/
 | 
			
		||||
/*
 | 
			
		||||
 | 
			
		||||
}
 | 
			
		||||
*/
 | 
			
		||||
 
 | 
			
		||||
@@ -1,3 +1,5 @@
 | 
			
		||||
@file:Suppress("ktlint")
 | 
			
		||||
/*
 | 
			
		||||
package bou.amine.apps.readerforselfossv2.android.tests.robolectric
 | 
			
		||||
 | 
			
		||||
import org.robolectric.RobolectricTestRunner
 | 
			
		||||
@@ -8,3 +10,4 @@ class RobotElectriqueRunner(
 | 
			
		||||
) : RobolectricTestRunner(testClass) {
 | 
			
		||||
    override fun buildGlobalConfig(): Config = Config.Builder().setSdk(25, 30, 33).build()
 | 
			
		||||
}
 | 
			
		||||
*/
 | 
			
		||||
 
 | 
			
		||||
@@ -11,6 +11,7 @@ import bou.amine.apps.readerforselfossv2.model.SuccessResponse
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.repository.Repository
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.rest.SelfossApi
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.service.AppSettingsService
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.service.ConnectivityService
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.utils.ItemType
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.utils.toView
 | 
			
		||||
import io.mockk.clearAllMocks
 | 
			
		||||
@@ -24,7 +25,6 @@ import junit.framework.TestCase.assertFalse
 | 
			
		||||
import junit.framework.TestCase.assertNotSame
 | 
			
		||||
import junit.framework.TestCase.assertSame
 | 
			
		||||
import junit.framework.TestCase.assertTrue
 | 
			
		||||
import kotlinx.coroutines.flow.MutableStateFlow
 | 
			
		||||
import kotlinx.coroutines.runBlocking
 | 
			
		||||
import org.junit.Assert.assertNotEquals
 | 
			
		||||
import org.junit.Before
 | 
			
		||||
@@ -52,15 +52,12 @@ class RepositoryTest {
 | 
			
		||||
    private val db = mockk<ReaderForSelfossDB>(relaxed = true)
 | 
			
		||||
    private val appSettingsService = mockk<AppSettingsService>()
 | 
			
		||||
    private val api = mockk<SelfossApi>()
 | 
			
		||||
    private val connectivityService = mockk<ConnectivityService>()
 | 
			
		||||
    private lateinit var repository: Repository
 | 
			
		||||
 | 
			
		||||
    private fun initializeRepository(
 | 
			
		||||
        isConnectionAvailable: MutableStateFlow<Boolean> =
 | 
			
		||||
            MutableStateFlow(
 | 
			
		||||
                true,
 | 
			
		||||
            ),
 | 
			
		||||
    ) {
 | 
			
		||||
        repository = Repository(api, appSettingsService, isConnectionAvailable, db)
 | 
			
		||||
    private fun initializeRepository(isNetworkAvailable: Boolean = true) {
 | 
			
		||||
        every { connectivityService.isNetworkAvailable() } returns isNetworkAvailable
 | 
			
		||||
        repository = Repository(api, appSettingsService, connectivityService, db)
 | 
			
		||||
 | 
			
		||||
        runBlocking {
 | 
			
		||||
            repository.updateApiInformation()
 | 
			
		||||
@@ -110,7 +107,7 @@ class RepositoryTest {
 | 
			
		||||
    fun instantiate_repository_without_api_version() {
 | 
			
		||||
        every { appSettingsService.getApiVersion() } returns -1
 | 
			
		||||
 | 
			
		||||
        initializeRepository(MutableStateFlow(false))
 | 
			
		||||
        initializeRepository(false)
 | 
			
		||||
 | 
			
		||||
        coVerify(exactly = 0) { api.apiInformation() }
 | 
			
		||||
        coVerify(exactly = 0) { api.stats() }
 | 
			
		||||
@@ -287,7 +284,7 @@ class RepositoryTest {
 | 
			
		||||
    fun get_newer_items_without_connectivity() {
 | 
			
		||||
        every { appSettingsService.isItemCachingEnabled() } returns true
 | 
			
		||||
 | 
			
		||||
        initializeRepository(MutableStateFlow(false))
 | 
			
		||||
        initializeRepository(false)
 | 
			
		||||
        runBlocking {
 | 
			
		||||
            repository.getNewerItems()
 | 
			
		||||
        }
 | 
			
		||||
@@ -314,7 +311,7 @@ class RepositoryTest {
 | 
			
		||||
 | 
			
		||||
        every { appSettingsService.isItemCachingEnabled() } returns true
 | 
			
		||||
 | 
			
		||||
        initializeRepository(MutableStateFlow(false))
 | 
			
		||||
        initializeRepository(false)
 | 
			
		||||
        repository.setTagFilter(SelfossModel.Tag("Test", "red", 3))
 | 
			
		||||
        runBlocking {
 | 
			
		||||
            repository.getNewerItems()
 | 
			
		||||
@@ -342,7 +339,7 @@ class RepositoryTest {
 | 
			
		||||
 | 
			
		||||
        every { appSettingsService.isItemCachingEnabled() } returns true
 | 
			
		||||
 | 
			
		||||
        initializeRepository(MutableStateFlow(false))
 | 
			
		||||
        initializeRepository(false)
 | 
			
		||||
        repository.setSourceFilter(
 | 
			
		||||
            SelfossModel.SourceDetail(
 | 
			
		||||
                1,
 | 
			
		||||
@@ -457,7 +454,7 @@ class RepositoryTest {
 | 
			
		||||
 | 
			
		||||
        var success: Boolean
 | 
			
		||||
 | 
			
		||||
        initializeRepository(MutableStateFlow(false))
 | 
			
		||||
        initializeRepository(false)
 | 
			
		||||
        runBlocking {
 | 
			
		||||
            success = repository.reloadBadges()
 | 
			
		||||
        }
 | 
			
		||||
@@ -477,7 +474,7 @@ class RepositoryTest {
 | 
			
		||||
 | 
			
		||||
        var success: Boolean
 | 
			
		||||
 | 
			
		||||
        initializeRepository(MutableStateFlow(false))
 | 
			
		||||
        initializeRepository(false)
 | 
			
		||||
        runBlocking {
 | 
			
		||||
            success = repository.reloadBadges()
 | 
			
		||||
        }
 | 
			
		||||
@@ -572,7 +569,7 @@ class RepositoryTest {
 | 
			
		||||
        every { appSettingsService.isUpdateSourcesEnabled() } returns true
 | 
			
		||||
        every { appSettingsService.isItemCachingEnabled() } returns true
 | 
			
		||||
 | 
			
		||||
        initializeRepository(MutableStateFlow(false))
 | 
			
		||||
        initializeRepository(false)
 | 
			
		||||
        var testTags: List<SelfossModel.Tag>
 | 
			
		||||
        runBlocking {
 | 
			
		||||
            testTags = repository.getTags()
 | 
			
		||||
@@ -590,7 +587,7 @@ class RepositoryTest {
 | 
			
		||||
        every { appSettingsService.isItemCachingEnabled() } returns false
 | 
			
		||||
        every { appSettingsService.isUpdateSourcesEnabled() } returns true
 | 
			
		||||
 | 
			
		||||
        initializeRepository(MutableStateFlow(false))
 | 
			
		||||
        initializeRepository(false)
 | 
			
		||||
        var testTags: List<SelfossModel.Tag>
 | 
			
		||||
        runBlocking {
 | 
			
		||||
            testTags = repository.getTags()
 | 
			
		||||
@@ -607,7 +604,7 @@ class RepositoryTest {
 | 
			
		||||
        every { appSettingsService.isUpdateSourcesEnabled() } returns false
 | 
			
		||||
        every { appSettingsService.isItemCachingEnabled() } returns true
 | 
			
		||||
 | 
			
		||||
        initializeRepository(MutableStateFlow(false))
 | 
			
		||||
        initializeRepository(false)
 | 
			
		||||
        var testTags: List<SelfossModel.Tag>
 | 
			
		||||
        runBlocking {
 | 
			
		||||
            testTags = repository.getTags()
 | 
			
		||||
@@ -625,7 +622,7 @@ class RepositoryTest {
 | 
			
		||||
        every { appSettingsService.isUpdateSourcesEnabled() } returns false
 | 
			
		||||
        every { appSettingsService.isItemCachingEnabled() } returns false
 | 
			
		||||
 | 
			
		||||
        initializeRepository(MutableStateFlow(false))
 | 
			
		||||
        initializeRepository(false)
 | 
			
		||||
        var testTags: List<SelfossModel.Tag>
 | 
			
		||||
        runBlocking {
 | 
			
		||||
            testTags = repository.getTags()
 | 
			
		||||
@@ -775,7 +772,7 @@ class RepositoryTest {
 | 
			
		||||
    @Test
 | 
			
		||||
    fun get_sources_without_connection() {
 | 
			
		||||
        val (_, sourcesDB) = prepareSources()
 | 
			
		||||
        initializeRepository(MutableStateFlow(false))
 | 
			
		||||
        initializeRepository(false)
 | 
			
		||||
        var testSources: List<SelfossModel.Source>
 | 
			
		||||
        runBlocking {
 | 
			
		||||
            testSources = repository.getSourcesDetails()
 | 
			
		||||
@@ -792,7 +789,7 @@ class RepositoryTest {
 | 
			
		||||
 | 
			
		||||
        every { appSettingsService.isItemCachingEnabled() } returns false
 | 
			
		||||
        every { appSettingsService.isUpdateSourcesEnabled() } returns true
 | 
			
		||||
        initializeRepository(MutableStateFlow(false))
 | 
			
		||||
        initializeRepository(false)
 | 
			
		||||
        var testSources: List<SelfossModel.Source>
 | 
			
		||||
        runBlocking {
 | 
			
		||||
            testSources = repository.getSourcesDetails()
 | 
			
		||||
@@ -809,7 +806,7 @@ class RepositoryTest {
 | 
			
		||||
 | 
			
		||||
        every { appSettingsService.isItemCachingEnabled() } returns true
 | 
			
		||||
        every { appSettingsService.isUpdateSourcesEnabled() } returns false
 | 
			
		||||
        initializeRepository(MutableStateFlow(false))
 | 
			
		||||
        initializeRepository(false)
 | 
			
		||||
        var testSources: List<SelfossModel.Source>
 | 
			
		||||
        runBlocking {
 | 
			
		||||
            testSources = repository.getSourcesDetails()
 | 
			
		||||
@@ -826,7 +823,7 @@ class RepositoryTest {
 | 
			
		||||
 | 
			
		||||
        every { appSettingsService.isItemCachingEnabled() } returns false
 | 
			
		||||
        every { appSettingsService.isUpdateSourcesEnabled() } returns false
 | 
			
		||||
        initializeRepository(MutableStateFlow(false))
 | 
			
		||||
        initializeRepository(false)
 | 
			
		||||
        var testSources: List<SelfossModel.Source>
 | 
			
		||||
        runBlocking {
 | 
			
		||||
            testSources = repository.getSourcesDetails()
 | 
			
		||||
@@ -898,7 +895,7 @@ class RepositoryTest {
 | 
			
		||||
        coEvery { api.createSourceForVersion(any(), any(), any(), any()) } returns
 | 
			
		||||
            SuccessResponse(true)
 | 
			
		||||
 | 
			
		||||
        initializeRepository(MutableStateFlow(false))
 | 
			
		||||
        initializeRepository(false)
 | 
			
		||||
        var response: Boolean
 | 
			
		||||
        runBlocking {
 | 
			
		||||
            response =
 | 
			
		||||
@@ -955,7 +952,7 @@ class RepositoryTest {
 | 
			
		||||
    fun delete_source_without_connection() {
 | 
			
		||||
        coEvery { api.deleteSource(any()) } returns SuccessResponse(false)
 | 
			
		||||
 | 
			
		||||
        initializeRepository(MutableStateFlow(false))
 | 
			
		||||
        initializeRepository(false)
 | 
			
		||||
        var response: Boolean
 | 
			
		||||
        runBlocking {
 | 
			
		||||
            response = repository.deleteSource(5, "src")
 | 
			
		||||
@@ -1028,7 +1025,7 @@ class RepositoryTest {
 | 
			
		||||
                data = "undocumented...",
 | 
			
		||||
            )
 | 
			
		||||
 | 
			
		||||
        initializeRepository(MutableStateFlow(false))
 | 
			
		||||
        initializeRepository(false)
 | 
			
		||||
        var response: Boolean
 | 
			
		||||
        runBlocking {
 | 
			
		||||
            response = repository.updateRemote()
 | 
			
		||||
@@ -1070,7 +1067,7 @@ class RepositoryTest {
 | 
			
		||||
    fun login_but_without_connection() {
 | 
			
		||||
        coEvery { api.login() } returns SuccessResponse(success = true)
 | 
			
		||||
 | 
			
		||||
        initializeRepository(MutableStateFlow(false))
 | 
			
		||||
        initializeRepository(false)
 | 
			
		||||
        var response: Boolean
 | 
			
		||||
        runBlocking {
 | 
			
		||||
            response = repository.login()
 | 
			
		||||
@@ -1150,7 +1147,7 @@ class RepositoryTest {
 | 
			
		||||
        coEvery { api.getItems(any(), any(), any(), any(), any(), any(), any()) } returns
 | 
			
		||||
            StatusAndData(success = false, data = generateTestApiItem())
 | 
			
		||||
 | 
			
		||||
        initializeRepository(MutableStateFlow(false))
 | 
			
		||||
        initializeRepository(false)
 | 
			
		||||
        prepareSearch()
 | 
			
		||||
        runBlocking {
 | 
			
		||||
            repository.tryToCacheItemsAndGetNewOnes()
 | 
			
		||||
 
 | 
			
		||||
@@ -1,7 +1,7 @@
 | 
			
		||||
plugins {
 | 
			
		||||
    //trick: for the same plugin versions in all sub-modules
 | 
			
		||||
    id("com.android.application").version("8.7.3").apply(false)
 | 
			
		||||
    id("com.android.library").version("8.7.3").apply(false)
 | 
			
		||||
    // trick: for the same plugin versions in all sub-modules
 | 
			
		||||
    id("com.android.application").version("8.8.1").apply(false)
 | 
			
		||||
    id("com.android.library").version("8.8.1").apply(false)
 | 
			
		||||
    id("org.jetbrains.kotlin.android").version("2.1.0").apply(false)
 | 
			
		||||
    kotlin("multiplatform").version("2.1.0").apply(false)
 | 
			
		||||
    id("com.mikepenz.aboutlibraries.plugin").version("10.5.1").apply(false)
 | 
			
		||||
@@ -16,7 +16,6 @@ allprojects {
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
 | 
			
		||||
tasks.register("clean", Delete::class) {
 | 
			
		||||
    delete(layout.buildDirectory)
 | 
			
		||||
}
 | 
			
		||||
@@ -24,4 +23,4 @@ tasks.register("clean", Delete::class) {
 | 
			
		||||
dependencies {
 | 
			
		||||
    kover(project(":shared"))
 | 
			
		||||
    kover(project(":androidApp"))
 | 
			
		||||
}
 | 
			
		||||
}
 | 
			
		||||
 
 | 
			
		||||
@@ -0,0 +1,6 @@
 | 
			
		||||
**v125010201**
 | 
			
		||||
 | 
			
		||||
- fix: Handle empty url issue.
 | 
			
		||||
- Merge pull request 'Removed the floating bar.' (#177) from floating-bar into master
 | 
			
		||||
- chore: changing actions in reader fragment.
 | 
			
		||||
- Changelog for v125010131
 | 
			
		||||
@@ -0,0 +1,8 @@
 | 
			
		||||
**v125010241**
 | 
			
		||||
 | 
			
		||||
- Merge pull request 'fix: Link not opening.' (#178) from fix-open-link into master
 | 
			
		||||
- refactor: context fragments issues.
 | 
			
		||||
- logs: Context issues.
 | 
			
		||||
- fix: Handle empty url issue, again.
 | 
			
		||||
- fix: Link not opening.
 | 
			
		||||
- Changelog for v125010201
 | 
			
		||||
@@ -0,0 +1,7 @@
 | 
			
		||||
**v125020411**
 | 
			
		||||
 | 
			
		||||
- Merge pull request 'bump' (#182) from bump into master
 | 
			
		||||
- chore: non transiant R classes.
 | 
			
		||||
- Merge pull request 'fix: One more missing context.' (#181) from fix-one-more-context into master
 | 
			
		||||
- bump
 | 
			
		||||
- fix: One more missing context.
 | 
			
		||||
@@ -0,0 +1,7 @@
 | 
			
		||||
**v125020471**
 | 
			
		||||
 | 
			
		||||
- chore: no more docker-compose.
 | 
			
		||||
- bump: gradle plugin.
 | 
			
		||||
- Merge pull request 'fix: check index exists.' (#183) from fix-index into master
 | 
			
		||||
- fix: check index exists.
 | 
			
		||||
- Changelog for v125020411
 | 
			
		||||
@@ -0,0 +1,4 @@
 | 
			
		||||
**v125020581**
 | 
			
		||||
 | 
			
		||||
- fix: url can be empty ?
 | 
			
		||||
- Changelog for v125020471
 | 
			
		||||
							
								
								
									
										12
									
								
								fastlane/metadata/android/en-US/changelogs/v125030681.txt
									
									
									
									
									
										Normal file
									
								
							
							
						
						
									
										12
									
								
								fastlane/metadata/android/en-US/changelogs/v125030681.txt
									
									
									
									
									
										Normal file
									
								
							@@ -0,0 +1,12 @@
 | 
			
		||||
**v125030681**
 | 
			
		||||
 | 
			
		||||
- chore: do not send reports on simulators.
 | 
			
		||||
- Merge pull request 'chore: do not send reports on simulators.' (#188) from chore-acra-simulator into master
 | 
			
		||||
- chore: do not send reports on simulators.
 | 
			
		||||
- Merge pull request 'fix: Url validation was not failing login. Added tests.' (#186) from fix-invalid-url into master
 | 
			
		||||
- Merge pull request 'chore: crowding ci integration.' (#187) from chore-crowdin-ci into master
 | 
			
		||||
- chore: we don't need to check if the url is valid in upsert screen.
 | 
			
		||||
- fix: Url validation was not failing login. Added tests.
 | 
			
		||||
- chore: crowding ci integration.
 | 
			
		||||
- Show a confirmation dialog before deleting sources (#185)
 | 
			
		||||
- Changelog for v125020581
 | 
			
		||||
@@ -0,0 +1,8 @@
 | 
			
		||||
**v125030711**
 | 
			
		||||
 | 
			
		||||
- Merge pull request 'fix: initial status loading issues.' (#192) from connectivity into master
 | 
			
		||||
- chore: check changes for translations and android.
 | 
			
		||||
- fix: initial status loading issues.
 | 
			
		||||
- Merge pull request 'chore: new connectivity dep. Closes #84.' (#189) from connectivity into master
 | 
			
		||||
- chore: new connectivity dep. Closes #84.
 | 
			
		||||
- Changelog for v125030681
 | 
			
		||||
@@ -19,11 +19,12 @@ kotlin.code.style=official
 | 
			
		||||
android.useAndroidX=true
 | 
			
		||||
#android.nonTransitiveRClass=true
 | 
			
		||||
android.enableJetifier=false
 | 
			
		||||
android.nonTransitiveRClass=false
 | 
			
		||||
android.nonTransitiveRClass=true
 | 
			
		||||
#MPP
 | 
			
		||||
kotlin.mpp.enableCInteropCommonization=true
 | 
			
		||||
org.gradle.parallel=true
 | 
			
		||||
org.gradle.caching=true
 | 
			
		||||
ignoreGitVersion=false
 | 
			
		||||
kotlin.native.cacheKind.iosX64=none
 | 
			
		||||
org.gradle.configureondemand=true
 | 
			
		||||
org.gradle.configureondemand=true
 | 
			
		||||
kotlin.jvm.target.validation.mode=IGNORE
 | 
			
		||||
 
 | 
			
		||||
							
								
								
									
										4
									
								
								gradle/wrapper/gradle-wrapper.properties
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										4
									
								
								gradle/wrapper/gradle-wrapper.properties
									
									
									
									
										vendored
									
									
								
							@@ -1,6 +1,6 @@
 | 
			
		||||
#Mon Nov 25 22:48:24 CET 2024
 | 
			
		||||
#Sun Feb 09 14:44:52 CET 2025
 | 
			
		||||
distributionBase=GRADLE_USER_HOME
 | 
			
		||||
distributionPath=wrapper/dists
 | 
			
		||||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.9-bin.zip
 | 
			
		||||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-bin.zip
 | 
			
		||||
zipStoreBase=GRADLE_USER_HOME
 | 
			
		||||
zipStorePath=wrapper/dists
 | 
			
		||||
 
 | 
			
		||||
@@ -4,7 +4,6 @@ object SqlDelight {
 | 
			
		||||
    const val runtime = "app.cash.sqldelight:runtime:2.0.2"
 | 
			
		||||
    const val android = "app.cash.sqldelight:android-driver:2.0.2"
 | 
			
		||||
    const val native = "app.cash.sqldelight:native-driver:2.0.2"
 | 
			
		||||
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
plugins {
 | 
			
		||||
@@ -41,13 +40,13 @@ kotlin {
 | 
			
		||||
 | 
			
		||||
                implementation("org.jsoup:jsoup:1.15.4")
 | 
			
		||||
 | 
			
		||||
                //Dependency Injection
 | 
			
		||||
                // Dependency Injection
 | 
			
		||||
                implementation("org.kodein.di:kodein-di:7.14.0")
 | 
			
		||||
 | 
			
		||||
                //Settings
 | 
			
		||||
                // Settings
 | 
			
		||||
                implementation("com.russhwolf:multiplatform-settings-no-arg:1.0.0-RC")
 | 
			
		||||
 | 
			
		||||
                //Logging
 | 
			
		||||
                // Logging
 | 
			
		||||
                implementation("io.github.aakira:napier:2.6.1")
 | 
			
		||||
 | 
			
		||||
                // Sql
 | 
			
		||||
@@ -55,6 +54,10 @@ kotlin {
 | 
			
		||||
 | 
			
		||||
                // Sql
 | 
			
		||||
                implementation("org.jetbrains.kotlinx:kotlinx-datetime:0.6.1")
 | 
			
		||||
 | 
			
		||||
                // Connectivity
 | 
			
		||||
                implementation("dev.jordond.connectivity:connectivity-core:1.2.0")
 | 
			
		||||
                implementation("dev.jordond.connectivity:connectivity-device:1.2.0")
 | 
			
		||||
            }
 | 
			
		||||
        }
 | 
			
		||||
        val commonTest by getting {
 | 
			
		||||
@@ -114,4 +117,4 @@ sqldelight {
 | 
			
		||||
            packageName.set("bou.amine.apps.readerforselfossv2.dao")
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
}
 | 
			
		||||
 
 | 
			
		||||
@@ -127,8 +127,8 @@ class SelfossModel {
 | 
			
		||||
        val tags: List<String>,
 | 
			
		||||
        val author: String? = null,
 | 
			
		||||
    ) {
 | 
			
		||||
        fun getLinkDecoded(): String {
 | 
			
		||||
            var stringUrl: String
 | 
			
		||||
        fun getLinkDecoded(): String? {
 | 
			
		||||
            var stringUrl: String?
 | 
			
		||||
            stringUrl =
 | 
			
		||||
                if (link.contains("//news.google.com/news/") && link.contains("&url=")) {
 | 
			
		||||
                    link.substringAfter("&url=")
 | 
			
		||||
@@ -146,11 +146,7 @@ class SelfossModel {
 | 
			
		||||
                stringUrl = "http:$stringUrl"
 | 
			
		||||
            }
 | 
			
		||||
 | 
			
		||||
            if (stringUrl.isEmptyOrNullOrNullString()) {
 | 
			
		||||
                throw ModelException("Link $link was translated to $stringUrl, but was empty. Handle this.")
 | 
			
		||||
            }
 | 
			
		||||
 | 
			
		||||
            return stringUrl
 | 
			
		||||
            return if (stringUrl.isEmptyOrNullOrNullString()) null else stringUrl
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        fun sourceAuthorAndDate(): String {
 | 
			
		||||
 
 | 
			
		||||
@@ -13,6 +13,7 @@ import bou.amine.apps.readerforselfossv2.model.SelfossModel
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.model.StatusAndData
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.rest.SelfossApi
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.service.AppSettingsService
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.service.ConnectivityService
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.utils.ItemType
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.utils.getHtmlDecoded
 | 
			
		||||
import bou.amine.apps.readerforselfossv2.utils.toEntity
 | 
			
		||||
@@ -30,11 +31,10 @@ private const val MAX_ITEMS_NUMBER = 200
 | 
			
		||||
class Repository(
 | 
			
		||||
    private val api: SelfossApi,
 | 
			
		||||
    private val appSettingsService: AppSettingsService,
 | 
			
		||||
    val isConnectionAvailable: MutableStateFlow<Boolean>,
 | 
			
		||||
    private val connectivityService: ConnectivityService,
 | 
			
		||||
    private val db: ReaderForSelfossDB,
 | 
			
		||||
) {
 | 
			
		||||
    var items = ArrayList<SelfossModel.Item>()
 | 
			
		||||
    var connectionMonitored = false
 | 
			
		||||
 | 
			
		||||
    var baseUrl = appSettingsService.getBaseUrl()
 | 
			
		||||
 | 
			
		||||
@@ -63,7 +63,7 @@ class Repository(
 | 
			
		||||
 | 
			
		||||
    suspend fun getNewerItems(): ArrayList<SelfossModel.Item> {
 | 
			
		||||
        var fetchedItems: StatusAndData<List<SelfossModel.Item>> = StatusAndData.error()
 | 
			
		||||
        if (isNetworkAvailable()) {
 | 
			
		||||
        if (connectivityService.isNetworkAvailable()) {
 | 
			
		||||
            fetchedItems =
 | 
			
		||||
                api.getItems(
 | 
			
		||||
                    displayedItems.type,
 | 
			
		||||
@@ -102,7 +102,7 @@ class Repository(
 | 
			
		||||
 | 
			
		||||
    suspend fun getOlderItems(): ArrayList<SelfossModel.Item> {
 | 
			
		||||
        var fetchedItems: StatusAndData<List<SelfossModel.Item>> = StatusAndData.error()
 | 
			
		||||
        if (isNetworkAvailable()) {
 | 
			
		||||
        if (connectivityService.isNetworkAvailable()) {
 | 
			
		||||
            val offset = items.size
 | 
			
		||||
            fetchedItems =
 | 
			
		||||
                api.getItems(
 | 
			
		||||
@@ -122,7 +122,7 @@ class Repository(
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private suspend fun getMaxItemsForBackground(itemType: ItemType): List<SelfossModel.Item> {
 | 
			
		||||
        return if (isNetworkAvailable()) {
 | 
			
		||||
        return if (connectivityService.isNetworkAvailable()) {
 | 
			
		||||
            val items =
 | 
			
		||||
                api.getItems(
 | 
			
		||||
                    itemType.type,
 | 
			
		||||
@@ -146,7 +146,7 @@ class Repository(
 | 
			
		||||
    @Suppress("detekt:ForbiddenComment")
 | 
			
		||||
    suspend fun reloadBadges(): Boolean {
 | 
			
		||||
        var success = false
 | 
			
		||||
        if (isNetworkAvailable()) {
 | 
			
		||||
        if (connectivityService.isNetworkAvailable()) {
 | 
			
		||||
            val response = api.stats()
 | 
			
		||||
            if (response.success && response.data != null) {
 | 
			
		||||
                _badgeUnread.value = response.data.unread ?: 0
 | 
			
		||||
@@ -168,7 +168,7 @@ class Repository(
 | 
			
		||||
    suspend fun getTags(): List<SelfossModel.Tag> {
 | 
			
		||||
        val isDatabaseEnabled =
 | 
			
		||||
            appSettingsService.isItemCachingEnabled() || !appSettingsService.isUpdateSourcesEnabled()
 | 
			
		||||
        return if (isNetworkAvailable() && !fetchedTags) {
 | 
			
		||||
        return if (connectivityService.isNetworkAvailable() && !fetchedTags) {
 | 
			
		||||
            val apiTags = api.tags()
 | 
			
		||||
            if (apiTags.success && apiTags.data != null && isDatabaseEnabled) {
 | 
			
		||||
                resetDBTagsWithData(apiTags.data)
 | 
			
		||||
@@ -185,7 +185,7 @@ class Repository(
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    suspend fun getSpouts(): Map<String, SelfossModel.Spout> =
 | 
			
		||||
        if (isNetworkAvailable()) {
 | 
			
		||||
        if (connectivityService.isNetworkAvailable()) {
 | 
			
		||||
            val spouts = api.spouts()
 | 
			
		||||
            if (spouts.success && spouts.data != null) {
 | 
			
		||||
                spouts.data
 | 
			
		||||
@@ -201,7 +201,7 @@ class Repository(
 | 
			
		||||
        val isDatabaseEnabled =
 | 
			
		||||
            appSettingsService.isItemCachingEnabled() || !appSettingsService.isUpdateSourcesEnabled()
 | 
			
		||||
        val shouldFetch = if (!appSettingsService.isUpdateSourcesEnabled()) !fetchedSources else true
 | 
			
		||||
        if (shouldFetch && isNetworkAvailable()) {
 | 
			
		||||
        if (shouldFetch && connectivityService.isNetworkAvailable()) {
 | 
			
		||||
            if (appSettingsService.getPublicAccess()) {
 | 
			
		||||
                val apiSources = api.sourcesStats()
 | 
			
		||||
                if (apiSources.success && apiSources.data != null) {
 | 
			
		||||
@@ -223,17 +223,26 @@ class Repository(
 | 
			
		||||
        val isDatabaseEnabled =
 | 
			
		||||
            appSettingsService.isItemCachingEnabled() || !appSettingsService.isUpdateSourcesEnabled()
 | 
			
		||||
        val shouldFetch = if (!appSettingsService.isUpdateSourcesEnabled()) !fetchedSources else true
 | 
			
		||||
        if (shouldFetch && isNetworkAvailable()) {
 | 
			
		||||
            val apiSources = api.sourcesDetailed()
 | 
			
		||||
            if (apiSources.success && apiSources.data != null) {
 | 
			
		||||
                fetchedSources = true
 | 
			
		||||
                sources = apiSources.data
 | 
			
		||||
                if (isDatabaseEnabled) {
 | 
			
		||||
                    resetDBSourcesWithData(sources)
 | 
			
		||||
                }
 | 
			
		||||
            }
 | 
			
		||||
        if (shouldFetch && connectivityService.isNetworkAvailable()) {
 | 
			
		||||
            sources = sourceDetails(isDatabaseEnabled)
 | 
			
		||||
        } else if (isDatabaseEnabled) {
 | 
			
		||||
            sources = getDBSources().map { it.toView() } as ArrayList<SelfossModel.SourceDetail>
 | 
			
		||||
            if (sources.isEmpty() && !connectivityService.isNetworkAvailable() && !fetchedSources) {
 | 
			
		||||
                sources = sourceDetails(isDatabaseEnabled)
 | 
			
		||||
            }
 | 
			
		||||
        }
 | 
			
		||||
        return sources
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private suspend fun sourceDetails(isDatabaseEnabled: Boolean): ArrayList<SelfossModel.SourceDetail> {
 | 
			
		||||
        var sources = ArrayList<SelfossModel.SourceDetail>()
 | 
			
		||||
        val apiSources = api.sourcesDetailed()
 | 
			
		||||
        if (apiSources.success && apiSources.data != null) {
 | 
			
		||||
            fetchedSources = true
 | 
			
		||||
            sources = apiSources.data
 | 
			
		||||
            if (isDatabaseEnabled) {
 | 
			
		||||
                resetDBSourcesWithData(sources)
 | 
			
		||||
            }
 | 
			
		||||
        }
 | 
			
		||||
        return sources
 | 
			
		||||
    }
 | 
			
		||||
@@ -248,7 +257,7 @@ class Repository(
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private suspend fun markAsReadById(id: Int): Boolean =
 | 
			
		||||
        if (isNetworkAvailable()) {
 | 
			
		||||
        if (connectivityService.isNetworkAvailable()) {
 | 
			
		||||
            api.markAsRead(id.toString()).isSuccess
 | 
			
		||||
        } else {
 | 
			
		||||
            insertDBAction(id.toString(), read = true)
 | 
			
		||||
@@ -265,7 +274,7 @@ class Repository(
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private suspend fun unmarkAsReadById(id: Int): Boolean =
 | 
			
		||||
        if (isNetworkAvailable()) {
 | 
			
		||||
        if (connectivityService.isNetworkAvailable()) {
 | 
			
		||||
            api.unmarkAsRead(id.toString()).isSuccess
 | 
			
		||||
        } else {
 | 
			
		||||
            insertDBAction(id.toString(), unread = true)
 | 
			
		||||
@@ -282,7 +291,7 @@ class Repository(
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private suspend fun starrById(id: Int): Boolean =
 | 
			
		||||
        if (isNetworkAvailable()) {
 | 
			
		||||
        if (connectivityService.isNetworkAvailable()) {
 | 
			
		||||
            api.starr(id.toString()).isSuccess
 | 
			
		||||
        } else {
 | 
			
		||||
            insertDBAction(id.toString(), starred = true)
 | 
			
		||||
@@ -299,7 +308,7 @@ class Repository(
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    private suspend fun unstarrById(id: Int): Boolean =
 | 
			
		||||
        if (isNetworkAvailable()) {
 | 
			
		||||
        if (connectivityService.isNetworkAvailable()) {
 | 
			
		||||
            api.unstarr(id.toString()).isSuccess
 | 
			
		||||
        } else {
 | 
			
		||||
            insertDBAction(id.toString(), starred = true)
 | 
			
		||||
@@ -309,7 +318,8 @@ class Repository(
 | 
			
		||||
    suspend fun markAllAsRead(items: ArrayList<SelfossModel.Item>): Boolean {
 | 
			
		||||
        var success = false
 | 
			
		||||
 | 
			
		||||
        if (isNetworkAvailable() && api.markAllAsRead(items.map { it.id.toString() }).isSuccess) {
 | 
			
		||||
        if (connectivityService.isNetworkAvailable() && api.markAllAsRead(items.map { it.id.toString() }).isSuccess
 | 
			
		||||
        ) {
 | 
			
		||||
            success = true
 | 
			
		||||
            for (item in items) {
 | 
			
		||||
                markAsReadLocally(item)
 | 
			
		||||
@@ -324,7 +334,7 @@ class Repository(
 | 
			
		||||
            _badgeUnread.value -= 1
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        CoroutineScope(Dispatchers.Main).launch {
 | 
			
		||||
        CoroutineScope(Dispatchers.Default).launch {
 | 
			
		||||
            updateDBItem(item)
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
@@ -335,7 +345,7 @@ class Repository(
 | 
			
		||||
            _badgeUnread.value += 1
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        CoroutineScope(Dispatchers.Main).launch {
 | 
			
		||||
        CoroutineScope(Dispatchers.Default).launch {
 | 
			
		||||
            updateDBItem(item)
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
@@ -346,7 +356,7 @@ class Repository(
 | 
			
		||||
            _badgeStarred.value += 1
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        CoroutineScope(Dispatchers.Main).launch {
 | 
			
		||||
        CoroutineScope(Dispatchers.Default).launch {
 | 
			
		||||
            updateDBItem(item)
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
@@ -357,7 +367,7 @@ class Repository(
 | 
			
		||||
            _badgeStarred.value -= 1
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        CoroutineScope(Dispatchers.Main).launch {
 | 
			
		||||
        CoroutineScope(Dispatchers.Default).launch {
 | 
			
		||||
            updateDBItem(item)
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
@@ -369,7 +379,8 @@ class Repository(
 | 
			
		||||
        tags: String,
 | 
			
		||||
    ): Boolean {
 | 
			
		||||
        var response = false
 | 
			
		||||
        if (isNetworkAvailable()) {
 | 
			
		||||
        if (connectivityService.isNetworkAvailable()) {
 | 
			
		||||
            fetchedSources = false
 | 
			
		||||
            response = api
 | 
			
		||||
                .createSourceForVersion(
 | 
			
		||||
                    title,
 | 
			
		||||
@@ -390,7 +401,8 @@ class Repository(
 | 
			
		||||
        tags: String,
 | 
			
		||||
    ): Boolean {
 | 
			
		||||
        var response = false
 | 
			
		||||
        if (isNetworkAvailable()) {
 | 
			
		||||
        if (connectivityService.isNetworkAvailable()) {
 | 
			
		||||
            fetchedSources = false
 | 
			
		||||
            response = api.updateSourceForVersion(id, title, url, spout, tags).isSuccess == true
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
@@ -402,13 +414,14 @@ class Repository(
 | 
			
		||||
        title: String,
 | 
			
		||||
    ): Boolean {
 | 
			
		||||
        var success = false
 | 
			
		||||
        if (isNetworkAvailable()) {
 | 
			
		||||
        if (connectivityService.isNetworkAvailable()) {
 | 
			
		||||
            val response = api.deleteSource(id)
 | 
			
		||||
            success = response.isSuccess
 | 
			
		||||
            fetchedSources = false
 | 
			
		||||
        }
 | 
			
		||||
 | 
			
		||||
        // We filter on success or if the network isn't available
 | 
			
		||||
        if (success || !isNetworkAvailable()) {
 | 
			
		||||
        if (success || !connectivityService.isNetworkAvailable()) {
 | 
			
		||||
            items = ArrayList(items.filter { it.sourcetitle != title })
 | 
			
		||||
            setReaderItems(items)
 | 
			
		||||
            db.itemsQueries.deleteItemsWhereSource(title)
 | 
			
		||||
@@ -418,7 +431,7 @@ class Repository(
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    suspend fun updateRemote(): Boolean =
 | 
			
		||||
        if (isNetworkAvailable()) {
 | 
			
		||||
        if (connectivityService.isNetworkAvailable()) {
 | 
			
		||||
            api.update().data.equals("finished")
 | 
			
		||||
        } else {
 | 
			
		||||
            false
 | 
			
		||||
@@ -426,7 +439,7 @@ class Repository(
 | 
			
		||||
 | 
			
		||||
    suspend fun login(): Boolean {
 | 
			
		||||
        var result = false
 | 
			
		||||
        if (isNetworkAvailable()) {
 | 
			
		||||
        if (connectivityService.isNetworkAvailable()) {
 | 
			
		||||
            try {
 | 
			
		||||
                val response = api.login()
 | 
			
		||||
                result = response.isSuccess == true
 | 
			
		||||
@@ -439,7 +452,7 @@ class Repository(
 | 
			
		||||
 | 
			
		||||
    suspend fun checkIfFetchFails(): Boolean {
 | 
			
		||||
        var fetchFailed = true
 | 
			
		||||
        if (isNetworkAvailable()) {
 | 
			
		||||
        if (connectivityService.isNetworkAvailable()) {
 | 
			
		||||
            try {
 | 
			
		||||
                // Trying to fetch one item, and check someone is trying to use the app with
 | 
			
		||||
                // a random rss feed, that would throw a NoTransformationFoundException
 | 
			
		||||
@@ -453,7 +466,7 @@ class Repository(
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    suspend fun logout() {
 | 
			
		||||
        if (isNetworkAvailable()) {
 | 
			
		||||
        if (connectivityService.isNetworkAvailable()) {
 | 
			
		||||
            try {
 | 
			
		||||
                val response = api.logout()
 | 
			
		||||
                if (!response.isSuccess) {
 | 
			
		||||
@@ -481,7 +494,7 @@ class Repository(
 | 
			
		||||
    suspend fun updateApiInformation() {
 | 
			
		||||
        val apiMajorVersion = appSettingsService.getApiVersion()
 | 
			
		||||
 | 
			
		||||
        if (isNetworkAvailable()) {
 | 
			
		||||
        if (connectivityService.isNetworkAvailable()) {
 | 
			
		||||
            val fetchedInformation = api.apiInformation()
 | 
			
		||||
            if (fetchedInformation.success && fetchedInformation.data != null) {
 | 
			
		||||
                if (fetchedInformation.data.getApiMajorVersion() != apiMajorVersion) {
 | 
			
		||||
@@ -500,8 +513,6 @@ class Repository(
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    fun isNetworkAvailable() = isConnectionAvailable.value && !offlineOverride
 | 
			
		||||
 | 
			
		||||
    private fun getDBActions(): List<ACTION> = db.actionsQueries.actions().executeAsList()
 | 
			
		||||
 | 
			
		||||
    private fun deleteDBAction(action: ACTION) = db.actionsQueries.deleteAction(action.id)
 | 
			
		||||
 
 | 
			
		||||
@@ -82,7 +82,7 @@ class SelfossApi(
 | 
			
		||||
                }
 | 
			
		||||
                modifyRequest {
 | 
			
		||||
                    Napier.i("Will modify", tag = "HttpSend")
 | 
			
		||||
                    CoroutineScope(Dispatchers.Main).launch {
 | 
			
		||||
                    CoroutineScope(Dispatchers.IO).launch {
 | 
			
		||||
                        Napier.i("Will login", tag = "HttpSend")
 | 
			
		||||
                        login()
 | 
			
		||||
                        Napier.i("Did login", tag = "HttpSend")
 | 
			
		||||
 
 | 
			
		||||
@@ -0,0 +1,46 @@
 | 
			
		||||
package bou.amine.apps.readerforselfossv2.service
 | 
			
		||||
 | 
			
		||||
import dev.jordond.connectivity.Connectivity
 | 
			
		||||
import kotlinx.coroutines.CoroutineScope
 | 
			
		||||
import kotlinx.coroutines.Dispatchers
 | 
			
		||||
import kotlinx.coroutines.flow.MutableSharedFlow
 | 
			
		||||
import kotlinx.coroutines.flow.asSharedFlow
 | 
			
		||||
import kotlinx.coroutines.launch
 | 
			
		||||
 | 
			
		||||
class ConnectivityService {
 | 
			
		||||
    private val _networkAvailableProvider = MutableSharedFlow<Boolean>()
 | 
			
		||||
    val networkAvailableProvider = _networkAvailableProvider.asSharedFlow()
 | 
			
		||||
    private var currentStatus = true
 | 
			
		||||
    private lateinit var connectivity: Connectivity
 | 
			
		||||
 | 
			
		||||
    fun start() {
 | 
			
		||||
        connectivity = Connectivity()
 | 
			
		||||
        connectivity.start()
 | 
			
		||||
        CoroutineScope(Dispatchers.Default).launch {
 | 
			
		||||
            connectivity.statusUpdates.collect { status ->
 | 
			
		||||
                when (status) {
 | 
			
		||||
                    is Connectivity.Status.Connected -> {
 | 
			
		||||
                        if (!currentStatus) {
 | 
			
		||||
                            currentStatus = true
 | 
			
		||||
                            _networkAvailableProvider.emit(true)
 | 
			
		||||
                        }
 | 
			
		||||
                    }
 | 
			
		||||
 | 
			
		||||
                    is Connectivity.Status.Disconnected -> {
 | 
			
		||||
                        if (currentStatus) {
 | 
			
		||||
                            currentStatus = false
 | 
			
		||||
                            _networkAvailableProvider.emit(false)
 | 
			
		||||
                        }
 | 
			
		||||
                    }
 | 
			
		||||
                }
 | 
			
		||||
            }
 | 
			
		||||
        }
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
    fun isNetworkAvailable(): Boolean = currentStatus
 | 
			
		||||
 | 
			
		||||
    fun stop() {
 | 
			
		||||
        currentStatus = true
 | 
			
		||||
        connectivity.stop()
 | 
			
		||||
    }
 | 
			
		||||
}
 | 
			
		||||
		Reference in New Issue
	
	Block a user